[7.x] [App Search] Success toast polish pass (#103410)#103432
Merged
cee-chen merged 1 commit intoelastic:7.xfrom Jun 28, 2021
Merged
[7.x] [App Search] Success toast polish pass (#103410)#103432cee-chen merged 1 commit intoelastic:7.xfrom
cee-chen merged 1 commit intoelastic:7.xfrom
Conversation
* Fix toasts rerendering/resetting between page navigations + z-index issues - note: I opted to delete the `<Callouts>` component in favor of just reverting it to the old `<FlashMessages>`, now that FlashMessages is no longer responsible for toasts * Update engine creation success messages - to use a toast instead of a callout - update copy to match EUI guidelines * Update engine deletion success message - to use a toast instead of a callout - update copy to match EUI guidelines * Update source engines add/delete success messages - to use a toast instead of a callout - update copy to match EUI guidelines * Update crawler domain delete message - to use a toast instead of a callout - update copy to match EUI guidelines * Update API key create/update/delete sucess messages - to use a toast instead of a callout - update copy to match EUI guidelines * Update curations delete success message - to use a toast instead of a callout - update copy to match EUI guidelines * Update results settings success message - to use a toast instead of a callout - update copy to match EUI guidelines * Update relevance tuning success/reset messages - to use a toast (+ toast message) instead of a callout - update copy to match EUI guidelines * Update document deletion success message - to use a toast instead of a callout (+ split additional text) - update copy to match EUI guidelines * Update role mappings create/update/delete success messages - to use a toast instead of a callout - update copy to match EUI guidelines * Run i18n_check --fix - per localization team guidelines - strings that have been changed should get deleted/scheduled to be re-translated Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com> # Conflicts: # x-pack/plugins/enterprise_search/public/applications/app_search/components/crawler/crawler_overview_logic.test.ts # x-pack/plugins/enterprise_search/public/applications/app_search/components/crawler/crawler_overview_logic.ts
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backports the following commits to 7.x: