Re-use the filter function for inline filtering#10395
Merged
weltenwort merged 2 commits intoelastic:masterfrom Feb 16, 2017
Merged
Re-use the filter function for inline filtering#10395weltenwort merged 2 commits intoelastic:masterfrom
weltenwort merged 2 commits intoelastic:masterfrom
Conversation
Re-using the passed filter function improves consistency with the implementation of the filters in the document details table.
Bargs
suggested changes
Feb 16, 2017
Contributor
Bargs
left a comment
Bargs
left a comment
There was a problem hiding this comment.
Great cleanup! I totally missed this existing filter param while reviewing the previous PR. Left one minor comment.
| <% if (filterable) { %> | ||
| <span | ||
| ng-click="inlineFilter($event, '+')" | ||
| ng-click="inlineFilter('<%- column %>', '+')" |
Contributor
There was a problem hiding this comment.
We tried passing the column name directly like this in the original PR but there appeared to be encoding issues: https://github.com/elastic/kibana/pull/5344/files#r95694856
Member
Author
There was a problem hiding this comment.
Oh, thanks for pointing that out. In that case I'll defer that change to the major cleanup when we get rid of the lodash templating.
weltenwort
added a commit
that referenced
this pull request
Feb 16, 2017
The inline filters are now hidden when no `filter` property has been passed to the row directive, which is more consistent with the filters in the document details table. The context view relies on this behaviour to hide the filtering actions. Improving the `inlineFilter` to actually re-use the passed `filter` function happens in #10395.
Bargs
approved these changes
Feb 16, 2017
Contributor
|
LGTM |
elastic-jasper
added a commit
that referenced
this pull request
Feb 16, 2017
Backports PR #10395 **Commit 1:** Re-use the filter function for inline filtering Re-using the passed filter function improves consistency with the implementation of the filters in the document details table. * Original sha: 44cdfe8 * Authored by Felix Stürmer <stuermer@weltenwort.de> on 2017-02-16T14:45:42Z **Commit 2:** Revert back to using $event to avoid encoding problems * Original sha: eefba73 * Authored by Felix Stürmer <stuermer@weltenwort.de> on 2017-02-16T17:33:49Z
weltenwort
pushed a commit
that referenced
this pull request
Feb 16, 2017
Backports PR #10395 **Commit 1:** Re-use the filter function for inline filtering Re-using the passed filter function improves consistency with the implementation of the filters in the document details table. * Original sha: 44cdfe8 * Authored by Felix Stürmer <stuermer@weltenwort.de> on 2017-02-16T14:45:42Z **Commit 2:** Revert back to using $event to avoid encoding problems * Original sha: eefba73 * Authored by Felix Stürmer <stuermer@weltenwort.de> on 2017-02-16T17:33:49Z
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Re-using the passed filter function improves consistency with the
implementation of the filters in the document details table.