Hide inline filters in absence of filter function#10394
Merged
weltenwort merged 1 commit intoelastic:masterfrom Feb 16, 2017
Merged
Hide inline filters in absence of filter function#10394weltenwort merged 1 commit intoelastic:masterfrom
weltenwort merged 1 commit intoelastic:masterfrom
Conversation
The inline filters are now hidden when no `filter` property has been passed to the row directive, which is more consistent with the filters in the document details table. The context view relies on this behaviour to hide the filtering actions. Improving the `inlineFilter` to actually re-use the passed `filter` function will happen in a separate PR.
Member
Author
|
jenkins, test this |
elastic-jasper
added a commit
that referenced
this pull request
Feb 16, 2017
Backports PR #10394 **Commit 1:** Hide inline filters in absence of filter function The inline filters are now hidden when no `filter` property has been passed to the row directive, which is more consistent with the filters in the document details table. The context view relies on this behaviour to hide the filtering actions. Improving the `inlineFilter` to actually re-use the passed `filter` function will happen in a separate PR. * Original sha: 51041f8 * Authored by Felix Stürmer <stuermer@weltenwort.de> on 2017-02-16T14:37:42Z
weltenwort
pushed a commit
that referenced
this pull request
Feb 16, 2017
Backports PR #10394 **Commit 1:** Hide inline filters in absence of filter function The inline filters are now hidden when no `filter` property has been passed to the row directive, which is more consistent with the filters in the document details table. The context view relies on this behaviour to hide the filtering actions. Improving the `inlineFilter` to actually re-use the passed `filter` function will happen in a separate PR. * Original sha: 51041f8 * Authored by Felix Stürmer <stuermer@weltenwort.de> on 2017-02-16T14:37:42Z
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The inline filters are now hidden when no
filterproperty has beenpassed to the row directive, which is more consistent with the filters
in the document details table. The context view relies on this behaviour
to hide the filtering actions.
Improving the
inlineFilterto actually re-use the passedfilterfunction happens in #10395.