Skip to content

[build] Remove OSS builds#103685

Merged
jbudz merged 6 commits intoelastic:masterfrom
jbudz:build/rm-oss-2
Jun 29, 2021
Merged

[build] Remove OSS builds#103685
jbudz merged 6 commits intoelastic:masterfrom
jbudz:build/rm-oss-2

Conversation

@jbudz
Copy link
Contributor

@jbudz jbudz commented Jun 29, 2021

Reopening of #100577.

The --oss flag was incorrectly accepted as an argument, which created a build with no targets. This removes oss as an accepted argument and removes this flag from the baseline job.

@jbudz jbudz added Team:Operations Kibana-Operations Team v8.0.0 release_note:skip Skip the PR/issue when compiling release notes v7.14.0 labels Jun 29, 2021
@jbudz jbudz requested a review from a team as a code owner June 29, 2021 15:08
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-operations (Team:Operations)

@jbudz
Copy link
Contributor Author

jbudz commented Jun 29, 2021

Here's a run of the baseline job that failued before after we merged: https://kibana-ci.elastic.co/job/elastic+kibana+baseline-capture/22204/console

@tylersmalley
Copy link
Member

@jbudz do we also need to remove --no-oss instances from here?:

  • test/scripts/jenkins_xpack_package_build.sh#L10
  • docs/developer/contributing/development-package-tests.asciidoc
  • test/scripts/jenkins_xpack_package_build.sh

@jbudz
Copy link
Contributor Author

jbudz commented Jun 29, 2021

Good catch, these were in between merges. Pushed with c2edf73

@spalger spalger changed the title [build] Remove OSS builds (#100577) [build] Remove OSS builds Jun 29, 2021
Copy link
Contributor

@spalger spalger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM on green CI

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@jbudz
Copy link
Contributor Author

jbudz commented Jun 29, 2021

@elasticmachine run elasticsearch-ci/docs

@jbudz jbudz merged commit 7359fab into elastic:master Jun 29, 2021
@jbudz jbudz deleted the build/rm-oss-2 branch June 29, 2021 23:17
jbudz added a commit to jbudz/kibana that referenced this pull request Jun 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport pending release_note:skip Skip the PR/issue when compiling release notes Team:Operations Kibana-Operations Team v7.14.0 v8.0.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants