Skip to content

[build] Remove OSS builds#100577

Merged
jbudz merged 9 commits intoelastic:masterfrom
jbudz:build/rm-oss
Jun 29, 2021
Merged

[build] Remove OSS builds#100577
jbudz merged 9 commits intoelastic:masterfrom
jbudz:build/rm-oss

Conversation

@jbudz
Copy link
Contributor

@jbudz jbudz commented May 25, 2021 •
edited
Loading

This removes the oss and no-oss flags from node scripts/builds and
the related build outputs.

@jbudz
[build] Remove OSS builds
4e06693 
This removes the `oss` and `no-oss` flags from `node scripts/builds` and
the related builds.
@jbudz jbudz added Team:Operations Kibana-Operations Team v7.14.0 v8.0.0 release_note:skip Skip the PR/issue when compiling release notes labels May 25, 2021
@jbudz jbudz marked this pull request as ready for review May 26, 2021 17:00
@jbudz jbudz requested a review from a team as a code owner May 26, 2021 17:00
@elasticmachine
Copy link
Contributor

elasticmachine commented May 26, 2021

Pinging @elastic/kibana-operations (Team:Operations)

mistic
mistic approved these changes May 26, 2021
View reviewed changes
Copy link
Contributor

@mistic mistic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jbudz
Copy link
Contributor Author

jbudz commented May 26, 2021

Merge pending - waiting for #99980

@jbudz
Copy link
Contributor Author

jbudz commented Jun 1, 2021

@elasticmachine merge upstream

@jbudz
Copy link
Contributor Author

jbudz commented Jun 17, 2021

I'll reopen this when we're ready for it.

@jbudz jbudz closed this Jun 17, 2021
@tylersmalley tylersmalley reopened this Jun 23, 2021
@tylersmalley
Copy link
Member

tylersmalley commented Jun 23, 2021

@elasticmachine merge upstream

@tylersmalley
Copy link
Member

tylersmalley commented Jun 23, 2021

We're ready - the backport was merged into 7.x

@tylersmalley
Copy link
Member

tylersmalley commented Jun 23, 2021

@elasticmachine merge upstream

@jbudz
Copy link
Contributor Author

jbudz commented Jun 24, 2021

🎈 is anyone able to do a pass with this up to date again?

@jbudz
Copy link
Contributor Author

jbudz commented Jun 28, 2021

@elasticmachine merge upstream

@kibanamachine
Copy link
Contributor

kibanamachine commented Jun 28, 2021

💚 Build Succeeded

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@kibanamachine
Copy link
Contributor

kibanamachine commented Jun 28, 2021

💚 Build Succeeded

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@jbudz jbudz added the auto-backport Deprecated - use backport:version if exact versions are needed label Jun 29, 2021
@jbudz jbudz merged commit b2d76a6 into elastic:master Jun 29, 2021
@jbudz jbudz deleted the build/rm-oss branch June 29, 2021 14:22
@kibanamachine
Copy link
Contributor

kibanamachine commented Jun 29, 2021

💔 Backport failed

Status Branch Result
❌ 7.x Commit could not be cherrypicked due to conflicts

To backport manually run:
node scripts/backport --pr 100577

@jbudz jbudz added backport pending and removed auto-backport Deprecated - use backport:version if exact versions are needed labels Jun 29, 2021
@jbudz jbudz mentioned this pull request Jun 29, 2021
Closed
jbudz added a commit that referenced this pull request Jun 29, 2021
@jbudz
Revert "[build] Remove OSS builds (#100577)"
24661fe 
This reverts commit b2d76a6.
jbudz added a commit to jbudz/kibana that referenced this pull request Jun 29, 2021
@jbudz
Revert "Revert "[build] Remove OSS builds (elastic#100577)""
865ec52 
This reverts commit 24661fe.
@jbudz jbudz mentioned this pull request Jun 29, 2021
Merged
@kibanamachine kibanamachine added the backport missing Added to PRs automatically when the are determined to be missing a backport. label Jun 30, 2021
@kibanamachine
Copy link
Contributor

kibanamachine commented Jun 30, 2021

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create backports run node scripts/backport --pr 100577 or prevent reminders by adding the backport:skip label.

@kibanamachine kibanamachine removed the backport missing Added to PRs automatically when the are determined to be missing a backport. label Jun 30, 2021
@jbudz
Copy link
Contributor Author

jbudz commented Jun 30, 2021

Backported by #103792

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mistic mistic mistic approved these changes

+1 more reviewer

@spalger spalger spalger approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

backported release_note:skip Skip the PR/issue when compiling release notes Team:Operations Kibana-Operations Team v7.14.0 v8.0.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@jbudz @elasticmachine @tylersmalley @kibanamachine @spalger @mistic