[canvas] Restore Workpad Title/button to Home; fix mounting behavior#103601
[canvas] Restore Workpad Title/button to Home; fix mounting behavior#103601clintandrewhall merged 4 commits intoelastic:masterfrom
Conversation
|
Pinging @elastic/kibana-presentation (Team:Presentation) |
There was a problem hiding this comment.
It feels a little odd to redirect the user back to the Canvas home page when they click on the workpad title on the bottom left. For a user new to Canvas, I think I'd be a little confused why clicking on the title in the bottom left backed me out of the workpad, since that's not what the workpad title breadcrumb does when you click on it (which just reloads the same workpad).
I'd be in favor of leaving it removed or making it static text, and have the users only navigate via the breadcrumbs. I don't believe there's a button to redirect you back to the dashboard listing when you're in a dashboard besides the breadcrumbs, and I think it'd be fine to expect the same in Canvas.
On that note looking in Dashboard, it looks like the dashboard title breadcrumb isn't clickable, so we should probably follow the same pattern and make the workpad title breadcrumb just static text.
The rest of the code LGTM 👍
|
@cqliu1 I agree, and made the changes you suggested. Thanks! |
|
jenkins test this |
|
@elasticmachine merge upstream |
💚 Build Succeeded
Metrics [docs]Module Count
Async chunks
History
To update your PR or re-run it, just comment with: |
💚 Backport successful
This backport PR will be merged automatically after passing CI. |

Summary
#102446 removed the Canvas title in the lower-left, as it opened a Workpad dialog that we removed, and the breadcrumb navigation provided the same functionality. Thinking back on it, it made sense to restore that button, but just have it also link home.
This PR also fixes an issue where the initial load of Workpads fires too many times, (as the
onMounthook doesn't fire only once).