Skip to content

[APM] Only register items in side nav if user has permissions to see app#101707

Merged
sorenlouv merged 3 commits intoelastic:masterfrom
sorenlouv:check—permissions-when-showing-side-nav
Jun 9, 2021

Hidden character warning

The head ref may contain hidden characters: "check\u2014permissions-when-showing-side-nav"
Merged

[APM] Only register items in side nav if user has permissions to see app#101707
sorenlouv merged 3 commits intoelastic:masterfrom
sorenlouv:check—permissions-when-showing-side-nav

Conversation

@sorenlouv
Copy link
Member

Closes #101512

@sorenlouv sorenlouv requested review from a team and shahzad31 June 9, 2021 07:29
@botelastic botelastic bot added the Team:APM - DEPRECATED Use Team:obs-ux-infra_services. label Jun 9, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/apm-ui (Team:apm)

@sorenlouv sorenlouv added release_note:skip Skip the PR/issue when compiling release notes v7.14.0 labels Jun 9, 2021
@sorenlouv sorenlouv enabled auto-merge (squash) June 9, 2021 08:19
@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
apm 4.3MB 4.3MB +8.0B

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
apm 32.8KB 33.0KB +284.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@sorenlouv sorenlouv merged commit d3ce128 into elastic:master Jun 9, 2021
@sorenlouv sorenlouv deleted the check—permissions-when-showing-side-nav branch June 9, 2021 10:54
@sorenlouv sorenlouv added the auto-backport Deprecated - use backport:version if exact versions are needed label Jun 9, 2021
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Jun 9, 2021
@kibanamachine
Copy link
Contributor

💚 Backport successful

Status Branch Result
7.x

This backport PR will be merged automatically after passing CI.

kibanamachine added a commit that referenced this pull request Jun 9, 2021
…app (#101707) (#101728)

Co-authored-by: Søren Louv-Jansen <sorenlouv@gmail.com>
gmmorris added a commit to gmmorris/kibana that referenced this pull request Jun 9, 2021
* master:
  clarify which parts of TM are experimental (elastic#101757)
  Add sh scripts with _bulk_action route usage examples (elastic#101736)
  [Uptime] Only register route in side nav if uptime show capability is true (elastic#101709)
  Use KIBANA_DOCS in doc link service (elastic#101667)
  [Alerting][Event log] Persisting duration information for active alerts in event log (elastic#101387)
  Address design issues in Discover/Graph (elastic#101584)
  Optimize performance for document table (elastic#101715)
  Change file data visualizer links to point to new location in home application (elastic#101393)
  [Fleet] Tighten policy permissions, take II (elastic#97366)
  [ML] Add debounce to the severity control update  (elastic#101581)
  [Fleet] Fix routing issues with `getPath` and `history.push` (elastic#101658)
  [APM] Add link-to/transaction route (elastic#101731)
  [Index Patterns] Runtime fields CRUD REST API  (elastic#101164)
  [ILM] Refactor types and fix missing aria labels (elastic#101518)
  [Lens] New summary row feature for datatable (elastic#101075)
  Blocks save event filter with a white space name (elastic#101599)
  Improve security server types (elastic#101661)
  [APM] Replace side nav with tabs on Settings page (elastic#101460)
  [APM] Only register items in side nav if user has permissions to see app (elastic#101707)
  [Security solution][Endpoint] Add back button when to the event filters list (elastic#101280)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

auto-backport Deprecated - use backport:version if exact versions are needed release_note:skip Skip the PR/issue when compiling release notes Team:APM - DEPRECATED Use Team:obs-ux-infra_services. v7.14.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[APM] Solution navigation: Restricted permissions to view app should be reflected in the navigation options

5 participants