[ILM] Refactor types and fix missing aria labels#101518
Merged
yuliacech merged 5 commits intoelastic:masterfrom Jun 9, 2021
Merged
[ILM] Refactor types and fix missing aria labels#101518yuliacech merged 5 commits intoelastic:masterfrom
yuliacech merged 5 commits intoelastic:masterfrom
Conversation
…es_refactor # Conflicts: # x-pack/plugins/index_lifecycle_management/__jest__/client_integration/edit_policy/form_validation/timing.test.ts
yuliacech
added
release_note:skip
Contributor
|
Pinging @elastic/kibana-stack-management (Team:Stack Management) |
Contributor
💚 Build SucceededMetrics [docs]Async chunks
History
To update your PR or re-run it, just comment with: |
sebelga
approved these changes
Jun 9, 2021
Contributor
sebelga
left a comment
sebelga
left a comment
There was a problem hiding this comment.
LGTM! Thanks for tidy things up @yuliacech and great catch on the missing arial labels! 👍
|
|
||
| export type PhaseWithTiming = keyof Omit<Phases, 'hot'>; | ||
|
|
||
| export type PhaseExceptDelete = keyof Omit<Phases, 'delete'>; |
Contributor
Author
|
Thank you so much for the review, @sebelga! |
yuliacech
added a commit
to yuliacech/kibana
that referenced
this pull request
Jun 9, 2021
* Refactor phase types (mostly moving imports) * Refactor phase types (mostly moving imports) * Renamed a type for consistency and replaced more hard coded strings with types * Fixed remaining references to the deleted MinAgePhase
yuliacech
added a commit
that referenced
this pull request
Jun 9, 2021
* Refactor phase types (mostly moving imports) * Refactor phase types (mostly moving imports) * Renamed a type for consistency and replaced more hard coded strings with types * Fixed remaining references to the deleted MinAgePhase
gmmorris
added a commit
to gmmorris/kibana
that referenced
this pull request
Jun 9, 2021
* master: clarify which parts of TM are experimental (elastic#101757) Add sh scripts with _bulk_action route usage examples (elastic#101736) [Uptime] Only register route in side nav if uptime show capability is true (elastic#101709) Use KIBANA_DOCS in doc link service (elastic#101667) [Alerting][Event log] Persisting duration information for active alerts in event log (elastic#101387) Address design issues in Discover/Graph (elastic#101584) Optimize performance for document table (elastic#101715) Change file data visualizer links to point to new location in home application (elastic#101393) [Fleet] Tighten policy permissions, take II (elastic#97366) [ML] Add debounce to the severity control update (elastic#101581) [Fleet] Fix routing issues with `getPath` and `history.push` (elastic#101658) [APM] Add link-to/transaction route (elastic#101731) [Index Patterns] Runtime fields CRUD REST API (elastic#101164) [ILM] Refactor types and fix missing aria labels (elastic#101518) [Lens] New summary row feature for datatable (elastic#101075) Blocks save event filter with a white space name (elastic#101599) Improve security server types (elastic#101661) [APM] Replace side nav with tabs on Settings page (elastic#101460) [APM] Only register items in side nav if user has permissions to see app (elastic#101707) [Security solution][Endpoint] Add back button when to the event filters list (elastic#101280)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow up to PR#100807.
This PR refactors a type union like
'warm' | 'cold' | 'frozen' | 'delete'to an interfacePhaseWithTimingand extracts it into thetypes.tsfile. While refactoring I also found that aria labels for timing in frozen phase were missing.