Skip to content

[CCR] Replace EuiCodeEditor with EuiCodeBlock #100122

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
alisonelizabeth merged 10 commits into from
May 20, 2021
Merged

[CCR] Replace EuiCodeEditor with EuiCodeBlock #100122

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
2aea373
replace EuiCodeEditor with EuiCodeBlock
alisonelizabeth May 14, 2021
6275491
Merge branch 'master' into ccr-tests
kibanamachine May 14, 2021
22ad0c1
Merge branch 'master' into ccr-tests
kibanamachine May 17, 2021
c3fb1ad
Merge branch 'master' into ccr-tests
kibanamachine May 17, 2021
11fcefb
Merge branch 'master' into ccr-tests
kibanamachine May 17, 2021
41e34d9
Merge branch 'master' into ccr-tests
kibanamachine May 18, 2021
2c6d37e
Merge branch 'master' into ccr-tests
kibanamachine May 18, 2021
20bfd7b
Merge branch 'master' into ccr-tests
kibanamachine May 18, 2021
75e8727
Merge branch 'master' into ccr-tests
kibanamachine May 19, 2021
800d3d2
address feedback
alisonelizabeth May 20, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 4 additions & 8 deletions ...ross_cluster_replication/public/__jest__/client_integration/follower_indices_list.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -379,16 +379,12 @@ describe('<FollowerIndicesList />', () => {
test('should have a section to render the follower index shards stats', async () => {
await actions.clickFollowerIndexAt(0);
expect(exists('followerIndexDetail.shardsStatsSection')).toBe(true);
});

test('should render a EuiCodeEditor for each shards stats', async () => {
await actions.clickFollowerIndexAt(0);

const codeEditors = component.find(`EuiCodeEditor`);
const codeBlocks = find('shardsStats');

expect(codeEditors.length).toBe(index1.shards.length);
codeEditors.forEach((codeEditor, i) => {
expect(JSON.parse(codeEditor.props().value)).toEqual(index1.shards[i]);
expect(codeBlocks.length).toBe(index1.shards.length);
codeBlocks.forEach((codeBlock, i) => {
expect(JSON.parse(codeBlock.props().children)).toEqual(index1.shards[i]);
});
});
});
Expand Down
17 changes: 4 additions & 13 deletions ...on/public/app/sections/home/follower_indices_list/components/detail_panel/detail_panel.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ import {
EuiButton,
EuiButtonEmpty,
EuiCallOut,
EuiCodeEditor,
EuiCodeBlock,
EuiDescriptionList,
EuiDescriptionListDescription,
EuiDescriptionListTitle,
Expand Down Expand Up @@ -356,18 +356,9 @@ export class DetailPanel extends Component {
</h3>
</EuiTitle>
<EuiSpacer size="s" />
<EuiCodeEditor
mode="json"
theme="textmate"
width="100%"
isReadOnly
setOptions={{ maxLines: Infinity }}
value={JSON.stringify(shard, null, 2)}
editorProps={{
$blockScrolling: Infinity,
}}
data-test-subj={`shardsStats${i}`}
/>
<EuiCodeBlock language="json" data-test-subj="shardsStats">
{JSON.stringify(shard, null, 2)}
</EuiCodeBlock>
</Fragment>
))}
</section>
Expand Down