[CCR] Replace EuiCodeEditor with EuiCodeBlock#100122
Merged
alisonelizabeth merged 10 commits intoelastic:masterfrom May 20, 2021
Merged
[CCR] Replace EuiCodeEditor with EuiCodeBlock#100122alisonelizabeth merged 10 commits intoelastic:masterfrom
alisonelizabeth merged 10 commits intoelastic:masterfrom
Conversation
alisonelizabeth
added
chore
Feature:CCR and Remote Clusters
v8.0.0
Team:Kibana Management
Contributor
Author
|
@elasticmachine merge upstream |
Contributor
Author
|
@elasticmachine merge upstream |
Contributor
Author
|
@elasticmachine merge upstream |
Contributor
Author
|
@elasticmachine merge upstream |
Contributor
Author
|
@elasticmachine merge upstream |
Contributor
Author
|
@elasticmachine merge upstream |
Contributor
Author
|
@elasticmachine merge upstream |
Contributor
Author
|
@elasticmachine merge upstream |
Contributor
|
Pinging @elastic/es-ui (Team:Elasticsearch UI) |
sebelga
approved these changes
May 20, 2021
| await actions.clickFollowerIndexAt(0); | ||
|
|
||
| const codeEditors = component.find(`EuiCodeEditor`); | ||
| const codeBlocks = component.find('EuiCodeBlock'); |
Contributor
There was a problem hiding this comment.
Wouldn't it be better to access the code blocks with the test subject shardsStats?
const codeBlocks = find('shardsStats');
Contributor
💚 Build SucceededMetrics [docs]Async chunks
Unknown metric groupsReferences to deprecated APIs
History
To update your PR or re-run it, just comment with: |
alisonelizabeth
added a commit
that referenced
this pull request
May 20, 2021
yctercero
pushed a commit
to yctercero/kibana
that referenced
this pull request
May 25, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR replaces the use of
EuiCodeEditorwithEuiCodeBlockfor the shards section shown on the details panel for follower indices in CCR. We only need to render read-only JSON and theEuiCodeEditoris also being deprecated (elastic/eui#4683).I've also consolidated the tests to verify the shards section to a single test.
To test CCR, you will need to set up a remote cluster:
Fixes #99871
// While I'm not 100% if this change will resolve the test flakiness, the test has been refactored and renamed, so I believe a new issue would be reopened if there are still issues (hence closing this one). I have also run through this through CI without any failures.