Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Security Solution] Write tests for "Customized Elastic rule" badge on the Rule Details page #186916

Open
Tracked by #174168
nikitaindik opened this issue Jun 25, 2024 · 3 comments
Open
Tracked by #174168

[Security Solution] Write tests for "Customized Elastic rule" badge on the Rule Details page #186916

nikitaindik opened this issue Jun 25, 2024 · 3 comments
Assignees
@nikitaindik
Labels
8.18 candidate Feature:Prebuilt Detection Rules Security Solution Prebuilt Detection Rules Feature:Rule Details Security Solution Detection Rule Details Team:Detection Rule Management Security Detection Rule Management Team Team:Detections and Resp Security Detection Response Team Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. technical debt Improvement of the software architecture and operational architecture test-coverage issues & PRs for improving code test coverage

Comments

@nikitaindik
Copy link
Contributor

Epics: https://github.com/elastic/security-team/issues/1974 (internal), #174168

We've added the badge in #180170, but we didn't add a test because the API changes that add rule_source.is_customized weren't implemented. Add a test once the API changes are ready.
@nikitaindik nikitaindik added test-coverage issues & PRs for improving code test coverage Team:Detections and Resp Security Detection Response Team Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. Team:Detection Rule Management Security Detection Rule Management Team labels Jun 25, 2024
@nikitaindik nikitaindik self-assigned this Jun 25, 2024
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-detections-response (Team:Detections and Resp)

@elasticmachine
Copy link
Contributor

Pinging @elastic/security-solution (Team: SecuritySolution)

@elasticmachine
Copy link
Contributor

Pinging @elastic/security-detection-rule-management (Team:Detection Rule Management)

This was referenced Jun 25, 2024
Merged
Open
@banderror banderror added technical debt Improvement of the software architecture and operational architecture Feature:Prebuilt Detection Rules Security Solution Prebuilt Detection Rules Feature:Rule Details Security Solution Detection Rule Details 8.15 candidate labels Jun 25, 2024
nikitaindik added a commit that referenced this issue Jun 26, 2024
@nikitaindik
[Security Solution] Add "Customized Elastic rule" badge to Rule Detai…
199e2ad 
…ls page (#186914)

**Resolves: #180170

## Summary
This PR adds a "Customized Elastic rule" badge to the Rule Details page.
This badge is only displayed if a rule has `rule_source.is_customized`
set to `true` and the feature flag is turned on.

Tests for this feature will be added later under a separate ticket
(#186916).

### Screenshots
**Customized Elastic rule – has badge**
<img width="827" alt="Scherm­afbeelding 2024-06-25 om 19 29 47"
src="https://github.com/elastic/kibana/assets/15949146/be64271f-5f91-46a9-aa71-35594c788586">

**Custom rule – no badge**
<img width="827" alt="Scherm­afbeelding 2024-06-25 om 19 29 02"
src="https://github.com/elastic/kibana/assets/15949146/c576bf52-efde-46dd-88af-9fdf5f0b44ea">
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nikitaindik nikitaindik

Labels
8.18 candidate Feature:Prebuilt Detection Rules Security Solution Prebuilt Detection Rules Feature:Rule Details Security Solution Detection Rule Details Team:Detection Rule Management Security Detection Rule Management Team Team:Detections and Resp Security Detection Response Team Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. technical debt Improvement of the software architecture and operational architecture test-coverage issues & PRs for improving code test coverage
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@jpdjere @banderror @elasticmachine @nikitaindik