Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Security Solution] Show if a rule is customized on the Rule Details page #180170

Closed
Tracked by #174168
jpdjere opened this issue Apr 5, 2024 · 3 comments · Fixed by #186914
Closed
Tracked by #174168

[Security Solution] Show if a rule is customized on the Rule Details page #180170

jpdjere opened this issue Apr 5, 2024 · 3 comments · Fixed by #186914
Assignees
@nikitaindik
Labels
8.15 candidate enhancement New value added to drive a business result Feature:Prebuilt Detection Rules Security Solution Prebuilt Detection Rules Team:Detection Rule Management Security Detection Rule Management Team Team:Detections and Resp Security Detection Response Team Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. v8.15.0

Comments

@jpdjere
Copy link
Contributor

jpdjere commented Apr 5, 2024 •
edited by nikitaindik
Loading

Epics: https://github.com/elastic/security-team/issues/1974 (internal), #174168
Design Discussion context: #178211

Summary

  • Show if a rule is customized on the Rule Details page.
  • Based on the final design discussion with @ARWNightingale on 28-03-2024, we want to show if a rule is customized in the Rules Detail page with:
    • An extra text label in the header of the page, before the Last Response information.
    • The label should read: Customized Elastic rule if the rule has been customized.
    • If the rule is custom or is Elastic prebuilt but hasn't been customized, do not add a label.
@jpdjere jpdjere added triage_needed Team:Detections and Resp Security Detection Response Team Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. Team:Detection Rule Management Security Detection Rule Management Team Feature:Prebuilt Detection Rules Security Solution Prebuilt Detection Rules labels Apr 5, 2024
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-detections-response (Team:Detections and Resp)

@elasticmachine
Copy link
Contributor

Pinging @elastic/security-detection-rule-management (Team:Detection Rule Management)

@elasticmachine
Copy link
Contributor

Pinging @elastic/security-solution (Team: SecuritySolution)

@jpdjere jpdjere mentioned this issue Apr 5, 2024
Open
@banderror banderror changed the title [Security Solution] Show if a rule is customized on the Rule Details page [Security Solution] Show if a rule is customized on the Rule Details page (DRAFT) Apr 17, 2024
@nikitaindik nikitaindik self-assigned this Jun 24, 2024
@banderror banderror added enhancement New value added to drive a business result 8.15 candidate and removed triage_needed labels Jun 25, 2024
@jpdjere jpdjere changed the title [Security Solution] Show if a rule is customized on the Rule Details page (DRAFT) [Security Solution] Show if a rule is customized on the Rule Details page Jun 25, 2024
This was referenced Jun 25, 2024
Open
Merged
nikitaindik added a commit that referenced this issue Jun 26, 2024
@nikitaindik
[Security Solution] Add "Customized Elastic rule" badge to Rule Detai…
199e2ad 
…ls page (#186914)

**Resolves: #180170

## Summary
This PR adds a "Customized Elastic rule" badge to the Rule Details page.
This badge is only displayed if a rule has `rule_source.is_customized`
set to `true` and the feature flag is turned on.

Tests for this feature will be added later under a separate ticket
(#186916).

### Screenshots
**Customized Elastic rule – has badge**
<img width="827" alt="Scherm­afbeelding 2024-06-25 om 19 29 47"
src="https://github.com/elastic/kibana/assets/15949146/be64271f-5f91-46a9-aa71-35594c788586">

**Custom rule – no badge**
<img width="827" alt="Scherm­afbeelding 2024-06-25 om 19 29 02"
src="https://github.com/elastic/kibana/assets/15949146/c576bf52-efde-46dd-88af-9fdf5f0b44ea">
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nikitaindik nikitaindik

Labels
8.15 candidate enhancement New value added to drive a business result Feature:Prebuilt Detection Rules Security Solution Prebuilt Detection Rules Team:Detection Rule Management Security Detection Rule Management Team Team:Detections and Resp Security Detection Response Team Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. v8.15.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Security Solution] Add "Customized Elastic rule" badge to Rule Details page nikitaindik/kibana
4 participants
@jpdjere @banderror @elasticmachine @nikitaindik