[network_traffic] Add missing field mappings in DNS and TLS#3078
Merged
andrewkroh merged 7 commits intoelastic:mainfrom Apr 19, 2022
andrewkroh:network_traffic/bugfix/add-missing-field-mappings
Merged
[network_traffic] Add missing field mappings in DNS and TLS#3078andrewkroh merged 7 commits intoelastic:mainfrom andrewkroh:network_traffic/bugfix/add-missing-field-mappings
andrewkroh merged 7 commits intoelastic:mainfrom
andrewkroh:network_traffic/bugfix/add-missing-field-mappings
Conversation
andrewkroh
added
bug
|
Pinging @elastic/security-external-integrations (Team:Security-External Integrations) |
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
🤖 GitHub commentsTo re-run your PR in the CI, just comment with:
|
[git-generate] cd packages/network_traffic for ds in $(ls data_stream); do yq -i '. | sort_by(.name)' data_stream/$ds/fields/ecs.yml; done for ds in $(ls data_stream); do yq -i 'sort_keys(..)' data_stream/$ds/fields/ecs.yml; done elastic-package format
Arrays fields are not validated by elastic-package so these were missed.
Add another TLS test case to expose more TLS fields. Import ECS mappings for all of `tls.*`. Convert tls.*.x509.version_number to string Remove unused tls.*.x509.version mapping
- Remove tls.detailed.{client,server}_certificate.
- Update dashboards to use tls.{client,server}.x509.* instead of tls.detailed.{client,server}_certificate.*
- Remove mappings for 'province'. Those fields was renamed in Packetbeat 7.9 to state_or_province (per ECS) (elastic/beats#19167).
[git-generate] cd packages/network_traffic elastic-package build
[git-generate] cd packages/network_traffic elastic-package-changelog add-next -d "Add missing field mappings to DNS and TLS data streams." --type=bug --pr 3078
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
A user reported missing mappings for the following fields which caused a conflict with ECS data types.
dns.answersis an array of objects and IIUCelastic-packagedoes not validate this data type. So I added the ECSdns.answer.*fields.For
tlswe did not have a system test in place that generatedtls.serverfields so I added one. This uncovered some issues and inconsistencies between Agent 7.17 and 8.2.tls.*.tls.detailed.{client,server}_certificate(legacy/pre-ECS fields that are now duplicated into ECS fields).tls.{client,server}.x509.*instead oftls.detailed.{client,server}_certificate.*.state_or_province(per ECS) ([Packetbeat] ECS 1.5 update beats#19167).I also found some
event.*fields that were not documented due to elastic/elastic-package#147.Checklist
changelog.ymlfile.