[Packetbeat] ECS 1.5 update#19167
Merged
andrewstucki merged 5 commits intoelastic:masterfrom Jun 18, 2020
Merged
Conversation
Contributor
|
Pinging @elastic/siem (Team:SIEM) |
Contributor
andrewkroh
reviewed
Jun 12, 2020
Member
andrewkroh
left a comment
There was a problem hiding this comment.
This looks good 👍 . Another person should look it over too. It needs a changelog entry.
adriansr
reviewed
Jun 13, 2020
Contributor
adriansr
left a comment
There was a problem hiding this comment.
LGTM
Left a couple of minor suggestions.
adriansr
approved these changes
Jun 18, 2020
6 tasks
andrewstucki
pushed a commit
to andrewstucki/beats
that referenced
this pull request
Jun 18, 2020
* Add packetbeat changes * Fix up tests * Add changelog entry * Add compile time upgrade guard as a reminder and add inline marshal tag for ecs * Fix early termination for marshaling code (cherry picked from commit 9e9aa88)
andrewstucki
pushed a commit
that referenced
this pull request
Jun 18, 2020
melchiormoulin
pushed a commit
to melchiormoulin/beats
that referenced
this pull request
Oct 14, 2020
* Add packetbeat changes * Fix up tests * Add changelog entry * Add compile time upgrade guard as a reminder and add inline marshal tag for ecs * Fix early termination for marshaling code
4 tasks
andrewkroh
added a commit
to elastic/integrations
that referenced
this pull request
Apr 19, 2022
* Sort all ecs.yml by field name
[git-generate]
cd packages/network_traffic
for ds in $(ls data_stream); do yq -i '. | sort_by(.name)' data_stream/$ds/fields/ecs.yml; done
for ds in $(ls data_stream); do yq -i 'sort_keys(..)' data_stream/$ds/fields/ecs.yml; done
elastic-package format
* Add missing dns.answers.* fields
Arrays fields are not validated by elastic-package so these were missed.
* Add missing TLS field mappings
Add another TLS test case to expose more TLS fields.
Import ECS mappings for all of `tls.*`.
Convert tls.*.x509.version_number to string
Remove unused tls.*.x509.version mapping
* Remove duplicated TLS fields from Packetbeat 7.17
- Remove tls.detailed.{client,server}_certificate.
- Update dashboards to use tls.{client,server}.x509.* instead of tls.detailed.{client,server}_certificate.*
- Remove mappings for 'province'. Those fields was renamed in Packetbeat 7.9 to state_or_province (per ECS) (elastic/beats#19167).
* Add missing event.* field mappings
* Update readme
[git-generate]
cd packages/network_traffic
elastic-package build
* Add changelog entry
[git-generate]
cd packages/network_traffic
elastic-package-changelog add-next -d "Add missing field mappings to DNS and TLS data streams." --type=bug --pr 3078
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Updates
packetbeatto use ECS categorization andrelated.ipfields. Also, readies the TLS protocol parser to use the newx509fields coming in 1.6.Checklist
CHANGELOG.next.asciidocorCHANGELOG-developer.next.asciidoc.Related issues