Skip to content

[1password] Add new event.action to 1Password item usages#2775

Merged
P1llus merged 3 commits intoelastic:mainfrom
1Password:1password_action_geolocation
Mar 8, 2022
Merged

[1password] Add new event.action to 1Password item usages#2775
P1llus merged 3 commits intoelastic:mainfrom
1Password:1password_action_geolocation

Conversation

@anthonythleung
Copy link
Contributor

What does this PR do?

This PR adds the event.action field to Item Usages stream and remove the newly added location field in favour of the built in GeoIP processor on 1Password Events Reporting integration package.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Author's Checklist

  • I have added the new processor rule to the item usages and sign in attempts elasticsearch ingest pipeline
  • I have updated the tests to match the addition

Related

#2367

1Password Events API Reference

Screenshots

@anthonythleung anthonythleung requested a review from a team as a code owner March 7, 2022 15:46
@elasticmachine
Copy link

elasticmachine commented Mar 7, 2022

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview [preview](https://ci-stats.elastic.co/app/apm/services/beats-ci/transactions/view?rangeFrom=2022-03-07T16:56:42.371Z&rangeTo=2022-03-07T17:16:42.371Z&transactionName=BUILD Ingest-manager/integrations/PR-{number}&transactionType=job&latencyAggregationType=avg&traceId=db918342264c5b22ca32cc3e18bdef3c&transactionId=2fbff5c3dc9ce2d2)

Expand to view the summary

Build stats

  • Start Time: 2022-03-07T17:06:42.371+0000

  • Duration: 13 min 7 sec

Test stats 🧪

Test Results
Failed 0
Passed 25
Skipped 0
Total 25

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@andrewkroh
Copy link
Member

/test

@andrewkroh andrewkroh added enhancement New feature or request Integration:1password 1Password (Partner supported) Team:Security-External Integrations labels Mar 7, 2022
@elasticmachine
Copy link

Pinging @elastic/security-external-integrations (Team:Security-External Integrations)

@andrewkroh
Copy link
Member

There was a CI failure for:

[2022-03-07T16:17:58.186Z] README.md is outdated. Rebuild the package with 'elastic-package build'
[2022-03-07T16:17:58.186Z] Error: checking package failed: checking readme files are up-to-date failed: checking readme files are up-to-date failed

@P1llus
Copy link
Member

P1llus commented Mar 7, 2022

/test

@P1llus
Copy link
Member

P1llus commented Mar 8, 2022

Much appreciated @anthonythleung!

I will merge this a bit later, and the new version should appear for users a bit after that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request Integration:1password 1Password (Partner supported)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants