Skip to content

[1password] Add new event.action to 1Password item usages#2367

Closed
ogero wants to merge 4 commits intoelastic:mainfrom
1Password:1password_itemusage_action
Closed

[1password] Add new event.action to 1Password item usages#2367
ogero wants to merge 4 commits intoelastic:mainfrom
1Password:1password_itemusage_action

Conversation

@ogero
Copy link
Contributor

@ogero ogero commented Dec 22, 2021

What does this PR do?

This PR adds the event.action field to Item Usages stream on 1Password Events Reporting integration package.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Author's Checklist

  • I have added the new processor rule to the item usages elasticsearch ingest pipeline
  • I have updated the tests to match the addition

Related

Screenshots

item_usages_event_action

@elasticmachine
Copy link

elasticmachine commented Dec 22, 2021

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2022-02-17T16:29:22.655+0000

  • Duration: 22 min 56 sec

Test stats 🧪

Test Results
Failed 0
Passed 25
Skipped 0
Total 25

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@ogero ogero changed the title Add new event.action to 1Password item usages [1password] Add new event.action to 1Password item usages Dec 23, 2021
@ogero
Copy link
Contributor Author

ogero commented Dec 23, 2021

Hey @P1llus, can you please take a look at this small changes? ty!

@P1llus
Copy link
Member

P1llus commented Dec 29, 2021

/test

@elasticmachine
Copy link

Pinging @elastic/security-external-integrations (Team:Security-External Integrations)

@r00tu53r r00tu53r self-assigned this Jan 31, 2022
@r00tu53r
Copy link
Contributor

r00tu53r commented Jan 31, 2022

@ogero I've resolved the conflicts locally. However I don't think I have permission to push to this remote branch. Alternatively the changes are available here

@andrewkroh
Copy link
Member

@r00tu53r You should be able to push you change to this PR with

git push git://github.com/1Password/elastic-integrations.git 1password_itemusage_action:1password_itemusage_action

@ogero
Copy link
Contributor Author

ogero commented Feb 6, 2022

Hi @r00tu53r, I no longer work at 1Password and, unfortunately, cannot address the branch conflicts. @hilaryhacksel may be able to help here :)

@cla-checker-service
Copy link

❌ Author of the following commits did not sign a Contributor Agreement:
9e8b477, bf4c00c, a1f55b9,

Please, read and sign the above mentioned agreement if you want to contribute to this project

@P1llus
Copy link
Member

P1llus commented Feb 21, 2022

@hilaryhacksel are you able to sign the CLA as well, so I can merge the PR?

@r00tu53r
Copy link
Contributor

r00tu53r commented Mar 1, 2022

@r00tu53r You should be able to push you change to this PR with

git push git://github.com/1Password/elastic-integrations.git 1password_itemusage_action:1password_itemusage_action

@andrewkroh I don't seem to have permissions.

~/go/src/github.com/r00tu53r/integrations/packages/1password (1password_itemusage_action)$ git push -u 1password 1password_itemusage_action:1password_itemusage_action
ERROR: Permission to 1Password/elastic-integrations.git denied to r00tu53r. 
fatal: Could not read from remote repository.

Please make sure you have the correct access rights and the repository exists.

@hilaryhacksel
Copy link

hilaryhacksel commented Mar 1, 2022

@P1llus I signed the CLA. How do you suggest moving forward? Amending or squashing the commits the cla-checker-service shared with my (or @anthonythleung's) identification? My only concern with that approach would be losing the approval with introduction of new commit hashes.

@andrewkroh
Copy link
Member

@r00tu53r I think I formatted the git URL incorrectly for you. I recommend using the gh CLI tool to checkout the PR. It sets everything up for you.

@r00tu53r
Copy link
Contributor

r00tu53r commented Mar 7, 2022

@r00tu53r I think I formatted the git URL incorrectly for you. I recommend using the gh CLI tool to checkout the PR. It sets everything up for you.

@andrewkroh I've tried that too. gh pr checkout 1Password:1password_itemusage_action and git push with the same outcome.

@r00tu53r
Copy link
Contributor

r00tu53r commented Mar 7, 2022

@hilaryhacksel The up-to-date changes (post resolving conflicts) can be found here https://github.com/r00tu53r/integrations/tree/1password_itemusage_action

@P1llus
Copy link
Member

P1llus commented Mar 7, 2022

I don't believe there is permissions to push changes, if okay I think it might be much quicker to apply the changes to a new PR and merge it @r00tu53r @andrewkroh ?
Seeing that the PR has been open for a while.

@anthonythleung
Copy link
Contributor

Hey everyone! Apologies for not getting back to this sooner. I'm not 100% sure how to resolve Gero's CLA issue, so I've opened a new PR with some additional API changes fixes and fixed the merge conflicts here: #2775. I don't think I have permission to close this PR though.

@andrewkroh andrewkroh closed this Mar 7, 2022
@andrewkroh andrewkroh added the Integration:1password 1Password (Partner supported) label Mar 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Integration:1password 1Password (Partner supported)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants