[1password] Add new event.action to 1Password item usages#2367
[1password] Add new event.action to 1Password item usages#2367ogero wants to merge 4 commits intoelastic:mainfrom
Conversation
|
Hey @P1llus, can you please take a look at this small changes? ty! |
|
/test |
|
Pinging @elastic/security-external-integrations (Team:Security-External Integrations) |
|
@r00tu53r You should be able to push you change to this PR with |
|
Hi @r00tu53r, I no longer work at 1Password and, unfortunately, cannot address the branch conflicts. @hilaryhacksel may be able to help here :) |
|
❌ Author of the following commits did not sign a Contributor Agreement: Please, read and sign the above mentioned agreement if you want to contribute to this project |
|
@hilaryhacksel are you able to sign the CLA as well, so I can merge the PR? |
@andrewkroh I don't seem to have permissions. |
|
@P1llus I signed the CLA. How do you suggest moving forward? Amending or squashing the commits the cla-checker-service shared with my (or @anthonythleung's) identification? My only concern with that approach would be losing the approval with introduction of new commit hashes. |
@andrewkroh I've tried that too. |
|
@hilaryhacksel The up-to-date changes (post resolving conflicts) can be found here https://github.com/r00tu53r/integrations/tree/1password_itemusage_action |
|
I don't believe there is permissions to push changes, if okay I think it might be much quicker to apply the changes to a new PR and merge it @r00tu53r @andrewkroh ? |
|
Hey everyone! Apologies for not getting back to this sooner. I'm not 100% sure how to resolve Gero's CLA issue, so I've opened a new PR with some additional API changes fixes and fixed the merge conflicts here: #2775. I don't think I have permission to close this PR though. |
What does this PR do?
This PR adds the
event.actionfield to Item Usages stream on 1Password Events Reporting integration package.Checklist
changelog.ymlfile.Author's Checklist
Related
Screenshots