Skip to content

[Qualys VMDR] Fix duplicate fields in transform #16903

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
moxarth-rathod merged 1 commit into from
Jan 20, 2026
Merged

[Qualys VMDR] Fix duplicate fields in transform #16903

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 0 additions & 4 deletions packages/qualys_vmdr/elasticsearch/transform/latest_cdr_vulnerabilities/fields/fields.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -139,8 +139,6 @@
type: keyword
- name: severity
type: long
- name: source
type: keyword
Comment on lines -142 to -143
Copy link
Collaborator

@mrodm mrodm Jan 8, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just in case, this field was not reported as duplicated in https://buildkite.com/elastic/integrations/builds/36182#019b9848-4c98-49a8-8af1-fac140f6e491/L479

Copy link
Contributor Author

@moxarth-rathod moxarth-rathod Jan 9, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This field is currently not supported. To avoid any potential confusion or unexpected behaviour, it would be good to remove it from the field definition.

Copy link
Contributor

@kcreddy kcreddy Jan 9, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you elaborate on why we are removing this field? It seems to be present even in the DTD of new API: #16640 (comment)
Any field removal even if unsupported by the API should be a breaking-change.

Copy link
Contributor Author

@moxarth-rathod moxarth-rathod Jan 12, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pipeline currently does not parse this field. I initially planned to add it to the pipeline, but later removed it from the changes. However, I forgot to remove the field from the transform, so I now want to remove it for the time being.

Copy link
Contributor

@kcreddy kcreddy Jan 16, 2026 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@moxarth-rathod, can you please add this context to the commit message?

Copy link
Contributor Author

@moxarth-rathod moxarth-rathod Jan 19, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kcreddy done, updated.

Copy link
Contributor

@kcreddy kcreddy Jan 19, 2026 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@moxarth-rathod, suggested commit:

qualys_vmdr: remove duplicate fields in transform as per the comment [1] in this PR [2]. 

Also, remove unsupported field `source` from the fields definition. The pipeline currently does not 
parse this field. This was incorrectly added into the transform fields inside the PR [2].

- [1] https://github.com/elastic/integrations/pull/16727#issuecomment-3719541508
- [2] https://github.com/elastic/integrations/pull/16727

Copy link
Contributor Author

@moxarth-rathod moxarth-rathod Jan 20, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

- name: ssl
type: keyword
- name: status
Expand All @@ -153,8 +151,6 @@
type: keyword
- name: type
type: keyword
- name: trurisk_elimination_status
type: keyword
- name: unique_vuln_id
type: keyword
- name: vulnerability_detection_sources
Expand Down