-
Notifications
You must be signed in to change notification settings - Fork 525
[Qualys VMDR] Fix duplicate fields in transform #16903
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
Pinging @elastic/security-service-integrations (Team:Security-Service Integrations) |
| - name: source | ||
| type: keyword |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just in case, this field was not reported as duplicated in https://buildkite.com/elastic/integrations/builds/36182#019b9848-4c98-49a8-8af1-fac140f6e491/L479
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This field is currently not supported. To avoid any potential confusion or unexpected behaviour, it would be good to remove it from the field definition.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you elaborate on why we are removing this field? It seems to be present even in the DTD of new API: #16640 (comment)
Any field removal even if unsupported by the API should be a breaking-change.
🚀 Benchmarks reportTo see the full report comment with |
💚 Build Succeeded
|
Proposed commit message
Checklist
changelog.ymlfile.Related issues