Skip to content

apm: Add integration policy variable tail_sampling_ttl to configure apm-server.sampling.tail.ttl#13348

Merged
carsonip merged 6 commits intoelastic:mainfrom
carsonip:apm-tbs-ttl
May 21, 2025
Merged

apm: Add integration policy variable tail_sampling_ttl to configure apm-server.sampling.tail.ttl#13348
carsonip merged 6 commits intoelastic:mainfrom
carsonip:apm-tbs-ttl

Conversation

@carsonip
Copy link
Member

@carsonip carsonip commented Mar 28, 2025 •
edited
Loading

Proposed commit message

apm: Add policy variable tail_sampling_ttl to configure apm-server.sampling.tail.ttl.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.
  • I have verified that any added dashboard complies with Kibana's Dashboard good practices

Author's Checklist

  • [ ]

How to test this PR locally

Build the integration, run on EA and check EA diagnostics for computed config.

Related issues

Screenshots

@carsonip carsonip changed the title apm: Add config for tail-based sampling TTL apm: Add integration policy variable tail_sampling_ttl to configure apm-server.sampling.tail.ttl Mar 28, 2025
carsonip
carsonip commented Mar 28, 2025
View reviewed changes
@andrewkroh andrewkroh added the Integration:apm Elastic APM label Mar 28, 2025
@carsonip
Copy link
Member Author

carsonip commented Apr 8, 2025

Tested with elastic-package and EA, confirmed that in the computed config ttl is present with default value

        sampling:
            tail:
                enabled: true
                interval: 1m
                policies:
                    - sample_rate: 0.1
                storage_limit: 0GB
                ttl: 30m
        shutdown_timeout: 30s
        ssl:

@carsonip carsonip mentioned this pull request Apr 25, 2025
Closed
@carsonip carsonip marked this pull request as ready for review May 8, 2025 14:24
@carsonip carsonip requested a review from a team as a code owner May 8, 2025 14:24
@isaacaflores2 isaacaflores2 mentioned this pull request May 20, 2025
Merged
6 tasks
@elasticmachine
Copy link

elasticmachine commented May 21, 2025

💚 Build Succeeded

History

@elastic-sonarqube
Copy link

elastic-sonarqube bot commented May 21, 2025

Quality Gate passed Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube

@carsonip carsonip merged commit 4fbacb5 into elastic:main May 21, 2025
8 checks passed
@carsonip carsonip mentioned this pull request May 28, 2025
Merged
5 tasks
carsonip added a commit that referenced this pull request May 28, 2025
@carsonip
apm: Backport TBS ttl and discard_on_write_failure to 8.19 (#14029)
8391a17 
Backport 2 PRs from 9.1 to 8.19:
- TBS ttl config #13348
- TBS discard_write_on_failure config #13950
anupratharamachandran pushed a commit to anupratharamachandran/integrations that referenced this pull request Jun 2, 2025
@carsonip @anupratharamachandran
apm: Add integration policy variable tail_sampling_ttl to configure…
ad2d1bd 
… `apm-server.sampling.tail.ttl` (elastic#13348)

apm: Add policy variable tail_sampling_ttl to configure apm-server.sampling.tail.ttl. Use `^9.1.0` kibana version constraint to prevent apm integration from being bundled in a new 9.0 patch version.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@marclop marclop marclop approved these changes

+1 more reviewer

@rubvs rubvs rubvs approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

Integration:apm Elastic APM

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@carsonip @elasticmachine @marclop @rubvs @andrewkroh