This repository was archived by the owner on May 16, 2023. It is now read-only.
[metricbeat] support deployment/daemonset specific metrics#820
Merged
jmlrt merged 2 commits intoelastic:masterfrom Oct 2, 2020
Merged
[metricbeat] support deployment/daemonset specific metrics#820jmlrt merged 2 commits intoelastic:masterfrom
jmlrt merged 2 commits intoelastic:masterfrom
Conversation
Collaborator
|
Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually? |
|
💚 CLA has been signed |
Contributor
Author
|
After posting the comment, the check was re-evaluated automatically 🤷 |
Member
|
jenkins test this please |
jmlrt
previously approved these changes
Oct 2, 2020
Member
jmlrt
left a comment
jmlrt
left a comment
There was a problem hiding this comment.
LGTM, just a nit on test naming
|
|
||
|
|
||
| def test_adding_pod_labels(): | ||
| def test_adding_legacy_labels(): |
Member
There was a problem hiding this comment.
I would prefer naming this test test_adding_deprecated_labels to be more consistent with the other related test names.
Member
|
jenkins test this please |
jmlrt
pushed a commit
that referenced
this pull request
Oct 2, 2020
* [metricbeat] support deployment/daemonset specific metrics * chore: rename test_adding_legacy_labels to test_adding_deprecated_labels
jmlrt
pushed a commit
that referenced
this pull request
Oct 2, 2020
* [metricbeat] support deployment/daemonset specific metrics * chore: rename test_adding_legacy_labels to test_adding_deprecated_labels
jmlrt
pushed a commit
that referenced
this pull request
Oct 2, 2020
* [metricbeat] support deployment/daemonset specific metrics * chore: rename test_adding_legacy_labels to test_adding_deprecated_labels
Member
|
backported to |
Closed
This was referenced Oct 21, 2020
Closed
Merged
Closed
This was referenced Nov 17, 2020
Closed
Closed
Closed
Closed
Closed
Closed
Closed
This was referenced Dec 14, 2021
Merged
Merged
Merged
This was referenced Sep 14, 2022
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
${CHART}/tests/*.py${CHART}/examples/*/test/goss.yamlCloses #812
Turned out, initially labeling was completely implemented for DaemonSet (both daemon-set and pod labels), but only partially for Deployment (only pod-level labels). I decided to make these properties to be consistent for both object types, while still keeping to the design we agreed in the linked issue