This repository was archived by the owner on May 16, 2023. It is now read-only.
[Metricbeat] Dont generate config if not enabled#767
Merged
jmlrt merged 1 commit intoelastic:masterfrom Oct 20, 2020
ebuildy:patch-2
Merged
[Metricbeat] Dont generate config if not enabled#767jmlrt merged 1 commit intoelastic:masterfrom ebuildy:patch-2
jmlrt merged 1 commit intoelastic:masterfrom
ebuildy:patch-2
Conversation
Collaborator
|
Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually? |
Member
|
cla/check |
Member
|
jenkins test this please |
jmlrt
reviewed
Sep 23, 2020
Member
jmlrt
left a comment
There was a problem hiding this comment.
Hi @ebuildy, thanks for this PR.
Do you think you could update the following tests to ensure that the config map aren't generated when one daemonset or deployment isn't enabled:
helm-charts/metricbeat/tests/metricbeat_test.py
Lines 1177 to 1194 in dd4241b
If for daemonset/deployment is not enabled, dont generate useless config YAML. [metricbeat] Add tests
Member
|
jenkins test this please |
jmlrt
pushed a commit
that referenced
this pull request
Oct 20, 2020
If for daemonset/deployment is not enabled, dont generate useless config YAML.
jmlrt
pushed a commit
that referenced
this pull request
Oct 20, 2020
If for daemonset/deployment is not enabled, dont generate useless config YAML.
jmlrt
pushed a commit
that referenced
this pull request
Oct 20, 2020
If for daemonset/deployment is not enabled, dont generate useless config YAML.
Member
|
backported to |
This was referenced Oct 21, 2020
Closed
Merged
Closed
This was referenced Nov 17, 2020
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
This was referenced Dec 14, 2021
Merged
Merged
Merged
This was referenced Sep 14, 2022
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If for daemonset/deployment is not enabled, dont generate useless config YAML.
${CHART}/tests/*.py${CHART}/examples/*/test/goss.yaml