Skip to content
This repository was archived by the owner on May 16, 2023. It is now read-only.

Fix typo in FAQ#744

Merged
jmlrt merged 2 commits intoelastic:masterfrom
SlavaSubotskiy:patch-1
Aug 27, 2020
Merged

Fix typo in FAQ#744
jmlrt merged 2 commits intoelastic:masterfrom
SlavaSubotskiy:patch-1

Conversation

@SlavaSubotskiy
Copy link
Copy Markdown
Contributor

@SlavaSubotskiy SlavaSubotskiy commented Jul 23, 2020

  • Chart version not bumped (the versions are all bumped and released at the same time)
  • README.md updated with any new values or changes
  • Updated template tests in ${CHART}/tests/*.py
  • Updated integration tests in ${CHART}/examples/*/test/goss.yaml

@elasticmachine
Copy link
Copy Markdown
Collaborator

elasticmachine commented Jul 23, 2020

Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually?

1 similar comment
@elasticmachine
Copy link
Copy Markdown
Collaborator

elasticmachine commented Jul 23, 2020

Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually?

@cla-checker-service
Copy link
Copy Markdown

cla-checker-service Bot commented Jul 23, 2020 •
edited
Loading

💚 CLA has been signed

@SlavaSubotskiy SlavaSubotskiy marked this pull request as draft July 23, 2020 13:53
@SlavaSubotskiy SlavaSubotskiy marked this pull request as ready for review July 23, 2020 13:53
@jmlrt
Copy link
Copy Markdown
Member

jmlrt commented Jul 27, 2020

cla/check

jmlrt
jmlrt reviewed Jul 27, 2020
View reviewed changes
Copy link
Copy Markdown
Member

@jmlrt jmlrt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @SlavaSubotskiy,
This is not valid, the value to use is daemonset.hostNetworking, while using hostNetworking value has no effect.

@jmlrt jmlrt closed this Jul 27, 2020
@SlavaSubotskiy
Copy link
Copy Markdown
Contributor Author

SlavaSubotskiy commented Aug 2, 2020

Dear @jmlrt, thank you for review!
Your comment is valid for 'metricbeat', but the proposed fix is for 'filebeat' chart.
In the case of 'filebeat' chart '.Values.hostNetworking' is used: https://github.com/elastic/helm-charts/blob/master/filebeat/templates/daemonset.yaml#L55

SlavaSubotskiy
SlavaSubotskiy commented Aug 4, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor Author

@SlavaSubotskiy SlavaSubotskiy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the case of 'filebeat' chart '.Values.hostNetworking' is used: https://github.com/elastic/helm-charts/blob/master/filebeat/templates/daemonset.yaml#L55

@jmlrt
Copy link
Copy Markdown
Member

jmlrt commented Aug 26, 2020

Ooops, sorry for my mistake... Reopenning

@jmlrt jmlrt reopened this Aug 26, 2020
jmlrt
jmlrt approved these changes Aug 26, 2020
View reviewed changes
Copy link
Copy Markdown
Member

@jmlrt jmlrt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM⛴

@jmlrt
Copy link
Copy Markdown
Member

jmlrt commented Aug 26, 2020

jenkins test this please

@jmlrt
Copy link
Copy Markdown
Member

jmlrt commented Aug 26, 2020

jenkins test this please

@jmlrt jmlrt merged commit b5a1a56 into elastic:master Aug 27, 2020
jmlrt added a commit that referenced this pull request Aug 27, 2020
@SlavaSubotskiy @jmlrt
Fix typo in FAQ (#744)
2cfd4ee 
Co-authored-by: Julien Mailleret <8582351+jmlrt@users.noreply.github.com>
jmlrt added a commit that referenced this pull request Aug 27, 2020
@SlavaSubotskiy @jmlrt
Fix typo in FAQ (#744)
901700e 
Co-authored-by: Julien Mailleret <8582351+jmlrt@users.noreply.github.com>
jmlrt added a commit that referenced this pull request Aug 27, 2020
@SlavaSubotskiy @jmlrt
Fix typo in FAQ (#744)
6d68ec5 
Co-authored-by: Julien Mailleret <8582351+jmlrt@users.noreply.github.com>
@jmlrt
Copy link
Copy Markdown
Member

jmlrt commented Aug 27, 2020

backported to 6.8, 7.9 and 7.x branches

@elasticmachine elasticmachine mentioned this pull request Oct 21, 2020
Merged
@jmlrt jmlrt mentioned this pull request Oct 28, 2020
Closed
This was referenced Nov 17, 2020
Closed
Closed
This was referenced Nov 17, 2020
Closed
Closed
@elasticmachine elasticmachine mentioned this pull request Nov 20, 2020
Closed
@jmlrt jmlrt mentioned this pull request Nov 23, 2020
Closed
@elasticmachine elasticmachine mentioned this pull request Nov 23, 2020
Merged
@jmlrt jmlrt mentioned this pull request Feb 8, 2021
Closed
This was referenced Mar 15, 2021
Closed
Closed
@jmlrt jmlrt mentioned this pull request May 25, 2021
Closed
This was referenced Dec 14, 2021
Merged
Merged
Merged
@jmlrt jmlrt mentioned this pull request Mar 8, 2022
Merged
@jmlrt jmlrt mentioned this pull request Apr 21, 2022
Merged
This was referenced Sep 14, 2022
Merged
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@jmlrt jmlrt jmlrt approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

docs filebeat v6.8.13 v7.9.1

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@SlavaSubotskiy @elasticmachine @jmlrt