This repository was archived by the owner on May 16, 2023. It is now read-only.
Include pre-releases in the semver range.#729
Merged
jmlrt merged 1 commit intoelastic:masterfrom Sep 16, 2020
floretan:bugfix/semverCompare-range
Merged
Include pre-releases in the semver range.#729jmlrt merged 1 commit intoelastic:masterfrom floretan:bugfix/semverCompare-range
jmlrt merged 1 commit intoelastic:masterfrom
floretan:bugfix/semverCompare-range
Conversation
Collaborator
|
Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually? |
Member
|
jenkins test this please |
jmlrt
pushed a commit
that referenced
this pull request
Sep 16, 2020
jmlrt
pushed a commit
that referenced
this pull request
Sep 16, 2020
jmlrt
pushed a commit
that referenced
this pull request
Sep 16, 2020
Member
|
backported to |
Merged
Closed
Closed
This was referenced Nov 17, 2020
Closed
Closed
Closed
Closed
Closed
Closed
Closed
This was referenced Dec 14, 2021
Merged
Merged
Merged
This was referenced Sep 14, 2022
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
${CHART}/tests/*.py${CHART}/examples/*/test/goss.yamlThe new parameter
enableServiceLinksadded in #542 is only rendered with kubernetes >1.13. However the notation for the parameter tosemverComparerequires a-0suffix to also take into account versions likev1.15.12-gke.6.12. Because of that, theenableServiceLinksparameter currently nothing on GKE.Note that the
helm templateandhelm installwill generate different values for.Capabilities.KubeVersion.GitVersion, something I was previously not aware of.