Skip to content
This repository was archived by the owner on May 16, 2023. It is now read-only.

Support networking.k8s.io/v1 ingress for k8s v1.22+#1312

Closed
mkhpalm wants to merge 4 commits intoelastic:masterfrom
mkhpalm:master
Closed

Support networking.k8s.io/v1 ingress for k8s v1.22+#1312
mkhpalm wants to merge 4 commits intoelastic:masterfrom
mkhpalm:master

Conversation

@mkhpalm
Copy link
Copy Markdown

@mkhpalm mkhpalm commented Jul 30, 2021

Changes to ingress template to support k8s v1.22+ due to depreciation of networking.k8s.io/v1beta1.

Following the updated boilerplate template structure from helm to keep things consistent

@elasticmachine
Copy link
Copy Markdown
Collaborator

Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually?

@cla-checker-service
Copy link
Copy Markdown

cla-checker-service Bot commented Jul 30, 2021

💚 CLA has been signed

@maybe-sybr
Copy link
Copy Markdown

maybe-sybr commented Aug 3, 2021

@mkhpalm There are also ingress YAML docs for (at least) kibana and logstash. Check out #1233 which was a less portable version of your change, but which did touch those documents as well. I'd really like to see one of these land.

@mkhpalm
Copy link
Copy Markdown
Author

mkhpalm commented Aug 3, 2021

I've updated the templates for both logstash and kibana in addition to elasticsearch

@bender316
Copy link
Copy Markdown

I solved it for the jaeger helm charts with .Capabilities.APIVersions.Has:
jaegertracing/helm-charts#275

I think the structure is a bit clearer there and better readable in the future.

@mkhpalm mkhpalm closed this Aug 7, 2021
@mkhpalm mkhpalm reopened this Aug 7, 2021
@ckotzbauer
Copy link
Copy Markdown
Contributor

Is there any ETA when this is merged? Currently Kibana cannot be installed on Kubernetes 1.22 without changes to the apiserver.

@mpepping
Copy link
Copy Markdown

+1 Kubernetes releases are pushing to a point in time that this needs to be merged :)

@framsouza
Copy link
Copy Markdown
Contributor

Closing this PR as we are currently working here #1409

@framsouza framsouza closed this Oct 12, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants