Update apiVersion to networking.k8s.io/v1 on ingress resources#1233
Update apiVersion to networking.k8s.io/v1 on ingress resources#1233javipolo wants to merge 2 commits intoelastic:mainfrom
Conversation
|
Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually? |
|
💚 CLA has been signed |
e1f45d2 to
8dff53c
Compare
|
Hey 👋, I think we need also to update |
|
You're right @tomislater , I totally forgot about this change!! Just pushed the changes ... I think now it's all right |
| http: | ||
| paths: | ||
| - path: {{ $ingressPath }} | ||
| pathType: ImplementationSpecific |
There was a problem hiding this comment.
RE pathType ... These should probably be configurable, imo.
|
jenkins test this please |
|
Hi! Do we have any update on this one? Thanks |
|
Haven't tested it in a while but nobody but I could reproduce it. I guess
that means I'm an oddity.
…On Mon, Sep 20, 2021, 5:55 PM Aaron Pejakovic ***@***.***> wrote:
Hi!
Do we have any update on this one?
Thanks
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#1233 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ACPXEZR3RN6Y6OUSC7VOEIDUC6UUXANCNFSM452XAHYQ>
.
Triage notifications on the go with GitHub Mobile for iOS
<https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675>
or Android
<https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.
|
Ahhh right okay, because we are about to do a kubernetes upgrade to 1.22 soon and I guess these need to be merged for elastic to work on 1.22 right? |
Updates deprecated apiVersion in k8s 1.19
fixes #1136