Skip to content
This repository was archived by the owner on May 16, 2023. It is now read-only.

Update apiVersion to networking.k8s.io/v1 on ingress resources#1233

Closed
javipolo wants to merge 2 commits intoelastic:mainfrom
javipolo:deprecatedIngressApiVersions
Closed

Update apiVersion to networking.k8s.io/v1 on ingress resources#1233
javipolo wants to merge 2 commits intoelastic:mainfrom
javipolo:deprecatedIngressApiVersions

Conversation

@javipolo
Copy link
Copy Markdown

Updates deprecated apiVersion in k8s 1.19

fixes #1136

@elasticmachine
Copy link
Copy Markdown
Collaborator

Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually?

@cla-checker-service
Copy link
Copy Markdown

cla-checker-service Bot commented May 31, 2021

💚 CLA has been signed

@javipolo javipolo force-pushed the deprecatedIngressApiVersions branch from e1f45d2 to 8dff53c Compare May 31, 2021 13:26
@tomislater
Copy link
Copy Markdown

tomislater commented Jun 15, 2021

Hey 👋, I think we need also to update rules section. It should look something like that now:

- host: "foo.bar.com"
  http:
    paths:
    - pathType: ImplementationSpecific
      path: "/bar"
      backend:
        service:
          name: service1
          port:
            number: 80

https://github.com/kubernetes/kubernetes/blob/master/CHANGELOG/CHANGELOG-1.19.md#api-change-4

@javipolo
Copy link
Copy Markdown
Author

You're right @tomislater , I totally forgot about this change!!

Just pushed the changes ... I think now it's all right

http:
paths:
- path: {{ $ingressPath }}
pathType: ImplementationSpecific
Copy link
Copy Markdown

@flockoftanks flockoftanks Jun 17, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RE pathType ... These should probably be configurable, imo.

@jmlrt
Copy link
Copy Markdown
Member

jmlrt commented Jun 23, 2021

jenkins test this please

@pjaak
Copy link
Copy Markdown

pjaak commented Sep 20, 2021

Hi!

Do we have any update on this one?

Thanks

@flockoftanks
Copy link
Copy Markdown

flockoftanks commented Sep 20, 2021 via email

@pjaak
Copy link
Copy Markdown

pjaak commented Sep 20, 2021

Haven't tested it in a while but nobody but I could reproduce it. I guess that means I'm an oddity.

On Mon, Sep 20, 2021, 5:55 PM Aaron Pejakovic @.***> wrote: Hi! Do we have any update on this one? Thanks — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#1233 (comment)>, or unsubscribe https://github.com/notifications/unsubscribe-auth/ACPXEZR3RN6Y6OUSC7VOEIDUC6UUXANCNFSM452XAHYQ . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

Ahhh right okay, because we are about to do a kubernetes upgrade to 1.22 soon and I guess these need to be merged for elastic to work on 1.22 right?

@jmlrt
Copy link
Copy Markdown
Member

jmlrt commented Oct 14, 2021

Hi @javipolo, sorry we didn't reviewed before. This has been implemented in #1409. Closing

@jmlrt jmlrt closed this Oct 14, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ingress networking.k8s.io/v1beta1 is deprecated

6 participants