Bump Go version to 1.25.1 by ycombinator · Pull Request #5562 · elastic/fleet-server

ycombinator · 2025-09-25T17:07:05Z

This PR bumps up the Golang version to 1.25.1. It also:

removes the ms_tls13kdf Golang build tag when building in FIPS mode because this tag was only needed with Golang versions 1.24.x.
sets ths GODEBUG=tlsmlkem=0 environment variable when running FIPS140-only unit tests. This prevents errors like so: Failed to connect: crypto/ecdh: use of X25519 is not allowed in FIPS 140-only mode.

mergify · 2025-09-25T17:07:43Z

This pull request does not have a backport label. Could you fix it @ycombinator? 🙏
To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

backport-./d./d is the label to automatically backport to the 8./d branch. /d is the digit
backport-active-all is the label that automatically backports to all active branches.
backport-active-8 is the label that automatically backports to all active minor branches for the 8 major.
backport-active-9 is the label that automatically backports to all active minor branches for the 9 major.

prodsecmachine · 2025-09-25T17:08:24Z

🎉 Snyk checks have passed. No issues have been found so far.

✅ security/snyk check is complete. No issues have been found. (View Details)

✅ license/snyk check is complete. No issues have been found. (View Details)

michel-laterman

lgtm

github-actions · 2025-09-25T21:27:53Z

🔍 Preview links for changed docs

docs/fips.md

ycombinator · 2025-09-26T05:26:27Z

The fips140=only unit tests are failing like so:
crypto/ecdh: use of X25519 is not allowed in FIPS 140-only mode
These appear to be golang/go#75148, which should be fixable when golang/go#74630 is implemented. However, in order to upgrade to Go 1.25.1 now, we'll need to find a workaround.

These errors are coming from Go downloading dependencies before executing the tests. The errors can be simulated like so:

GODEBUG=fips140=only go mod download -x
# get https://proxy.golang.org/github.com/opencontainers/image-spec/@v/v1.1.1.info
# get https://proxy.golang.org/github.com/opencontainers/image-spec/@v/v1.1.1.info: Get "https://proxy.golang.org/github.com/opencontainers/image-spec/@v/v1.1.1.info": crypto/ecdh: use of X25519 is not allowed in FIPS 140-only mode
...

I ran into the same problem in elastic/elastic-agent#10156 and I had success with explicitly downloading the dependencies before executing the tests. I'm running into a different problem on that PR now; once it's sorted out, I will apply the same approach on this PR here. Moving this PR into draft until then.

elastic-sonarqube · 2025-09-29T21:37:28Z

Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarQube

github-actions · 2025-10-01T13:46:02Z

@Mergifyio backport 8.18 8.19 9.0 9.1 9.2

mergify · 2025-10-01T13:46:14Z

backport 8.18 8.19 9.0 9.1 9.2

❌ No backport have been created

Details

#5581 [8.18](backport #5562) Bump Go version to 1.25.1 has been created for branch 8.18 but encountered conflicts
#5582 [8.19](backport #5562) Bump Go version to 1.25.1 has been created for branch 8.19 but encountered conflicts
#5583 [9.0](backport #5562) Bump Go version to 1.25.1 has been created for branch 9.0 but encountered conflicts
#5584 [9.1](backport #5562) Bump Go version to 1.25.1 has been created for branch 9.1
Backport to branch 9.2 failed

GitHub error: Branch not found

* Bump Go version to 1.25.1 * Update CHANGELOG entry * Bump the version of golangci-lint * Remove references to the ms_tls13kdf build tag * Download go module dependencies before GODEBUG=fips140=only is set * Exclude X25519 curve types when testing in FIPS-140 mode * Stricter check * Add missing license header * Exclude X25519 curve types when testing in FIPS-140-only mode * Use stricter check * Update NOTICE files * Remove IsFIPS140Only helper function * Set GODEBUG=tlsmlkem=0 for FIPS140-only unit tests * Remove replace directive from go.mod * Try not pre-downloading dependencies (cherry picked from commit 15b8c8a) # Conflicts: # .github/workflows/golangci-lint.yml # docs/fips.md # magefile.go

* Bump Go version to 1.25.1 * Update CHANGELOG entry * Bump the version of golangci-lint * Remove references to the ms_tls13kdf build tag * Download go module dependencies before GODEBUG=fips140=only is set * Exclude X25519 curve types when testing in FIPS-140 mode * Stricter check * Add missing license header * Exclude X25519 curve types when testing in FIPS-140-only mode * Use stricter check * Update NOTICE files * Remove IsFIPS140Only helper function * Set GODEBUG=tlsmlkem=0 for FIPS140-only unit tests * Remove replace directive from go.mod * Try not pre-downloading dependencies (cherry picked from commit 15b8c8a) # Conflicts: # .github/workflows/golangci-lint.yml

* Bump Go version to 1.25.1 * Update CHANGELOG entry * Bump the version of golangci-lint * Remove references to the ms_tls13kdf build tag * Download go module dependencies before GODEBUG=fips140=only is set * Exclude X25519 curve types when testing in FIPS-140 mode * Stricter check * Add missing license header * Exclude X25519 curve types when testing in FIPS-140-only mode * Use stricter check * Update NOTICE files * Remove IsFIPS140Only helper function * Set GODEBUG=tlsmlkem=0 for FIPS140-only unit tests * Remove replace directive from go.mod * Try not pre-downloading dependencies (cherry picked from commit 15b8c8a) # Conflicts: # .github/workflows/golangci-lint.yml # docs/fips.md # magefile.go

* Bump Go version to 1.25.1 * Update CHANGELOG entry * Bump the version of golangci-lint * Remove references to the ms_tls13kdf build tag * Download go module dependencies before GODEBUG=fips140=only is set * Exclude X25519 curve types when testing in FIPS-140 mode * Stricter check * Add missing license header * Exclude X25519 curve types when testing in FIPS-140-only mode * Use stricter check * Update NOTICE files * Remove IsFIPS140Only helper function * Set GODEBUG=tlsmlkem=0 for FIPS140-only unit tests * Remove replace directive from go.mod * Try not pre-downloading dependencies (cherry picked from commit 15b8c8a)

* Bump Go version to 1.25.1 * Update CHANGELOG entry * Bump the version of golangci-lint * Remove references to the ms_tls13kdf build tag * Download go module dependencies before GODEBUG=fips140=only is set * Exclude X25519 curve types when testing in FIPS-140 mode * Stricter check * Add missing license header * Exclude X25519 curve types when testing in FIPS-140-only mode * Use stricter check * Update NOTICE files * Remove IsFIPS140Only helper function * Set GODEBUG=tlsmlkem=0 for FIPS140-only unit tests * Remove replace directive from go.mod * Try not pre-downloading dependencies (cherry picked from commit 15b8c8a) Co-authored-by: Shaunak Kashyap <ycombinator@gmail.com>

ycombinator · 2025-10-01T15:30:08Z

@Mergifyio backport 9.2

mergify · 2025-10-01T15:30:17Z

backport 9.2

✅ Backports have been created

Details

Backport to branch 9.2 not needed, change already in branch 9.2

* Bump Go version to 1.25.1 * Update CHANGELOG entry * Bump the version of golangci-lint * Remove references to the ms_tls13kdf build tag * Download go module dependencies before GODEBUG=fips140=only is set * Exclude X25519 curve types when testing in FIPS-140 mode * Stricter check * Add missing license header * Exclude X25519 curve types when testing in FIPS-140-only mode * Use stricter check * Update NOTICE files * Remove IsFIPS140Only helper function * Set GODEBUG=tlsmlkem=0 for FIPS140-only unit tests * Remove replace directive from go.mod * Try not pre-downloading dependencies (cherry picked from commit 15b8c8a)

* Bump Go version to 1.25.1 * Update CHANGELOG entry * Bump the version of golangci-lint * Remove references to the ms_tls13kdf build tag * Download go module dependencies before GODEBUG=fips140=only is set * Exclude X25519 curve types when testing in FIPS-140 mode * Stricter check * Add missing license header * Exclude X25519 curve types when testing in FIPS-140-only mode * Use stricter check * Update NOTICE files * Remove IsFIPS140Only helper function * Set GODEBUG=tlsmlkem=0 for FIPS140-only unit tests * Remove replace directive from go.mod * Try not pre-downloading dependencies (cherry picked from commit 15b8c8a) Co-authored-by: Shaunak Kashyap <ycombinator@gmail.com>

* Bump Go version to 1.25.1 (#5562) * Bump Go version to 1.25.1 * Update CHANGELOG entry * Bump the version of golangci-lint * Remove references to the ms_tls13kdf build tag * Download go module dependencies before GODEBUG=fips140=only is set * Exclude X25519 curve types when testing in FIPS-140 mode * Stricter check * Add missing license header * Exclude X25519 curve types when testing in FIPS-140-only mode * Use stricter check * Update NOTICE files * Remove IsFIPS140Only helper function * Set GODEBUG=tlsmlkem=0 for FIPS140-only unit tests * Remove replace directive from go.mod * Try not pre-downloading dependencies (cherry picked from commit 15b8c8a) * Remove FIPS doc * Fixing conflicts --------- Co-authored-by: Shaunak Kashyap <ycombinator@gmail.com>

* Bump Go version to 1.25.1 (#5562) * Bump Go version to 1.25.1 * Update CHANGELOG entry * Bump the version of golangci-lint * Remove references to the ms_tls13kdf build tag * Download go module dependencies before GODEBUG=fips140=only is set * Exclude X25519 curve types when testing in FIPS-140 mode * Stricter check * Add missing license header * Exclude X25519 curve types when testing in FIPS-140-only mode * Use stricter check * Update NOTICE files * Remove IsFIPS140Only helper function * Set GODEBUG=tlsmlkem=0 for FIPS140-only unit tests * Remove replace directive from go.mod * Try not pre-downloading dependencies (cherry picked from commit 15b8c8a) * Fixing conflicts * Bumping timeout --------- Co-authored-by: Shaunak Kashyap <ycombinator@gmail.com>

ycombinator requested a review from a team as a code owner September 25, 2025 17:07

ycombinator requested review from michel-laterman and pkoutsovasilis September 25, 2025 17:07

ycombinator added the backport-active-all Automated backport with mergify to all the active branches label Sep 25, 2025

ycombinator requested a review from a team as a code owner September 25, 2025 17:12

v1v previously approved these changes Sep 25, 2025

View reviewed changes

blakerouse previously approved these changes Sep 25, 2025

View reviewed changes

michel-laterman previously approved these changes Sep 25, 2025

View reviewed changes

ycombinator dismissed stale reviews from michel-laterman, blakerouse, and v1v via f4ecb06 September 25, 2025 21:26

ycombinator marked this pull request as draft September 26, 2025 05:26

ycombinator mentioned this pull request Sep 26, 2025

Export tlscommon.TLSCurveType elastic/elastic-agent-libs#359

Closed

ycombinator commented Sep 26, 2025

View reviewed changes

Comment thread go.mod Outdated

ycombinator added 12 commits September 29, 2025 11:57

Bump Go version to 1.25.1

0616eee

Update CHANGELOG entry

9352d5a

Bump the version of golangci-lint

cb9a8f1

Remove references to the ms_tls13kdf build tag

3ee9566

Download go module dependencies before GODEBUG=fips140=only is set

52bf43a

Exclude X25519 curve types when testing in FIPS-140 mode

fbaa55f

Stricter check

17b2793

Add missing license header

79bf282

Exclude X25519 curve types when testing in FIPS-140-only mode

9305ef3

Use stricter check

04596f0

Update NOTICE files

55d35cb

Remove IsFIPS140Only helper function

ed272c5

ycombinator requested review from blakerouse and michel-laterman September 29, 2025 20:50

Try not pre-downloading dependencies

165d10e

ycombinator enabled auto-merge (squash) September 29, 2025 21:55

ebeahan approved these changes Oct 1, 2025

View reviewed changes

v1v approved these changes Oct 1, 2025

View reviewed changes

ycombinator merged commit 15b8c8a into elastic:main Oct 1, 2025
13 checks passed

ycombinator deleted the bump-golang-1.25.1 branch October 1, 2025 13:45

mergify Bot mentioned this pull request Oct 1, 2025

[8.18](backport #5562) Bump Go version to 1.25.1 #5581

Merged

This was referenced Oct 1, 2025

[8.19](backport #5562) Bump Go version to 1.25.1 #5582

Merged

[9.0](backport #5562) Bump Go version to 1.25.1 #5583

Merged

mergify Bot mentioned this pull request Oct 1, 2025

[9.1](backport #5562) Bump Go version to 1.25.1 #5584

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Bump Go version to 1.25.1#5562

Bump Go version to 1.25.1#5562
ycombinator merged 15 commits into
elastic:mainfrom
ycombinator:bump-golang-1.25.1

ycombinator commented Sep 25, 2025 •

edited

Loading

Uh oh!

mergify Bot commented Sep 25, 2025

Uh oh!

prodsecmachine commented Sep 25, 2025 •

edited

Loading

Uh oh!

michel-laterman left a comment

Uh oh!

github-actions Bot commented Sep 25, 2025 •

edited

Loading

Uh oh!

ycombinator commented Sep 26, 2025 •

edited

Loading

Uh oh!

Uh oh!

elastic-sonarqube Bot commented Sep 29, 2025

Uh oh!

Uh oh!

github-actions Bot commented Oct 1, 2025

Uh oh!

mergify Bot commented Oct 1, 2025 •

edited

Loading

Uh oh!

ycombinator commented Oct 1, 2025

Uh oh!

mergify Bot commented Oct 1, 2025 •

edited

Loading

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

Conversation

ycombinator commented Sep 25, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

mergify Bot commented Sep 25, 2025

Uh oh!

prodsecmachine commented Sep 25, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🎉 Snyk checks have passed. No issues have been found so far.

Uh oh!

michel-laterman left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions Bot commented Sep 25, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🔍 Preview links for changed docs

Uh oh!

ycombinator commented Sep 26, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

elastic-sonarqube Bot commented Sep 29, 2025

Quality Gate passed

Uh oh!

Uh oh!

github-actions Bot commented Oct 1, 2025

Uh oh!

mergify Bot commented Oct 1, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

❌ No backport have been created

Uh oh!

ycombinator commented Oct 1, 2025

Uh oh!

mergify Bot commented Oct 1, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ Backports have been created

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

ycombinator commented Sep 25, 2025 •

edited

Loading

prodsecmachine commented Sep 25, 2025 •

edited

Loading

github-actions Bot commented Sep 25, 2025 •

edited

Loading

ycombinator commented Sep 26, 2025 •

edited

Loading

mergify Bot commented Oct 1, 2025 •

edited

Loading

mergify Bot commented Oct 1, 2025 •

edited

Loading