Skip to content

Bump Go version to 1.25.8#10156

Merged
ebeahan merged 43 commits into
elastic:mainfrom
ycombinator:bump-golang-1.25.1
Mar 12, 2026
Merged

Bump Go version to 1.25.8#10156
ebeahan merged 43 commits into
elastic:mainfrom
ycombinator:bump-golang-1.25.1

Conversation

@ycombinator
Copy link
Copy Markdown
Contributor

@ycombinator ycombinator commented Sep 25, 2025

This PR bumps up the Golang version to 1.25.8. It also:

  • removes the ms_tls13kdf Golang build tag when building in FIPS mode because this tag was only needed before Golang versions 1.24.x.
  • sets ths GODEBUG=tlsmlkem=0 environment variable when running FIPS140-only unit tests. This prevents errors like so: Failed to connect: crypto/ecdh: use of X25519 is not allowed in FIPS 140-only mode.

@ycombinator ycombinator requested review from a team as code owners September 25, 2025 17:46
@ycombinator ycombinator added Team:Elastic-Agent-Control-Plane Label for the Agent Control Plane team backport-active-all Automated backport with mergify to all the active branches labels Sep 25, 2025
@elasticmachine
Copy link
Copy Markdown
Contributor

Pinging @elastic/elastic-agent-control-plane (Team:Elastic-Agent-Control-Plane)

@ycombinator
Copy link
Copy Markdown
Contributor Author

ycombinator commented Sep 25, 2025

The fips140=only unit tests are failing like so:

crypto/ecdh: use of X25519 is not allowed in FIPS 140-only mode

These appear to be golang/go#75148, which should be fixable when golang/go#74630 is implemented. However, in order to upgrade to Go 1.25.1 now, we'll need to find a workaround.

Comment thread dev-tools/mage/otel/deps_test.go Outdated
@ycombinator
Copy link
Copy Markdown
Contributor Author

ycombinator commented Sep 25, 2025

The fips140=only unit tests are failing like so:

crypto/ecdh: use of X25519 is not allowed in FIPS 140-only mode

These appear to be golang/go#75148, which should be fixable when golang/go#74630 is implemented. However, in order to upgrade to Go 1.25.1 now, we'll need to find a workaround.

These errors are coming from Go downloading dependencies before executing the tests. The errors can be simulated like so:

GODEBUG=fips140=only go mod download -x
# get https://proxy.golang.org/github.com/opencontainers/image-spec/@v/v1.1.1.info
# get https://proxy.golang.org/github.com/opencontainers/image-spec/@v/v1.1.1.info: Get "https://proxy.golang.org/github.com/opencontainers/image-spec/@v/v1.1.1.info": crypto/ecdh: use of X25519 is not allowed in FIPS 140-only mode
...

So we probably just need to download the dependencies explicitly, ensuring that GODEBUG=fips140=only is not set for this step.

@ycombinator
Copy link
Copy Markdown
Contributor Author

So we probably just need to download the dependencies explicitly, ensuring that GODEBUG=fips140=only is not set for this step.

I've implemented this approach in this PR and it has helped. However, now CI is failing with this odd error which seems unrelated to FIPS in any way.

https://buildkite.com/elastic/elastic-agent/builds/27575#0199842f-d9dd-4481-9d46-37baa5c789b1/155-822

=== FAIL: dev-tools/mage TestGoTest_CaptureOutput/capture_panic (1.61s)
--
  | >> go test: asserts Testing
  | >> ARGS: asserts Command: gotestsum --no-color --junitfile-hide-skipped-tests -f standard-quiet -- -test.run TestGoTest_Helper_WithPanic .
  | 2025/09/26 04:35:17 exec: gotestsum --no-color --junitfile-hide-skipped-tests -f standard-quiet -- -test.run TestGoTest_Helper_WithPanic .
  | exec: gotestsum --no-color --junitfile-hide-skipped-tests -f standard-quiet -- -test.run TestGoTest_Helper_WithPanic .
  | gotest_test.go:120: GoTest output mismatch:
  | want:
  | (?sm:
  | === FAIL: dev-tools/mage TestGoTest_Helper_WithPanic.*
  | panic: Kaputt. \[recovered\].*
  | panic: Kaputt.*
  | )
  |  
  | got:
  | FAIL	github.com/elastic/elastic-agent/dev-tools/mage	0.021s
  |  
  | === Failed
  | === FAIL: dev-tools/mage TestGoTest_Helper_WithPanic (0.00s)
  | panic: Kaputt. [recovered, repanicked]
  |  
  | goroutine 21 [running]:
  | testing.tRunner.func1.2({0xcd39e0, 0xf923f0})
  | /opt/buildkite-agent/.asdf/installs/golang/1.25.1/go/src/testing/testing.go:1872 +0x237
  | testing.tRunner.func1()
  | /opt/buildkite-agent/.asdf/installs/golang/1.25.1/go/src/testing/testing.go:1875 +0x35b
  | panic({0xcd39e0?, 0xf923f0?})
  | /opt/buildkite-agent/.asdf/installs/golang/1.25.1/go/src/runtime/panic.go:783 +0x132
  | github.com/elastic/elastic-agent/dev-tools/mage.TestGoTest_Helper_WithPanic(0xc000103880?)
  | /opt/buildkite-agent/builds/bk-agent-prod-gcp-1758859361500881345/elastic/elastic-agent/dev-tools/mage/gotest_test.go:329 +0x30
  | testing.tRunner(0xc000103880, 0xea4750)
  | /opt/buildkite-agent/.asdf/installs/golang/1.25.1/go/src/testing/testing.go:1934 +0xea
  | created by testing.(*T).Run in goroutine 1
  | /opt/buildkite-agent/.asdf/installs/golang/1.25.1/go/src/testing/testing.go:1997 +0x465
  |  
  | DONE 1 tests, 1 failure in 0.022s
  |  
  | === FAIL: dev-tools/mage TestGoTest_CaptureOutput (26.02s)

@ycombinator
Copy link
Copy Markdown
Contributor Author

So we probably just need to download the dependencies explicitly, ensuring that GODEBUG=fips140=only is not set for this step.

I've implemented this approach in this PR and it has helped. However, now CI is failing with this odd error which seems unrelated to FIPS in any way.

https://buildkite.com/elastic/elastic-agent/builds/27575#0199842f-d9dd-4481-9d46-37baa5c789b1/155-822

=== FAIL: dev-tools/mage TestGoTest_CaptureOutput/capture_panic (1.61s)
--
  | >> go test: asserts Testing
  | >> ARGS: asserts Command: gotestsum --no-color --junitfile-hide-skipped-tests -f standard-quiet -- -test.run TestGoTest_Helper_WithPanic .
  | 2025/09/26 04:35:17 exec: gotestsum --no-color --junitfile-hide-skipped-tests -f standard-quiet -- -test.run TestGoTest_Helper_WithPanic .
  | exec: gotestsum --no-color --junitfile-hide-skipped-tests -f standard-quiet -- -test.run TestGoTest_Helper_WithPanic .
  | gotest_test.go:120: GoTest output mismatch:
  | want:
  | (?sm:
  | === FAIL: dev-tools/mage TestGoTest_Helper_WithPanic.*
  | panic: Kaputt. \[recovered\].*
  | panic: Kaputt.*
  | )
  |  
  | got:
  | FAIL	github.com/elastic/elastic-agent/dev-tools/mage	0.021s
  |  
  | === Failed
  | === FAIL: dev-tools/mage TestGoTest_Helper_WithPanic (0.00s)
  | panic: Kaputt. [recovered, repanicked]
  |  
  | goroutine 21 [running]:
  | testing.tRunner.func1.2({0xcd39e0, 0xf923f0})
  | /opt/buildkite-agent/.asdf/installs/golang/1.25.1/go/src/testing/testing.go:1872 +0x237
  | testing.tRunner.func1()
  | /opt/buildkite-agent/.asdf/installs/golang/1.25.1/go/src/testing/testing.go:1875 +0x35b
  | panic({0xcd39e0?, 0xf923f0?})
  | /opt/buildkite-agent/.asdf/installs/golang/1.25.1/go/src/runtime/panic.go:783 +0x132
  | github.com/elastic/elastic-agent/dev-tools/mage.TestGoTest_Helper_WithPanic(0xc000103880?)
  | /opt/buildkite-agent/builds/bk-agent-prod-gcp-1758859361500881345/elastic/elastic-agent/dev-tools/mage/gotest_test.go:329 +0x30
  | testing.tRunner(0xc000103880, 0xea4750)
  | /opt/buildkite-agent/.asdf/installs/golang/1.25.1/go/src/testing/testing.go:1934 +0xea
  | created by testing.(*T).Run in goroutine 1
  | /opt/buildkite-agent/.asdf/installs/golang/1.25.1/go/src/testing/testing.go:1997 +0x465
  |  
  | DONE 1 tests, 1 failure in 0.022s
  |  
  | === FAIL: dev-tools/mage TestGoTest_CaptureOutput (26.02s)

Turns out this is a change in behavior in Go 1.25: https://tip.golang.org/doc/go1.25#change-to-unhandled-panic-output. Addressed in 46cc036.

Comment thread magefile.go Outdated
@pchila
Copy link
Copy Markdown
Member

pchila commented Sep 29, 2025

Looking at the latest build I see a couple of strange things (maybe some of those were already there and didn't notice until now)

@ycombinator
Copy link
Copy Markdown
Contributor Author

Windows build steps are failing in CI on this PR. See a lot of Access is denied errors. 🤔

@elastic-sonarqube
Copy link
Copy Markdown

@ycombinator ycombinator force-pushed the bump-golang-1.25.1 branch 2 times, most recently from 52d2f67 to b6b1a81 Compare October 1, 2025 14:36
@mergify
Copy link
Copy Markdown
Contributor

mergify Bot commented Oct 3, 2025

This pull request is now in conflicts. Could you fix it? 🙏
To fixup this pull request, you can check out it locally. See documentation: https://help.github.com/articles/checking-out-pull-requests-locally/

git fetch upstream
git checkout -b bump-golang-1.25.1 upstream/bump-golang-1.25.1
git merge upstream/main
git push upstream bump-golang-1.25.1

@ycombinator ycombinator changed the title Bump Go version to 1.25.1 Bump Go version to 1.25.2 Oct 13, 2025
@ycombinator ycombinator force-pushed the bump-golang-1.25.1 branch 2 times, most recently from a41a670 to eaf3ce7 Compare October 15, 2025 00:21
@mergify
Copy link
Copy Markdown
Contributor

mergify Bot commented Oct 16, 2025

This pull request is now in conflicts. Could you fix it? 🙏
To fixup this pull request, you can check out it locally. See documentation: https://help.github.com/articles/checking-out-pull-requests-locally/

git fetch upstream
git checkout -b bump-golang-1.25.1 upstream/bump-golang-1.25.1
git merge upstream/main
git push upstream bump-golang-1.25.1

@mergify mergify Bot mentioned this pull request Mar 12, 2026
7 tasks
@swiatekm swiatekm self-assigned this Mar 12, 2026
Copy link
Copy Markdown
Member

@ebeahan ebeahan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving based on team discussion to merge to main and hold off to merge backports until we have more information about the FIPS related changes.

@elasticmachine
Copy link
Copy Markdown
Contributor

@ebeahan ebeahan merged commit e653b4f into elastic:main Mar 12, 2026
21 of 23 checks passed
@github-actions
Copy link
Copy Markdown
Contributor

@Mergifyio backport 8.19 9.2 9.3

@mergify
Copy link
Copy Markdown
Contributor

mergify Bot commented Mar 12, 2026

backport 8.19 9.2 9.3

❌ No backport have been created

Details
  • Backport to branch 8.19 failed

Git reported the following error:

error: 'beats' does not have a commit checked out
fatal: updating files failed

  • Backport to branch 9.2 failed

Git reported the following error:

error: 'beats' does not have a commit checked out
fatal: updating files failed

  • Backport to branch 9.3 failed

Git reported the following error:

Auto-merging NOTICE-fips.txt
Auto-merging NOTICE.txt
Failed to merge submodule beats (not checked out)
CONFLICT (submodule): Merge conflict in beats
Auto-merging dev-tools/mage/otel/deps_test.go
Auto-merging go.mod
Auto-merging internal/edot/go.mod
Auto-merging internal/edot/go.sum
Auto-merging magefile.go
Auto-merging version/docs/version.asciidoc
Recursive merging with submodules currently only supports trivial cases.
Please manually handle the merging of each conflicted submodule.
This can be accomplished with the following steps:
 - come back to superproject and run:

      git add beats

   to record the above merge or update
 - resolve any other conflicts in the superproject
 - commit the resulting index in the superproject
error: could not apply e653b4f1d... Bump Go version to 1.25.8 (#10156)
hint: After resolving the conflicts, mark them with
hint: "git add/rm <pathspec>", then run
hint: "git cherry-pick --continue".
hint: You can instead skip this commit with "git cherry-pick --skip".
hint: To abort and get back to the state before "git cherry-pick",
hint: run "git cherry-pick --abort".

michel-laterman added a commit that referenced this pull request Mar 12, 2026
* Bump Go version to 1.25.1

* Update CHANGELOG entry

* Bump the version of golangci-lint

* Update dev-tools/mage/otel/deps_test.go

Co-authored-by: Panos Koutsovasilis <koutsobill@hotmail.com>

* Remove references to the ms_tls13kdf build tag

* Use mage target specifically intended for fips140=only unit testing

* Download go module dependencies before GODEBUG=fips140=only is set

* [Debugging] Print go test command environment right before command is run

* Revert "[Debugging] Print go test command environment right before command is run"

This reverts commit 079e74c.

* Fix regular expression for matching panicking output

* Run dependencies first

* Append requirefips build tag for fips140=only unit tests

* Fix policy change handler unit tests

* Fix TestDownloadVersion test

* Set GODEBUG=tlsmlkem=0 for test

* No longer necessary

* Formatting fixes

* Remove pre-downloading of go modules

* Revert unit test pipeline changes

* Add GODEBUG=tlsmlkem=0

* s/1.25.1/1.25.2/g

* Go version: s/1.25.2/1.25.4/g

* Update go version in edot go.mod

* s/1.24.4/1.24.5/g

* Remove ms_tls13kdf from TestTagsWithFIPS

* Running go mod tidy

* s/1.25.5/1.25.8/g

* Running go mod tidy and mage notice

* Running mage otel:readme

* Fixing go.mods

* Bumping up beats

* Running go mod tidy

* Update unit tests

* Use Go 1.24's RemoveAll in uninstall

* Wait for fsnotify watcher to be released

* Update internal/pkg/agent/application/upgrade/marker_watcher.go

Co-authored-by: Michel Laterman <82832767+michel-laterman@users.noreply.github.com>

* Fix function signature in MarkerFileWatcher

* Use the exact removaAll implementation from Go 1.24

* Add link to the new RemoveAll implementation

* Revert "Use the exact removaAll implementation from Go 1.24"

This reverts commit 88ece11

---------

Co-authored-by: Panos Koutsovasilis <koutsobill@hotmail.com>
Co-authored-by: Mikołaj Świątek <mail@mikolajswiatek.com>
Co-authored-by: Michel Laterman <82832767+michel-laterman@users.noreply.github.com>
michel-laterman added a commit that referenced this pull request Mar 12, 2026
* Bump Go version to 1.25.1

* Update CHANGELOG entry

* Bump the version of golangci-lint

* Update dev-tools/mage/otel/deps_test.go

Co-authored-by: Panos Koutsovasilis <koutsobill@hotmail.com>

* Remove references to the ms_tls13kdf build tag

* Use mage target specifically intended for fips140=only unit testing

* Download go module dependencies before GODEBUG=fips140=only is set

* [Debugging] Print go test command environment right before command is run

* Revert "[Debugging] Print go test command environment right before command is run"

This reverts commit 079e74c.

* Fix regular expression for matching panicking output

* Run dependencies first

* Append requirefips build tag for fips140=only unit tests

* Fix policy change handler unit tests

* Fix TestDownloadVersion test

* Set GODEBUG=tlsmlkem=0 for test

* No longer necessary

* Formatting fixes

* Remove pre-downloading of go modules

* Revert unit test pipeline changes

* Add GODEBUG=tlsmlkem=0

* s/1.25.1/1.25.2/g

* Go version: s/1.25.2/1.25.4/g

* Update go version in edot go.mod

* s/1.24.4/1.24.5/g

* Remove ms_tls13kdf from TestTagsWithFIPS

* Running go mod tidy

* s/1.25.5/1.25.8/g

* Running go mod tidy and mage notice

* Running mage otel:readme

* Fixing go.mods

* Bumping up beats

* Running go mod tidy

* Update unit tests

* Use Go 1.24's RemoveAll in uninstall

* Wait for fsnotify watcher to be released

* Update internal/pkg/agent/application/upgrade/marker_watcher.go

Co-authored-by: Michel Laterman <82832767+michel-laterman@users.noreply.github.com>

* Fix function signature in MarkerFileWatcher

* Use the exact removaAll implementation from Go 1.24

* Add link to the new RemoveAll implementation

* Revert "Use the exact removaAll implementation from Go 1.24"

This reverts commit 88ece11

---------

Co-authored-by: Panos Koutsovasilis <koutsobill@hotmail.com>
Co-authored-by: Mikołaj Świątek <mail@mikolajswiatek.com>
Co-authored-by: Michel Laterman <82832767+michel-laterman@users.noreply.github.com>
michel-laterman added a commit that referenced this pull request Mar 12, 2026
* Bump Go version to 1.25.1

* Update CHANGELOG entry

* Bump the version of golangci-lint

* Update dev-tools/mage/otel/deps_test.go

Co-authored-by: Panos Koutsovasilis <koutsobill@hotmail.com>

* Remove references to the ms_tls13kdf build tag

* Use mage target specifically intended for fips140=only unit testing

* Download go module dependencies before GODEBUG=fips140=only is set

* [Debugging] Print go test command environment right before command is run

* Revert "[Debugging] Print go test command environment right before command is run"

This reverts commit 079e74c.

* Fix regular expression for matching panicking output

* Run dependencies first

* Append requirefips build tag for fips140=only unit tests

* Fix policy change handler unit tests

* Fix TestDownloadVersion test

* Set GODEBUG=tlsmlkem=0 for test

* No longer necessary

* Formatting fixes

* Remove pre-downloading of go modules

* Revert unit test pipeline changes

* Add GODEBUG=tlsmlkem=0

* s/1.25.1/1.25.2/g

* Go version: s/1.25.2/1.25.4/g

* Update go version in edot go.mod

* s/1.24.4/1.24.5/g

* Remove ms_tls13kdf from TestTagsWithFIPS

* Running go mod tidy

* s/1.25.5/1.25.8/g

* Running go mod tidy and mage notice

* Running mage otel:readme

* Fixing go.mods

* Bumping up beats

* Running go mod tidy

* Update unit tests

* Use Go 1.24's RemoveAll in uninstall

* Wait for fsnotify watcher to be released

* Update internal/pkg/agent/application/upgrade/marker_watcher.go

Co-authored-by: Michel Laterman <82832767+michel-laterman@users.noreply.github.com>

* Fix function signature in MarkerFileWatcher

* Use the exact removaAll implementation from Go 1.24

* Add link to the new RemoveAll implementation

* Revert "Use the exact removaAll implementation from Go 1.24"

This reverts commit 88ece11

---------

Co-authored-by: Panos Koutsovasilis <koutsobill@hotmail.com>
Co-authored-by: Mikołaj Świątek <mail@mikolajswiatek.com>
Co-authored-by: Michel Laterman <82832767+michel-laterman@users.noreply.github.com>
@ycombinator ycombinator deleted the bump-golang-1.25.1 branch March 16, 2026 15:00
ebeahan pushed a commit that referenced this pull request Mar 17, 2026
* Bump Go version to 1.25.1

* Update CHANGELOG entry

* Bump the version of golangci-lint

* Update dev-tools/mage/otel/deps_test.go

Co-authored-by: Panos Koutsovasilis <koutsobill@hotmail.com>

* Remove references to the ms_tls13kdf build tag

* Use mage target specifically intended for fips140=only unit testing

* Download go module dependencies before GODEBUG=fips140=only is set

* [Debugging] Print go test command environment right before command is run

* Revert "[Debugging] Print go test command environment right before command is run"

This reverts commit 079e74c.

* Fix regular expression for matching panicking output

* Run dependencies first

* Append requirefips build tag for fips140=only unit tests

* Fix policy change handler unit tests

* Fix TestDownloadVersion test

* Set GODEBUG=tlsmlkem=0 for test

* No longer necessary

* Formatting fixes

* Remove pre-downloading of go modules

* Revert unit test pipeline changes

* Add GODEBUG=tlsmlkem=0

* s/1.25.1/1.25.2/g

* Go version: s/1.25.2/1.25.4/g

* Update go version in edot go.mod

* s/1.24.4/1.24.5/g

* Remove ms_tls13kdf from TestTagsWithFIPS

* Running go mod tidy

* s/1.25.5/1.25.8/g

* Running go mod tidy and mage notice

* Running mage otel:readme

* Fixing go.mods

* Bumping up beats

* Running go mod tidy

* Update unit tests

* Use Go 1.24's RemoveAll in uninstall

* Wait for fsnotify watcher to be released

* Update internal/pkg/agent/application/upgrade/marker_watcher.go

Co-authored-by: Michel Laterman <82832767+michel-laterman@users.noreply.github.com>

* Fix function signature in MarkerFileWatcher

* Use the exact removaAll implementation from Go 1.24

* Add link to the new RemoveAll implementation

* Revert "Use the exact removaAll implementation from Go 1.24"

This reverts commit 88ece11

---------

Co-authored-by: Panos Koutsovasilis <koutsobill@hotmail.com>
Co-authored-by: Mikołaj Świątek <mail@mikolajswiatek.com>
Co-authored-by: Michel Laterman <82832767+michel-laterman@users.noreply.github.com>
ebeahan added a commit that referenced this pull request Mar 17, 2026
* Bump Go version to 1.25.8 (#10156)

* Bump Go version to 1.25.1

* Update CHANGELOG entry

* Bump the version of golangci-lint

* Update dev-tools/mage/otel/deps_test.go

Co-authored-by: Panos Koutsovasilis <koutsobill@hotmail.com>

* Remove references to the ms_tls13kdf build tag

* Use mage target specifically intended for fips140=only unit testing

* Download go module dependencies before GODEBUG=fips140=only is set

* [Debugging] Print go test command environment right before command is run

* Revert "[Debugging] Print go test command environment right before command is run"

This reverts commit 079e74c.

* Fix regular expression for matching panicking output

* Run dependencies first

* Append requirefips build tag for fips140=only unit tests

* Fix policy change handler unit tests

* Fix TestDownloadVersion test

* Set GODEBUG=tlsmlkem=0 for test

* No longer necessary

* Formatting fixes

* Remove pre-downloading of go modules

* Revert unit test pipeline changes

* Add GODEBUG=tlsmlkem=0

* s/1.25.1/1.25.2/g

* Go version: s/1.25.2/1.25.4/g

* Update go version in edot go.mod

* s/1.24.4/1.24.5/g

* Remove ms_tls13kdf from TestTagsWithFIPS

* Running go mod tidy

* s/1.25.5/1.25.8/g

* Running go mod tidy and mage notice

* Running mage otel:readme

* Fixing go.mods

* Bumping up beats

* Running go mod tidy

* Update unit tests

* Use Go 1.24's RemoveAll in uninstall

* Wait for fsnotify watcher to be released

* Update internal/pkg/agent/application/upgrade/marker_watcher.go

Co-authored-by: Michel Laterman <82832767+michel-laterman@users.noreply.github.com>

* Fix function signature in MarkerFileWatcher

* Use the exact removaAll implementation from Go 1.24

* Add link to the new RemoveAll implementation

* Revert "Use the exact removaAll implementation from Go 1.24"

This reverts commit 88ece11

---------

Co-authored-by: Panos Koutsovasilis <koutsobill@hotmail.com>
Co-authored-by: Mikołaj Świątek <mail@mikolajswiatek.com>
Co-authored-by: Michel Laterman <82832767+michel-laterman@users.noreply.github.com>

* go mod tidy

* fix NOTICE files

---------

Co-authored-by: Shaunak Kashyap <ycombinator@gmail.com>
Co-authored-by: Panos Koutsovasilis <koutsobill@hotmail.com>
Co-authored-by: Mikołaj Świątek <mail@mikolajswiatek.com>
Co-authored-by: Eric Beahan <eric.beahan@elastic.co>
ebeahan added a commit that referenced this pull request Mar 17, 2026
* Bump Go version to 1.25.8 (#10156)

* Bump Go version to 1.25.1

* Update CHANGELOG entry

* Bump the version of golangci-lint

* Update dev-tools/mage/otel/deps_test.go

Co-authored-by: Panos Koutsovasilis <koutsobill@hotmail.com>

* Remove references to the ms_tls13kdf build tag

* Use mage target specifically intended for fips140=only unit testing

* Download go module dependencies before GODEBUG=fips140=only is set

* [Debugging] Print go test command environment right before command is run

* Revert "[Debugging] Print go test command environment right before command is run"

This reverts commit 079e74c.

* Fix regular expression for matching panicking output

* Run dependencies first

* Append requirefips build tag for fips140=only unit tests

* Fix policy change handler unit tests

* Fix TestDownloadVersion test

* Set GODEBUG=tlsmlkem=0 for test

* No longer necessary

* Formatting fixes

* Remove pre-downloading of go modules

* Revert unit test pipeline changes

* Add GODEBUG=tlsmlkem=0

* s/1.25.1/1.25.2/g

* Go version: s/1.25.2/1.25.4/g

* Update go version in edot go.mod

* s/1.24.4/1.24.5/g

* Remove ms_tls13kdf from TestTagsWithFIPS

* Running go mod tidy

* s/1.25.5/1.25.8/g

* Running go mod tidy and mage notice

* Running mage otel:readme

* Fixing go.mods

* Bumping up beats

* Running go mod tidy

* Update unit tests

* Use Go 1.24's RemoveAll in uninstall

* Wait for fsnotify watcher to be released

* Update internal/pkg/agent/application/upgrade/marker_watcher.go

Co-authored-by: Michel Laterman <82832767+michel-laterman@users.noreply.github.com>

* Fix function signature in MarkerFileWatcher

* Use the exact removaAll implementation from Go 1.24

* Add link to the new RemoveAll implementation

* Revert "Use the exact removaAll implementation from Go 1.24"

This reverts commit 88ece11

---------

Co-authored-by: Panos Koutsovasilis <koutsobill@hotmail.com>
Co-authored-by: Mikołaj Świątek <mail@mikolajswiatek.com>
Co-authored-by: Michel Laterman <82832767+michel-laterman@users.noreply.github.com>

* go mod tidy

* fix NOTICE files

---------

Co-authored-by: Shaunak Kashyap <ycombinator@gmail.com>
Co-authored-by: Panos Koutsovasilis <koutsobill@hotmail.com>
Co-authored-by: Mikołaj Świątek <mail@mikolajswiatek.com>
Co-authored-by: ebeahan <eric.beahan@elastic.co>
swiatekm added a commit that referenced this pull request Mar 18, 2026
* Bump Go version to 1.25.8 (#10156)

* Bump Go version to 1.25.1

* Update CHANGELOG entry

* Bump the version of golangci-lint

* Update dev-tools/mage/otel/deps_test.go

Co-authored-by: Panos Koutsovasilis <koutsobill@hotmail.com>

* Remove references to the ms_tls13kdf build tag

* Use mage target specifically intended for fips140=only unit testing

* Download go module dependencies before GODEBUG=fips140=only is set

* [Debugging] Print go test command environment right before command is run

* Revert "[Debugging] Print go test command environment right before command is run"

This reverts commit 079e74c.

* Fix regular expression for matching panicking output

* Run dependencies first

* Append requirefips build tag for fips140=only unit tests

* Fix policy change handler unit tests

* Fix TestDownloadVersion test

* Set GODEBUG=tlsmlkem=0 for test

* No longer necessary

* Formatting fixes

* Remove pre-downloading of go modules

* Revert unit test pipeline changes

* Add GODEBUG=tlsmlkem=0

* s/1.25.1/1.25.2/g

* Go version: s/1.25.2/1.25.4/g

* Update go version in edot go.mod

* s/1.24.4/1.24.5/g

* Remove ms_tls13kdf from TestTagsWithFIPS

* Running go mod tidy

* s/1.25.5/1.25.8/g

* Running go mod tidy and mage notice

* Running mage otel:readme

* Fixing go.mods

* Bumping up beats

* Running go mod tidy

* Update unit tests

* Use Go 1.24's RemoveAll in uninstall

* Wait for fsnotify watcher to be released

* Update internal/pkg/agent/application/upgrade/marker_watcher.go

Co-authored-by: Michel Laterman <82832767+michel-laterman@users.noreply.github.com>

* Fix function signature in MarkerFileWatcher

* Use the exact removaAll implementation from Go 1.24

* Add link to the new RemoveAll implementation

* Revert "Use the exact removaAll implementation from Go 1.24"

This reverts commit 88ece11

---------

Co-authored-by: Panos Koutsovasilis <koutsobill@hotmail.com>
Co-authored-by: Mikołaj Świątek <mail@mikolajswiatek.com>
Co-authored-by: Michel Laterman <82832767+michel-laterman@users.noreply.github.com>

* try to manual bump to beats@c1cb121b7e6f to try unblocking crossbuild/npcap CI failures

* Bump beats to c1cb121b7e6f812dd7857a1192648b39b13dae47

---------

Co-authored-by: Shaunak Kashyap <ycombinator@gmail.com>
Co-authored-by: Panos Koutsovasilis <koutsobill@hotmail.com>
Co-authored-by: Mikołaj Świątek <mail@mikolajswiatek.com>
Co-authored-by: Eric Beahan <eric.beahan@elastic.co>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport-active-all Automated backport with mergify to all the active branches Team:Elastic-Agent-Control-Plane Label for the Agent Control Plane team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

9 participants