Bump Go version to 1.25.8#10156
Conversation
|
Pinging @elastic/elastic-agent-control-plane (Team:Elastic-Agent-Control-Plane) |
|
The These appear to be golang/go#75148, which should be fixable when golang/go#74630 is implemented. However, in order to upgrade to Go 1.25.1 now, we'll need to find a workaround. |
These errors are coming from Go downloading dependencies before executing the tests. The errors can be simulated like so: So we probably just need to download the dependencies explicitly, ensuring that |
I've implemented this approach in this PR and it has helped. However, now CI is failing with this odd error which seems unrelated to FIPS in any way. |
d8c500d to
0b69f33
Compare
Turns out this is a change in behavior in Go 1.25: https://tip.golang.org/doc/go1.25#change-to-unhandled-panic-output. Addressed in 46cc036. |
|
Looking at the latest build I see a couple of strange things (maybe some of those were already there and didn't notice until now)
|
|
Windows build steps are failing in CI on this PR. See a lot of |
4db5a4a to
1ceaae8
Compare
|
52d2f67 to
b6b1a81
Compare
|
This pull request is now in conflicts. Could you fix it? 🙏 |
b6b1a81 to
92a9716
Compare
a41a670 to
eaf3ce7
Compare
|
This pull request is now in conflicts. Could you fix it? 🙏 |
This reverts commit 88ece11
ebeahan
left a comment
There was a problem hiding this comment.
Approving based on team discussion to merge to main and hold off to merge backports until we have more information about the FIPS related changes.
⏳ Build in-progress, with failures
Failed CI Steps
History
|
|
@Mergifyio backport 8.19 9.2 9.3 |
❌ No backport have been createdDetails
Git reported the following error:
Git reported the following error:
Git reported the following error: |
* Bump Go version to 1.25.1 * Update CHANGELOG entry * Bump the version of golangci-lint * Update dev-tools/mage/otel/deps_test.go Co-authored-by: Panos Koutsovasilis <koutsobill@hotmail.com> * Remove references to the ms_tls13kdf build tag * Use mage target specifically intended for fips140=only unit testing * Download go module dependencies before GODEBUG=fips140=only is set * [Debugging] Print go test command environment right before command is run * Revert "[Debugging] Print go test command environment right before command is run" This reverts commit 079e74c. * Fix regular expression for matching panicking output * Run dependencies first * Append requirefips build tag for fips140=only unit tests * Fix policy change handler unit tests * Fix TestDownloadVersion test * Set GODEBUG=tlsmlkem=0 for test * No longer necessary * Formatting fixes * Remove pre-downloading of go modules * Revert unit test pipeline changes * Add GODEBUG=tlsmlkem=0 * s/1.25.1/1.25.2/g * Go version: s/1.25.2/1.25.4/g * Update go version in edot go.mod * s/1.24.4/1.24.5/g * Remove ms_tls13kdf from TestTagsWithFIPS * Running go mod tidy * s/1.25.5/1.25.8/g * Running go mod tidy and mage notice * Running mage otel:readme * Fixing go.mods * Bumping up beats * Running go mod tidy * Update unit tests * Use Go 1.24's RemoveAll in uninstall * Wait for fsnotify watcher to be released * Update internal/pkg/agent/application/upgrade/marker_watcher.go Co-authored-by: Michel Laterman <82832767+michel-laterman@users.noreply.github.com> * Fix function signature in MarkerFileWatcher * Use the exact removaAll implementation from Go 1.24 * Add link to the new RemoveAll implementation * Revert "Use the exact removaAll implementation from Go 1.24" This reverts commit 88ece11 --------- Co-authored-by: Panos Koutsovasilis <koutsobill@hotmail.com> Co-authored-by: Mikołaj Świątek <mail@mikolajswiatek.com> Co-authored-by: Michel Laterman <82832767+michel-laterman@users.noreply.github.com>
* Bump Go version to 1.25.1 * Update CHANGELOG entry * Bump the version of golangci-lint * Update dev-tools/mage/otel/deps_test.go Co-authored-by: Panos Koutsovasilis <koutsobill@hotmail.com> * Remove references to the ms_tls13kdf build tag * Use mage target specifically intended for fips140=only unit testing * Download go module dependencies before GODEBUG=fips140=only is set * [Debugging] Print go test command environment right before command is run * Revert "[Debugging] Print go test command environment right before command is run" This reverts commit 079e74c. * Fix regular expression for matching panicking output * Run dependencies first * Append requirefips build tag for fips140=only unit tests * Fix policy change handler unit tests * Fix TestDownloadVersion test * Set GODEBUG=tlsmlkem=0 for test * No longer necessary * Formatting fixes * Remove pre-downloading of go modules * Revert unit test pipeline changes * Add GODEBUG=tlsmlkem=0 * s/1.25.1/1.25.2/g * Go version: s/1.25.2/1.25.4/g * Update go version in edot go.mod * s/1.24.4/1.24.5/g * Remove ms_tls13kdf from TestTagsWithFIPS * Running go mod tidy * s/1.25.5/1.25.8/g * Running go mod tidy and mage notice * Running mage otel:readme * Fixing go.mods * Bumping up beats * Running go mod tidy * Update unit tests * Use Go 1.24's RemoveAll in uninstall * Wait for fsnotify watcher to be released * Update internal/pkg/agent/application/upgrade/marker_watcher.go Co-authored-by: Michel Laterman <82832767+michel-laterman@users.noreply.github.com> * Fix function signature in MarkerFileWatcher * Use the exact removaAll implementation from Go 1.24 * Add link to the new RemoveAll implementation * Revert "Use the exact removaAll implementation from Go 1.24" This reverts commit 88ece11 --------- Co-authored-by: Panos Koutsovasilis <koutsobill@hotmail.com> Co-authored-by: Mikołaj Świątek <mail@mikolajswiatek.com> Co-authored-by: Michel Laterman <82832767+michel-laterman@users.noreply.github.com>
* Bump Go version to 1.25.1 * Update CHANGELOG entry * Bump the version of golangci-lint * Update dev-tools/mage/otel/deps_test.go Co-authored-by: Panos Koutsovasilis <koutsobill@hotmail.com> * Remove references to the ms_tls13kdf build tag * Use mage target specifically intended for fips140=only unit testing * Download go module dependencies before GODEBUG=fips140=only is set * [Debugging] Print go test command environment right before command is run * Revert "[Debugging] Print go test command environment right before command is run" This reverts commit 079e74c. * Fix regular expression for matching panicking output * Run dependencies first * Append requirefips build tag for fips140=only unit tests * Fix policy change handler unit tests * Fix TestDownloadVersion test * Set GODEBUG=tlsmlkem=0 for test * No longer necessary * Formatting fixes * Remove pre-downloading of go modules * Revert unit test pipeline changes * Add GODEBUG=tlsmlkem=0 * s/1.25.1/1.25.2/g * Go version: s/1.25.2/1.25.4/g * Update go version in edot go.mod * s/1.24.4/1.24.5/g * Remove ms_tls13kdf from TestTagsWithFIPS * Running go mod tidy * s/1.25.5/1.25.8/g * Running go mod tidy and mage notice * Running mage otel:readme * Fixing go.mods * Bumping up beats * Running go mod tidy * Update unit tests * Use Go 1.24's RemoveAll in uninstall * Wait for fsnotify watcher to be released * Update internal/pkg/agent/application/upgrade/marker_watcher.go Co-authored-by: Michel Laterman <82832767+michel-laterman@users.noreply.github.com> * Fix function signature in MarkerFileWatcher * Use the exact removaAll implementation from Go 1.24 * Add link to the new RemoveAll implementation * Revert "Use the exact removaAll implementation from Go 1.24" This reverts commit 88ece11 --------- Co-authored-by: Panos Koutsovasilis <koutsobill@hotmail.com> Co-authored-by: Mikołaj Świątek <mail@mikolajswiatek.com> Co-authored-by: Michel Laterman <82832767+michel-laterman@users.noreply.github.com>
* Bump Go version to 1.25.1 * Update CHANGELOG entry * Bump the version of golangci-lint * Update dev-tools/mage/otel/deps_test.go Co-authored-by: Panos Koutsovasilis <koutsobill@hotmail.com> * Remove references to the ms_tls13kdf build tag * Use mage target specifically intended for fips140=only unit testing * Download go module dependencies before GODEBUG=fips140=only is set * [Debugging] Print go test command environment right before command is run * Revert "[Debugging] Print go test command environment right before command is run" This reverts commit 079e74c. * Fix regular expression for matching panicking output * Run dependencies first * Append requirefips build tag for fips140=only unit tests * Fix policy change handler unit tests * Fix TestDownloadVersion test * Set GODEBUG=tlsmlkem=0 for test * No longer necessary * Formatting fixes * Remove pre-downloading of go modules * Revert unit test pipeline changes * Add GODEBUG=tlsmlkem=0 * s/1.25.1/1.25.2/g * Go version: s/1.25.2/1.25.4/g * Update go version in edot go.mod * s/1.24.4/1.24.5/g * Remove ms_tls13kdf from TestTagsWithFIPS * Running go mod tidy * s/1.25.5/1.25.8/g * Running go mod tidy and mage notice * Running mage otel:readme * Fixing go.mods * Bumping up beats * Running go mod tidy * Update unit tests * Use Go 1.24's RemoveAll in uninstall * Wait for fsnotify watcher to be released * Update internal/pkg/agent/application/upgrade/marker_watcher.go Co-authored-by: Michel Laterman <82832767+michel-laterman@users.noreply.github.com> * Fix function signature in MarkerFileWatcher * Use the exact removaAll implementation from Go 1.24 * Add link to the new RemoveAll implementation * Revert "Use the exact removaAll implementation from Go 1.24" This reverts commit 88ece11 --------- Co-authored-by: Panos Koutsovasilis <koutsobill@hotmail.com> Co-authored-by: Mikołaj Świątek <mail@mikolajswiatek.com> Co-authored-by: Michel Laterman <82832767+michel-laterman@users.noreply.github.com>
* Bump Go version to 1.25.8 (#10156) * Bump Go version to 1.25.1 * Update CHANGELOG entry * Bump the version of golangci-lint * Update dev-tools/mage/otel/deps_test.go Co-authored-by: Panos Koutsovasilis <koutsobill@hotmail.com> * Remove references to the ms_tls13kdf build tag * Use mage target specifically intended for fips140=only unit testing * Download go module dependencies before GODEBUG=fips140=only is set * [Debugging] Print go test command environment right before command is run * Revert "[Debugging] Print go test command environment right before command is run" This reverts commit 079e74c. * Fix regular expression for matching panicking output * Run dependencies first * Append requirefips build tag for fips140=only unit tests * Fix policy change handler unit tests * Fix TestDownloadVersion test * Set GODEBUG=tlsmlkem=0 for test * No longer necessary * Formatting fixes * Remove pre-downloading of go modules * Revert unit test pipeline changes * Add GODEBUG=tlsmlkem=0 * s/1.25.1/1.25.2/g * Go version: s/1.25.2/1.25.4/g * Update go version in edot go.mod * s/1.24.4/1.24.5/g * Remove ms_tls13kdf from TestTagsWithFIPS * Running go mod tidy * s/1.25.5/1.25.8/g * Running go mod tidy and mage notice * Running mage otel:readme * Fixing go.mods * Bumping up beats * Running go mod tidy * Update unit tests * Use Go 1.24's RemoveAll in uninstall * Wait for fsnotify watcher to be released * Update internal/pkg/agent/application/upgrade/marker_watcher.go Co-authored-by: Michel Laterman <82832767+michel-laterman@users.noreply.github.com> * Fix function signature in MarkerFileWatcher * Use the exact removaAll implementation from Go 1.24 * Add link to the new RemoveAll implementation * Revert "Use the exact removaAll implementation from Go 1.24" This reverts commit 88ece11 --------- Co-authored-by: Panos Koutsovasilis <koutsobill@hotmail.com> Co-authored-by: Mikołaj Świątek <mail@mikolajswiatek.com> Co-authored-by: Michel Laterman <82832767+michel-laterman@users.noreply.github.com> * go mod tidy * fix NOTICE files --------- Co-authored-by: Shaunak Kashyap <ycombinator@gmail.com> Co-authored-by: Panos Koutsovasilis <koutsobill@hotmail.com> Co-authored-by: Mikołaj Świątek <mail@mikolajswiatek.com> Co-authored-by: Eric Beahan <eric.beahan@elastic.co>
* Bump Go version to 1.25.8 (#10156) * Bump Go version to 1.25.1 * Update CHANGELOG entry * Bump the version of golangci-lint * Update dev-tools/mage/otel/deps_test.go Co-authored-by: Panos Koutsovasilis <koutsobill@hotmail.com> * Remove references to the ms_tls13kdf build tag * Use mage target specifically intended for fips140=only unit testing * Download go module dependencies before GODEBUG=fips140=only is set * [Debugging] Print go test command environment right before command is run * Revert "[Debugging] Print go test command environment right before command is run" This reverts commit 079e74c. * Fix regular expression for matching panicking output * Run dependencies first * Append requirefips build tag for fips140=only unit tests * Fix policy change handler unit tests * Fix TestDownloadVersion test * Set GODEBUG=tlsmlkem=0 for test * No longer necessary * Formatting fixes * Remove pre-downloading of go modules * Revert unit test pipeline changes * Add GODEBUG=tlsmlkem=0 * s/1.25.1/1.25.2/g * Go version: s/1.25.2/1.25.4/g * Update go version in edot go.mod * s/1.24.4/1.24.5/g * Remove ms_tls13kdf from TestTagsWithFIPS * Running go mod tidy * s/1.25.5/1.25.8/g * Running go mod tidy and mage notice * Running mage otel:readme * Fixing go.mods * Bumping up beats * Running go mod tidy * Update unit tests * Use Go 1.24's RemoveAll in uninstall * Wait for fsnotify watcher to be released * Update internal/pkg/agent/application/upgrade/marker_watcher.go Co-authored-by: Michel Laterman <82832767+michel-laterman@users.noreply.github.com> * Fix function signature in MarkerFileWatcher * Use the exact removaAll implementation from Go 1.24 * Add link to the new RemoveAll implementation * Revert "Use the exact removaAll implementation from Go 1.24" This reverts commit 88ece11 --------- Co-authored-by: Panos Koutsovasilis <koutsobill@hotmail.com> Co-authored-by: Mikołaj Świątek <mail@mikolajswiatek.com> Co-authored-by: Michel Laterman <82832767+michel-laterman@users.noreply.github.com> * go mod tidy * fix NOTICE files --------- Co-authored-by: Shaunak Kashyap <ycombinator@gmail.com> Co-authored-by: Panos Koutsovasilis <koutsobill@hotmail.com> Co-authored-by: Mikołaj Świątek <mail@mikolajswiatek.com> Co-authored-by: ebeahan <eric.beahan@elastic.co>
* Bump Go version to 1.25.8 (#10156) * Bump Go version to 1.25.1 * Update CHANGELOG entry * Bump the version of golangci-lint * Update dev-tools/mage/otel/deps_test.go Co-authored-by: Panos Koutsovasilis <koutsobill@hotmail.com> * Remove references to the ms_tls13kdf build tag * Use mage target specifically intended for fips140=only unit testing * Download go module dependencies before GODEBUG=fips140=only is set * [Debugging] Print go test command environment right before command is run * Revert "[Debugging] Print go test command environment right before command is run" This reverts commit 079e74c. * Fix regular expression for matching panicking output * Run dependencies first * Append requirefips build tag for fips140=only unit tests * Fix policy change handler unit tests * Fix TestDownloadVersion test * Set GODEBUG=tlsmlkem=0 for test * No longer necessary * Formatting fixes * Remove pre-downloading of go modules * Revert unit test pipeline changes * Add GODEBUG=tlsmlkem=0 * s/1.25.1/1.25.2/g * Go version: s/1.25.2/1.25.4/g * Update go version in edot go.mod * s/1.24.4/1.24.5/g * Remove ms_tls13kdf from TestTagsWithFIPS * Running go mod tidy * s/1.25.5/1.25.8/g * Running go mod tidy and mage notice * Running mage otel:readme * Fixing go.mods * Bumping up beats * Running go mod tidy * Update unit tests * Use Go 1.24's RemoveAll in uninstall * Wait for fsnotify watcher to be released * Update internal/pkg/agent/application/upgrade/marker_watcher.go Co-authored-by: Michel Laterman <82832767+michel-laterman@users.noreply.github.com> * Fix function signature in MarkerFileWatcher * Use the exact removaAll implementation from Go 1.24 * Add link to the new RemoveAll implementation * Revert "Use the exact removaAll implementation from Go 1.24" This reverts commit 88ece11 --------- Co-authored-by: Panos Koutsovasilis <koutsobill@hotmail.com> Co-authored-by: Mikołaj Świątek <mail@mikolajswiatek.com> Co-authored-by: Michel Laterman <82832767+michel-laterman@users.noreply.github.com> * try to manual bump to beats@c1cb121b7e6f to try unblocking crossbuild/npcap CI failures * Bump beats to c1cb121b7e6f812dd7857a1192648b39b13dae47 --------- Co-authored-by: Shaunak Kashyap <ycombinator@gmail.com> Co-authored-by: Panos Koutsovasilis <koutsobill@hotmail.com> Co-authored-by: Mikołaj Świątek <mail@mikolajswiatek.com> Co-authored-by: Eric Beahan <eric.beahan@elastic.co>





This PR bumps up the Golang version to
1.25.8. It also:ms_tls13kdfGolang build tag when building in FIPS mode because this tag was only needed before Golang versions1.24.x.GODEBUG=tlsmlkem=0environment variable when running FIPS140-only unit tests. This prevents errors like so:Failed to connect: crypto/ecdh: use of X25519 is not allowed in FIPS 140-only mode.