Skip to content

[EuiDataGrid] Remove pointer-events: none on header actions #9177

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mgadewoll merged 2 commits into from
Nov 5, 2025
Merged

[EuiDataGrid] Remove pointer-events: none on header actions #9177

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
89c214f
refactor: remove pointer-events
mgadewoll Nov 5, 2025
6f1253b
test: increase wait before clicking action button
mgadewoll Nov 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion packages/eui/src/components/datagrid/body/header/data_grid_header_cell.styles.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,6 @@ export const euiDataGridHeaderCellStyles = (euiThemeContext: UseEuiTheme) => {
${logicalCSS('margin-left', margin)}
transform: translateX(${translateX}) scale(0.01);
opacity: 0;
pointer-events: none;
}
`;

Expand Down
8 changes: 5 additions & 3 deletions packages/eui/src/components/datagrid/body/header/draggable_columns.spec.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,8 @@ import React, { useState } from 'react';
import { EuiDataGrid, EuiDataGridProps } from '../../index';
import { EuiModal, EuiModalBody } from '../../../modal';

const WAIT_FOR_TRANSITION = 250;

describe('draggable columns', () => {
const columns = [
{ id: 'a', display: 'First' },
Expand Down Expand Up @@ -236,7 +238,7 @@ describe('draggable columns', () => {
cy.get('[data-popover-open]').should('not.exist');

// Should not interefere with column actions popover toggle
cy.wait(250);
cy.wait(WAIT_FOR_TRANSITION);
cy.get('[data-test-subj=dataGridHeaderCellActionButton-a]').realClick();
cy.get('[data-popover-open]').should('have.focus');
cy.get('[data-test-subj=dataGridHeaderCellActionButton-a]').realClick();
Expand All @@ -247,7 +249,7 @@ describe('draggable columns', () => {
cy.realMount(<StatefulDataGrid />);

cy.get('[data-test-subj=dataGridHeaderCell-a]').realHover();
cy.wait(50); // wait until actions button transition is progressed enough for the button to be clickable
cy.wait(WAIT_FOR_TRANSITION); // wait until actions button transition is progressed enough for the button to be clickable
cy.get('[data-test-subj=dataGridHeaderCellActionButton-a]').realClick();
cy.get('[data-popover-open]').should('have.focus');

Expand Down Expand Up @@ -297,7 +299,7 @@ describe('draggable columns', () => {
);

cy.get('[data-test-subj=dataGridHeaderCell-a]').realHover();
cy.wait(50); // wait until actions button transition is progressed enough for the button to be clickable
cy.wait(WAIT_FOR_TRANSITION); // wait until actions button transition is progressed enough for the button to be clickable
cy.get('[data-test-subj=dataGridHeaderCellActionButton-a]').realClick();
cy.get('[data-popover-open]').should('have.focus');

Expand Down