Skip to content

Conversation

@mgadewoll
Copy link
Contributor

@mgadewoll mgadewoll commented Nov 5, 2025

Summary

This PR is a follow-up to #9166

It removes the previously added pointer-events: none, as this can interfere with tests that try to click the button element during transition.

Note

The tests on the original PR succeeded but tests on main after merge failed. 🤷‍♀️

Additionally the test increases and unifies the wait time before clicking the action button in draggable_columns.spec.tsx to ensure the button has had enough time to transition.

Why are we making this change?

🩹 Test robustness: Prevent flaky tests.

Screenshots #

Impact to users

🟢 Test related change only.

QA

  • CI passed
  • verify tests pass locally

General checklist

  • Browser QA
    • Checked in both light and dark modes
    • Checked in both MacOS and Windows high contrast modes
    • Checked in mobile
    • Checked in Chrome, Safari, Edge, and Firefox
    • Checked for accessibility including keyboard-only and screenreader modes
  • Docs site QA
  • Code quality checklist
  • Release checklist
    • A changelog entry exists and is marked appropriately
    • If applicable, added the breaking change issue label (and filled out the breaking change checklist)
    • If the changes unblock an issue in a different repo, smoke tested carefully (see Testing EUI features in Kibana ahead of time)
  • Designer checklist
    • If applicable, file an issue to update EUI's Figma library with any corresponding UI changes. (This is an internal repo, if you are external to Elastic, ask a maintainer to submit this request)

- prevent potential test issues when the button is not clickable while the button is transitioning
- transition changed, we need to give it more time to ensure the button is available
@mgadewoll mgadewoll self-assigned this Nov 5, 2025
@mgadewoll mgadewoll added the skip-changelog Use on PRs to skip changelog requirement (Don't delete - used for automation) label Nov 5, 2025
@elasticmachine
Copy link
Collaborator

💚 Build Succeeded

cc @mgadewoll

@elasticmachine
Copy link
Collaborator

💚 Build Succeeded

cc @mgadewoll

@mgadewoll mgadewoll marked this pull request as ready for review November 5, 2025 10:42
@mgadewoll mgadewoll requested a review from a team as a code owner November 5, 2025 10:42
Copy link
Member

@tkajtoch tkajtoch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good

@mgadewoll mgadewoll merged commit b7bfdf3 into elastic:main Nov 5, 2025
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

skip-changelog Use on PRs to skip changelog requirement (Don't delete - used for automation)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants