Skip to content

[Flyout System] Remove isOpen prop #9083

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tkajtoch merged 3 commits into from
Oct 12, 2025
Merged

[Flyout System] Remove isOpen prop #9083

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a8d9021
WIP
tkajtoch Oct 6, 2025
bfaf51b
feat(EuiFlyout): remove `isOpen` usages
tkajtoch Oct 6, 2025
a9cbb70
test(EuiFlyout): remove `euiFlyout--open` class name from snapshots
tkajtoch Oct 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 9 additions & 9 deletions packages/eui/src/components/collapsible_nav/__snapshots__/collapsible_nav.test.tsx.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ exports[`EuiCollapsibleNav close button can be hidden 1`] = `
<nav
aria-describedby="generated-id"
aria-modal="true"
class="euiFlyout euiFlyout--open euiCollapsibleNav emotion-euiFlyout-none-noMaxWidth-overlay-left-left-euiCollapsibleNav-overlay"
class="euiFlyout euiCollapsibleNav emotion-euiFlyout-none-noMaxWidth-overlay-left-left-euiCollapsibleNav-overlay"
data-autofocus="true"
id="id"
role="dialog"
Expand Down Expand Up @@ -69,7 +69,7 @@ exports[`EuiCollapsibleNav is rendered 1`] = `
aria-describedby="generated-id"
aria-label="aria-label"
aria-modal="true"
class="euiFlyout euiFlyout--open euiCollapsibleNav testClass1 testClass2 emotion-euiFlyout-none-noMaxWidth-overlay-left-left-euiCollapsibleNav-overlay-euiTestCss"
class="euiFlyout euiCollapsibleNav testClass1 testClass2 emotion-euiFlyout-none-noMaxWidth-overlay-left-left-euiCollapsibleNav-overlay-euiTestCss"
data-autofocus="true"
data-test-subj="test subject string"
id="id"
Expand Down Expand Up @@ -122,7 +122,7 @@ exports[`EuiCollapsibleNav props accepts EuiFlyout props 1`] = `
<nav
aria-describedby="generated-id"
aria-modal="true"
class="euiFlyout euiFlyout--open euiCollapsibleNav emotion-euiFlyout-none-noMaxWidth-overlay-left-left-euiCollapsibleNav-overlay"
class="euiFlyout euiCollapsibleNav emotion-euiFlyout-none-noMaxWidth-overlay-left-left-euiCollapsibleNav-overlay"
data-autofocus="true"
id="id"
role="dialog"
Expand Down Expand Up @@ -179,7 +179,7 @@ exports[`EuiCollapsibleNav props button 1`] = `
<nav
aria-describedby="generated-id"
aria-modal="true"
class="euiFlyout euiFlyout--open euiCollapsibleNav emotion-euiFlyout-none-noMaxWidth-overlay-left-left-euiCollapsibleNav-overlay"
class="euiFlyout euiCollapsibleNav emotion-euiFlyout-none-noMaxWidth-overlay-left-left-euiCollapsibleNav-overlay"
data-autofocus="true"
id="id"
role="dialog"
Expand Down Expand Up @@ -231,7 +231,7 @@ exports[`EuiCollapsibleNav props dockedBreakpoint 1`] = `
<nav
aria-describedby="generated-id"
aria-modal="true"
class="euiFlyout euiFlyout--open euiCollapsibleNav emotion-euiFlyout-none-noMaxWidth-overlay-left-left-euiCollapsibleNav-overlay"
class="euiFlyout euiCollapsibleNav emotion-euiFlyout-none-noMaxWidth-overlay-left-left-euiCollapsibleNav-overlay"
data-autofocus="true"
id="id"
role="dialog"
Expand Down Expand Up @@ -280,7 +280,7 @@ exports[`EuiCollapsibleNav props isDocked 1`] = `
data-focus-lock-disabled="disabled"
>
<nav
class="euiFlyout euiFlyout--open euiCollapsibleNav emotion-euiFlyout-none-noMaxWidth-push-left-noAnimation-left-euiCollapsibleNav-push"
class="euiFlyout euiCollapsibleNav emotion-euiFlyout-none-noMaxWidth-push-left-noAnimation-left-euiCollapsibleNav-push"
id="id"
style="inline-size: 320px;"
/>
Expand All @@ -307,7 +307,7 @@ exports[`EuiCollapsibleNav props onClose 1`] = `
<nav
aria-describedby="generated-id"
aria-modal="true"
class="euiFlyout euiFlyout--open euiCollapsibleNav emotion-euiFlyout-none-noMaxWidth-overlay-left-left-euiCollapsibleNav-overlay"
class="euiFlyout euiCollapsibleNav emotion-euiFlyout-none-noMaxWidth-overlay-left-left-euiCollapsibleNav-overlay"
data-autofocus="true"
id="id"
role="dialog"
Expand Down Expand Up @@ -361,7 +361,7 @@ exports[`EuiCollapsibleNav props showButtonIfDocked 1`] = `
data-focus-lock-disabled="disabled"
>
<nav
class="euiFlyout euiFlyout--open euiCollapsibleNav emotion-euiFlyout-none-noMaxWidth-push-left-noAnimation-left-euiCollapsibleNav-push"
class="euiFlyout euiCollapsibleNav emotion-euiFlyout-none-noMaxWidth-push-left-noAnimation-left-euiCollapsibleNav-push"
id="id"
style="inline-size: 320px;"
/>
Expand All @@ -388,7 +388,7 @@ exports[`EuiCollapsibleNav props size 1`] = `
<nav
aria-describedby="generated-id"
aria-modal="true"
class="euiFlyout euiFlyout--open euiCollapsibleNav emotion-euiFlyout-none-noMaxWidth-overlay-left-left-euiCollapsibleNav-overlay"
class="euiFlyout euiCollapsibleNav emotion-euiFlyout-none-noMaxWidth-overlay-left-left-euiCollapsibleNav-overlay"
data-autofocus="true"
id="id"
role="dialog"
Expand Down
4 changes: 2 additions & 2 deletions .../eui/src/components/collapsible_nav_beta/__snapshots__/collapsible_nav_beta.test.tsx.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ exports[`EuiCollapsibleNavBeta renders 1`] = `
>
<nav
aria-label="aria-label"
class="euiFlyout euiFlyout--open euiCollapsibleNav euiCollapsibleNavBeta testClass1 testClass2 emotion-euiFlyout-none-noMaxWidth-push-left-noAnimation-left-euiCollapsibleNavBeta-left-isPush-euiTestCss"
class="euiFlyout euiCollapsibleNav euiCollapsibleNavBeta testClass1 testClass2 emotion-euiFlyout-none-noMaxWidth-push-left-noAnimation-left-euiCollapsibleNavBeta-left-isPush-euiTestCss"
data-test-subj="nav"
id="generated-id_euiCollapsibleNav"
style="inline-size: 248px;"
Expand Down Expand Up @@ -89,7 +89,7 @@ exports[`EuiCollapsibleNavBeta renders initialIsCollapsed 1`] = `
>
<nav
aria-label="Site menu"
class="euiFlyout euiFlyout--open euiCollapsibleNav euiCollapsibleNavBeta emotion-euiFlyout-none-noMaxWidth-push-left-noAnimation-left-euiCollapsibleNavBeta-left-isPush-isPushCollapsed"
class="euiFlyout euiCollapsibleNav euiCollapsibleNavBeta emotion-euiFlyout-none-noMaxWidth-push-left-noAnimation-left-euiCollapsibleNavBeta-left-isPush-isPushCollapsed"
data-test-subj="nav"
id="generated-id_euiCollapsibleNav"
style="inline-size: 48px;"
Expand Down
50 changes: 25 additions & 25 deletions packages/eui/src/components/flyout/__snapshots__/flyout.test.tsx.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ exports[`EuiFlyout is rendered 1`] = `
aria-describedby="generated-id"
aria-label="aria-label"
aria-modal="true"
class="euiFlyout euiFlyout--open testClass1 testClass2 emotion-euiFlyout-l-m-noMaxWidth-overlay-right-right-euiTestCss"
class="euiFlyout testClass1 testClass2 emotion-euiFlyout-l-m-noMaxWidth-overlay-right-right-euiTestCss"
data-autofocus="true"
data-test-subj="test subject string"
role="dialog"
Expand Down Expand Up @@ -73,7 +73,7 @@ exports[`EuiFlyout props accepts div props 1`] = `
<div
aria-describedby="generated-id"
aria-modal="true"
class="euiFlyout euiFlyout--open emotion-euiFlyout-l-m-noMaxWidth-overlay-right-right"
class="euiFlyout emotion-euiFlyout-l-m-noMaxWidth-overlay-right-right"
data-autofocus="true"
id="imaflyout"
role="dialog"
Expand Down Expand Up @@ -128,7 +128,7 @@ exports[`EuiFlyout props closeButtonPosition can be outside 1`] = `
<div
aria-describedby="generated-id"
aria-modal="true"
class="euiFlyout euiFlyout--open emotion-euiFlyout-l-m-noMaxWidth-overlay-right-right"
class="euiFlyout emotion-euiFlyout-l-m-noMaxWidth-overlay-right-right"
data-autofocus="true"
role="dialog"
tabindex="0"
Expand Down Expand Up @@ -182,7 +182,7 @@ exports[`EuiFlyout props closeButtonProps 1`] = `
<div
aria-describedby="generated-id"
aria-modal="true"
class="euiFlyout euiFlyout--open emotion-euiFlyout-l-m-noMaxWidth-overlay-right-right"
class="euiFlyout emotion-euiFlyout-l-m-noMaxWidth-overlay-right-right"
data-autofocus="true"
role="dialog"
tabindex="0"
Expand Down Expand Up @@ -236,7 +236,7 @@ exports[`EuiFlyout props hideCloseButton 1`] = `
<div
aria-describedby="generated-id"
aria-modal="true"
class="euiFlyout euiFlyout--open emotion-euiFlyout-l-m-noMaxWidth-overlay-right-right"
class="euiFlyout emotion-euiFlyout-l-m-noMaxWidth-overlay-right-right"
data-autofocus="true"
role="dialog"
tabindex="0"
Expand Down Expand Up @@ -278,7 +278,7 @@ exports[`EuiFlyout props is rendered as nav 1`] = `
<nav
aria-describedby="generated-id"
aria-modal="true"
class="euiFlyout euiFlyout--open emotion-euiFlyout-l-m-noMaxWidth-overlay-right-right"
class="euiFlyout emotion-euiFlyout-l-m-noMaxWidth-overlay-right-right"
data-autofocus="true"
role="dialog"
tabindex="0"
Expand Down Expand Up @@ -333,7 +333,7 @@ exports[`EuiFlyout props maxWidth can be set to a custom number 1`] = `
<div
aria-describedby="generated-id"
aria-modal="true"
class="euiFlyout euiFlyout--open emotion-euiFlyout-l-m-overlay-right-right"
class="euiFlyout emotion-euiFlyout-l-m-overlay-right-right"
data-autofocus="true"
role="dialog"
style="max-inline-size: 1024px;"
Expand Down Expand Up @@ -389,7 +389,7 @@ exports[`EuiFlyout props maxWidth can be set to a custom value and measurement 1
<div
aria-describedby="generated-id"
aria-modal="true"
class="euiFlyout euiFlyout--open emotion-euiFlyout-l-m-overlay-right-right"
class="euiFlyout emotion-euiFlyout-l-m-overlay-right-right"
data-autofocus="true"
role="dialog"
style="max-inline-size: 24rem;"
Expand Down Expand Up @@ -445,7 +445,7 @@ exports[`EuiFlyout props maxWidth can be set to a default 1`] = `
<div
aria-describedby="generated-id"
aria-modal="true"
class="euiFlyout euiFlyout--open emotion-euiFlyout-l-m-overlay-right-right"
class="euiFlyout emotion-euiFlyout-l-m-overlay-right-right"
data-autofocus="true"
role="dialog"
tabindex="0"
Expand Down Expand Up @@ -500,7 +500,7 @@ exports[`EuiFlyout props outsideClickCloses 1`] = `
<div
aria-describedby="generated-id"
aria-modal="true"
class="euiFlyout euiFlyout--open emotion-euiFlyout-l-m-noMaxWidth-overlay-right-right"
class="euiFlyout emotion-euiFlyout-l-m-noMaxWidth-overlay-right-right"
data-autofocus="true"
role="dialog"
tabindex="0"
Expand Down Expand Up @@ -555,7 +555,7 @@ exports[`EuiFlyout props ownFocus can alter mask props with maskProps without th
<div
aria-describedby="generated-id"
aria-modal="true"
class="euiFlyout euiFlyout--open emotion-euiFlyout-l-m-noMaxWidth-overlay-right-right"
class="euiFlyout emotion-euiFlyout-l-m-noMaxWidth-overlay-right-right"
data-autofocus="true"
role="dialog"
tabindex="0"
Expand Down Expand Up @@ -610,7 +610,7 @@ exports[`EuiFlyout props ownFocus can be false 1`] = `
<div
aria-describedby="generated-id"
aria-modal="true"
class="euiFlyout euiFlyout--open emotion-euiFlyout-l-m-noMaxWidth-overlay-right-right"
class="euiFlyout emotion-euiFlyout-l-m-noMaxWidth-overlay-right-right"
data-autofocus="true"
role="dialog"
tabindex="0"
Expand Down Expand Up @@ -665,7 +665,7 @@ exports[`EuiFlyout props paddingSize l is rendered 1`] = `
<div
aria-describedby="generated-id"
aria-modal="true"
class="euiFlyout euiFlyout--open emotion-euiFlyout-l-m-noMaxWidth-overlay-right-right"
class="euiFlyout emotion-euiFlyout-l-m-noMaxWidth-overlay-right-right"
data-autofocus="true"
role="dialog"
tabindex="0"
Expand Down Expand Up @@ -720,7 +720,7 @@ exports[`EuiFlyout props paddingSize m is rendered 1`] = `
<div
aria-describedby="generated-id"
aria-modal="true"
class="euiFlyout euiFlyout--open emotion-euiFlyout-m-m-noMaxWidth-overlay-right-right"
class="euiFlyout emotion-euiFlyout-m-m-noMaxWidth-overlay-right-right"
data-autofocus="true"
role="dialog"
tabindex="0"
Expand Down Expand Up @@ -775,7 +775,7 @@ exports[`EuiFlyout props paddingSize none is rendered 1`] = `
<div
aria-describedby="generated-id"
aria-modal="true"
class="euiFlyout euiFlyout--open emotion-euiFlyout-none-m-noMaxWidth-overlay-right-right"
class="euiFlyout emotion-euiFlyout-none-m-noMaxWidth-overlay-right-right"
data-autofocus="true"
role="dialog"
tabindex="0"
Expand Down Expand Up @@ -830,7 +830,7 @@ exports[`EuiFlyout props paddingSize s is rendered 1`] = `
<div
aria-describedby="generated-id"
aria-modal="true"
class="euiFlyout euiFlyout--open emotion-euiFlyout-s-m-noMaxWidth-overlay-right-right"
class="euiFlyout emotion-euiFlyout-s-m-noMaxWidth-overlay-right-right"
data-autofocus="true"
role="dialog"
tabindex="0"
Expand Down Expand Up @@ -869,7 +869,7 @@ exports[`EuiFlyout props paddingSize s is rendered 1`] = `

exports[`EuiFlyout props push flyouts renders 1`] = `
<div
class="euiFlyout euiFlyout--open emotion-euiFlyout-l-m-noMaxWidth-push-right-noAnimation-right"
class="euiFlyout emotion-euiFlyout-l-m-noMaxWidth-push-right-noAnimation-right"
data-test-subj="flyout"
>
<button
Expand Down Expand Up @@ -905,7 +905,7 @@ exports[`EuiFlyout props sides left is rendered 1`] = `
<div
aria-describedby="generated-id"
aria-modal="true"
class="euiFlyout euiFlyout--open emotion-euiFlyout-l-m-noMaxWidth-overlay-left-left"
class="euiFlyout emotion-euiFlyout-l-m-noMaxWidth-overlay-left-left"
data-autofocus="true"
role="dialog"
tabindex="0"
Expand Down Expand Up @@ -959,7 +959,7 @@ exports[`EuiFlyout props sides right is rendered 1`] = `
<div
aria-describedby="generated-id"
aria-modal="true"
class="euiFlyout euiFlyout--open emotion-euiFlyout-l-m-noMaxWidth-overlay-right-right"
class="euiFlyout emotion-euiFlyout-l-m-noMaxWidth-overlay-right-right"
data-autofocus="true"
role="dialog"
tabindex="0"
Expand Down Expand Up @@ -1014,7 +1014,7 @@ exports[`EuiFlyout props size accepts custom number 1`] = `
<div
aria-describedby="generated-id"
aria-modal="true"
class="euiFlyout euiFlyout--open emotion-euiFlyout-l-noMaxWidth-overlay-right-right"
class="euiFlyout emotion-euiFlyout-l-noMaxWidth-overlay-right-right"
data-autofocus="true"
role="dialog"
style="inline-size: 500px;"
Expand Down Expand Up @@ -1070,7 +1070,7 @@ exports[`EuiFlyout props size fill is rendered 1`] = `
<div
aria-describedby="generated-id"
aria-modal="true"
class="euiFlyout euiFlyout--open emotion-euiFlyout-l-fill-noMaxWidth-overlay-right-right"
class="euiFlyout emotion-euiFlyout-l-fill-noMaxWidth-overlay-right-right"
data-autofocus="true"
role="dialog"
tabindex="0"
Expand Down Expand Up @@ -1125,7 +1125,7 @@ exports[`EuiFlyout props size l is rendered 1`] = `
<div
aria-describedby="generated-id"
aria-modal="true"
class="euiFlyout euiFlyout--open emotion-euiFlyout-l-l-noMaxWidth-overlay-right-right"
class="euiFlyout emotion-euiFlyout-l-l-noMaxWidth-overlay-right-right"
data-autofocus="true"
role="dialog"
tabindex="0"
Expand Down Expand Up @@ -1180,7 +1180,7 @@ exports[`EuiFlyout props size m is rendered 1`] = `
<div
aria-describedby="generated-id"
aria-modal="true"
class="euiFlyout euiFlyout--open emotion-euiFlyout-l-m-noMaxWidth-overlay-right-right"
class="euiFlyout emotion-euiFlyout-l-m-noMaxWidth-overlay-right-right"
data-autofocus="true"
role="dialog"
tabindex="0"
Expand Down Expand Up @@ -1235,7 +1235,7 @@ exports[`EuiFlyout props size s is rendered 1`] = `
<div
aria-describedby="generated-id"
aria-modal="true"
class="euiFlyout euiFlyout--open emotion-euiFlyout-l-s-noMaxWidth-overlay-right-right"
class="euiFlyout emotion-euiFlyout-l-s-noMaxWidth-overlay-right-right"
data-autofocus="true"
role="dialog"
tabindex="0"
Expand Down Expand Up @@ -1295,7 +1295,7 @@ exports[`EuiFlyout renders extra screen reader instructions when fixed EuiHeader
aria-describedby="generated-id"
aria-label="aria-label"
aria-modal="true"
class="euiFlyout euiFlyout--open testClass1 testClass2 emotion-euiFlyout-l-m-noMaxWidth-overlay-right-right-euiTestCss"
class="euiFlyout testClass1 testClass2 emotion-euiFlyout-l-m-noMaxWidth-overlay-right-right-euiTestCss"
data-autofocus="true"
data-test-subj="test subject string"
role="dialog"
Expand Down
Loading