Skip to content

Conversation

@tkajtoch
Copy link
Member

@tkajtoch tkajtoch commented Oct 7, 2025

Summary

Resolves #9065

This PR removes the recently added isOpen prop due to incompatibility with some of the flyout system features. The complexity of fixing the incompatibility ended up being more involving than just removing the supplementary prop I had previously decided would be worth having. We can still add the isOpen prop in the future if we decide it's worth it, but it's not related to the Flyout System project and can be safely omitted at this time.

Why are we making this change?

This work is part of the Flyout System project.

Impact to users

isOpen prop removal has no impact on users since it existed only temporarily in a feature branch.

QA

Regular flyouts

  • Open EuiFlyout -> Playground story and confirm that clicking the Toggle flyout button toggles the visibility of the flyout
    Note: Due to the removal of the isOpen prop, there's no closing animation. That's expected

Managed flyouts - playground

  • Open EuiFlyout -> Flyout Manager -> Playground
  • Click Open Main Flyout and confirm the flyout opens
  • Click Open child panel and confirm the child flyout opens to the left
  • Click Close Main Flyout and confirm that both flyouts close at the same time

Managed flyouts - Multi-session example

  • Open EuiFlyout -> Flyout Manager -> Multi-session example
  • Click Open Session A and confirm the flyout opens
  • Click Open child flyout
  • Click Open Session B and confirm the Session A - Main and Session A - Child flyouts disappear and Session B - Main shows up
  • Click Back and confirm it transitions to session A with Session A - Main and Session A - Child flyouts being visible

General checklist

  • Browser QA
    • Checked in both light and dark modes
    • Checked for accessibility including keyboard-only and screenreader modes
  • Code quality checklist

# Conflicts:
#	packages/eui/src/components/flyout/manager/flyout_manager.stories.tsx
#	packages/eui/src/components/flyout/manager/flyout_sessions.stories.tsx
@tkajtoch tkajtoch self-assigned this Oct 7, 2025
@tkajtoch tkajtoch force-pushed the feat/flyout-system-remove-is-open branch from e7124df to a9cbb70 Compare October 7, 2025 22:32
@elasticmachine
Copy link
Collaborator

💚 Build Succeeded

History

cc @tkajtoch

@elasticmachine
Copy link
Collaborator

💚 Build Succeeded

History

cc @tkajtoch

@tkajtoch tkajtoch marked this pull request as ready for review October 8, 2025 14:16
@tkajtoch tkajtoch requested a review from a team as a code owner October 8, 2025 14:16
Copy link
Member

@tsullivan tsullivan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! I love how this simplifies the implementation, results in better performance, and will keep animations consistent for all flyouts.

@tkajtoch tkajtoch merged commit ff3c788 into elastic:feat/flyout-system Oct 12, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants