Skip to content

Conversation

@mgadewoll
Copy link
Contributor

@mgadewoll mgadewoll commented Sep 30, 2025

Summary

Reverts #9049
Reverts #9057

We're reverting these two PRs due to concerns about the usage of component tokens for handling component prop changes for Borealis specific design changes.

Instead we should update the components as needed in Borealis. Amsterdam has been maintained up to this point but is not used anymore in main releases. It's solely used in 8.x versions of Kibana which are running on EUI version 104.0.0-amsterdam.0. Any further usage of Amsterdam would be via potential backports to that version.

We're looking at fully deprecating and removing Amsterdam in EUI to reduce the overhead in development caused by maintaining two themes in parallel.

@mgadewoll mgadewoll self-assigned this Sep 30, 2025
@mgadewoll mgadewoll added the skip-changelog Use on PRs to skip changelog requirement (Don't delete - used for automation) label Sep 30, 2025
@mgadewoll mgadewoll changed the title Revert "Reduce EuiPageHeader tabs sizes for Borealis theme" Revert "Reduce EuiPageHeader tabs sizes for Borealis theme" and "Add EuiEmptyPrompt theme component tokens for spacing overrides" Sep 30, 2025
@elasticmachine
Copy link
Collaborator

💚 Build Succeeded

History

cc @mgadewoll

@elasticmachine
Copy link
Collaborator

💚 Build Succeeded

cc @mgadewoll

@mgadewoll mgadewoll marked this pull request as ready for review September 30, 2025 16:29
@mgadewoll mgadewoll requested a review from a team as a code owner September 30, 2025 16:29
Copy link
Contributor

@weronikaolejniczak weronikaolejniczak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🟢 Thank you for being alert!

@mgadewoll mgadewoll merged commit c9cd71d into main Oct 1, 2025
6 checks passed
@mgadewoll mgadewoll deleted the revert-9049-rk/page-header-tab-size branch October 1, 2025 15:45
tsullivan pushed a commit that referenced this pull request Oct 15, 2025
…d EuiEmptyPrompt theme component tokens for spacing overrides" (#9069)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

skip-changelog Use on PRs to skip changelog requirement (Don't delete - used for automation)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants