Add EuiEmptyPrompt theme component tokens for spacing overrides
#9057
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
13 tasks
- Decrease title-to-body spacing from 'm' to 's' (16px → 8px) - Decrease body-to-actions spacing from 'l' to 'm' (24px → 16px) - Decrease default padding from 'l' to 'm' (24px → 16px) - Create _spacing.ts file following established theme patterns - Extend EuiThemeShape to include custom spacing property - Update both light and dark Borealis theme JSON files - Modify EuiEmptyPrompt to use theme-based spacing values - Update snapshot tests to reflect new spacing values - Amsterdam theme remains unchanged Addresses #9039
- Update .loki reference images to reflect reduced spacing in Borealis theme - Add changelog entry for emptyPrompt spacing theme defaults
- Add emptyPrompt to _EuiThemeComponents type definition - Create _EuiThemeEmptyPrompt type and component token definitions - Update Borealis theme to use component tokens instead of custom spacing property - Update EuiEmptyPrompt to use euiTheme.components.emptyPrompt with proper TypeScript types - Add emptyPrompt component tokens to Amsterdam theme with default values - Remove custom spacing property and _spacing.ts file - Update changelog to reflect component tokens approach This follows the established pattern of euiTheme.components.* tokens and provides better type safety and discoverability.
- Update PNG snapshots to reflect reduced spacing in Borealis theme - EuiEmptyPrompt spacing changes from (m, l, l) to (s, m, m) - Includes both desktop and mobile view updates - Covers High Contrast, Transparent, Page Template, and Playground variants
ryankeairns
force-pushed
the
rk/9039-empty-prompt-spacing-component-tokens
branch
from
c708bb7 to
5effc1d
Compare
- Update changelog file names to match new PR number - Rename both Borealis theme and EUI changelog files
13 tasks
weronikaolejniczak
requested changes
Sep 25, 2025
Contributor
weronikaolejniczak
left a comment
weronikaolejniczak
left a comment
There was a problem hiding this comment.
Just a couple of comments. Thanks for updating the VRT images 🙌🏻
I verified that for Amsterdam, EuiEmptyPrompt remains the same 😄
- Add missing changelog entry for eui-theme-common package - Fix changelog formatting with proper bullet points and newlines - Specify the actual component tokens added (titleBodySpacing, bodyActionsSpacing, paddingSize) - Correct EUI changelog to reference component tokens instead of emptyPromptSpacing
- Add missing changelog entry for eui-theme-common package - Fix changelog formatting with proper bullet points and newlines - Specify the actual component tokens added (titleBodySpacing, bodyActionsSpacing, paddingSize)
Contributor
Author
|
CHANGELOGESES updated! |
Collaborator
💚 Build SucceededHistory
|
Collaborator
💚 Build Succeeded
History
|
weronikaolejniczak
approved these changes
Sep 26, 2025
Contributor
weronikaolejniczak
left a comment
weronikaolejniczak
left a comment
There was a problem hiding this comment.
✅ snapshots updated
✅ VRT images updated
✅ changelogses in all the packages: eui, eui-theme-common, eui-theme-borealis
✅ the change doesn't affect Amsterdam
✅ code looks okay
Thanks for contributing, Ryan! 🟢 We're good to go!
I also got an idea to use our componentDefaults for this. But this is just fine and I don't want to block it anymore.
ryankeairns
deleted the
rk/9039-empty-prompt-spacing-component-tokens
branch
tsullivan
pushed a commit
that referenced
this pull request
Oct 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR implements component tokens for
EuiEmptyPromptspacing configuration, following the establishedeuiTheme.components.*pattern.Changes
_EuiThemeEmptyPrompttype and added to_EuiThemeComponentsemptyPromptspacing configuration to both Amsterdam and Borealis themesspacingproperty toeuiTheme.components.emptyPromptwith proper TypeScript typestitleBodySpacing: 's',bodyActionsSpacing: 'm',paddingSize: 'm')titleBodySpacing: 'm',bodyActionsSpacing: 'l',paddingSize: 'l')spacingproperty and_spacing.tsfileAmsterdam theme remains unchanged
Screenshots
Borealis before (left) and after (right)
Amsterdam before and after (unchanged)
QA
Remove or strikethrough items that do not apply to your PR.
General checklist
@defaultif default values are missing) and playground toggles