Skip to content

Conversation

@mgadewoll
Copy link
Contributor

@mgadewoll mgadewoll commented Jan 8, 2025

Summary

We noticed that there seems to have been some typos in the borderStrong SCSS tokens 🫠
This causes the variables to not actually be available for use.

Changes

  • renames SCSS borderStrong tokens for Borealis dark
  • adds missing !default flag (since we're here 🤷‍♀️)

QA

  • verify the tokens are available:

    • checkout this PR
    • use the border tokens, e.g. $euiColorBorderStrongSuccess in our EUI docs, e.g. in packages/eui/src-docs/src/views/home/_home.scss to add a background color somewhere
    // example
    .guideSideNav {
      background-color: $euiColorBorderStrongSuccess !important;
    }

Screenshot 2025-01-08 at 17 37 11

@mgadewoll mgadewoll added the skip-changelog Use on PRs to skip changelog requirement (Don't delete - used for automation) label Jan 8, 2025
@mgadewoll mgadewoll self-assigned this Jan 8, 2025
@kibanamachine
Copy link

Preview staging links for this PR:

@elasticmachine
Copy link
Collaborator

💚 Build Succeeded

History

cc @mgadewoll

@mgadewoll mgadewoll marked this pull request as ready for review January 9, 2025 09:59
@mgadewoll mgadewoll requested a review from a team as a code owner January 9, 2025 09:59
Copy link
Contributor

@weronikaolejniczak weronikaolejniczak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍🏻

I ran the docs website and verified that the new tokens (euiColorBorderStrongPrimary, euiColorBorderStrongAccent etc are available) both in Borealis and Amsterdam.

@mgadewoll mgadewoll merged commit b9c74a0 into elastic:eui-theme/borealis Jan 9, 2025
7 checks passed
mgadewoll added a commit to mgadewoll/eui that referenced this pull request Jan 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

skip-changelog Use on PRs to skip changelog requirement (Don't delete - used for automation) visual refresh

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants