[Lens] Align Lens style with Borealis#204839
Merged
markov00 merged 18 commits intoelastic:mainfrom Jan 9, 2025
Merged
Conversation
markov00
added
Team:Visualizations
mgadewoll
reviewed
Dec 19, 2024
Contributor
mgadewoll
left a comment
mgadewoll
left a comment
There was a problem hiding this comment.
ℹ️ Adding an early review due to upcoming PTO.
...es/kbn-coloring/src/shared_components/color_mapping/components/color_picker/color_picker.tsx
Outdated
Show resolved
Hide resolved
.../kbn-coloring/src/shared_components/color_mapping/components/color_picker/palette_colors.tsx
Outdated
Show resolved
Hide resolved
packages/kbn-visualization-ui-components/components/dimension_buttons/dimension_button.tsx
Outdated
Show resolved
Hide resolved
.../lens/public/datasources/form_based/operations/definitions/formula/editor/formula_editor.tsx
Outdated
Show resolved
Hide resolved
x-pack/plugins/lens/public/editor_frame_service/editor_frame/config_panel/layer_panel.tsx
Outdated
Show resolved
Hide resolved
Contributor
|
Pinging @elastic/kibana-visualizations (Team:Visualizations) |
dej611
approved these changes
Jan 8, 2025
Contributor
dej611
left a comment
dej611
left a comment
There was a problem hiding this comment.
Checked locally and works fine.
It matches all the requested changes.
no fontsize change applied
markov00
force-pushed
the
2024_12_16-align_borealis
branch
from
fd3ebde to
3192c14
Compare
Contributor
MichaelMarcialis
left a comment
MichaelMarcialis
left a comment
There was a problem hiding this comment.
Thanks for putting this together, @markov00. It looks great. I left a few small comments below. Once those are addressed, I think this is good to go.
.../kbn-coloring/src/shared_components/color_mapping/components/color_picker/palette_colors.tsx
Outdated
Show resolved
Hide resolved
.../kbn-coloring/src/shared_components/color_mapping/components/color_picker/palette_colors.tsx
Outdated
Show resolved
Hide resolved
src/platform/packages/shared/kbn-dom-drag-drop/src/sass/drag_drop_mixins.scss
Outdated
Show resolved
Hide resolved
src/platform/packages/shared/kbn-dom-drag-drop/src/sass/drag_drop_mixins.scss
Outdated
Show resolved
Hide resolved
src/platform/packages/shared/kbn-dom-drag-drop/src/sass/droppable.scss
Outdated
Show resolved
Hide resolved
src/platform/packages/shared/kbn-dom-drag-drop/src/sass/drag_drop_mixins.scss
Outdated
Show resolved
Hide resolved
src/platform/packages/shared/kbn-dom-drag-drop/src/sass/drag_drop_mixins.scss
Outdated
Show resolved
Hide resolved
src/platform/packages/shared/kbn-dom-drag-drop/src/sass/droppable.scss
Outdated
Show resolved
Hide resolved
src/platform/packages/shared/kbn-dom-drag-drop/src/sass/droppable.scss
Outdated
Show resolved
Hide resolved
MichaelMarcialis
approved these changes
Jan 9, 2025
Contributor
MichaelMarcialis
left a comment
MichaelMarcialis
left a comment
There was a problem hiding this comment.
Looks great. Thanks for making those changes, @markov00!
Contributor
💛 Build succeeded, but was flaky
Failed CI StepsTest Failures
Metrics [docs]Async chunks
Unknown metric groupsESLint disabled line counts
Total ESLint disabled count
History
|
Zacqary
pushed a commit
to Zacqary/kibana
that referenced
this pull request
Jan 9, 2025
## Summary This PR updates the style of Lens to align it with the new Borealis theme. It covers the set of tasks in elastic#203050 within the `Lens editor panels` list. Comments are applied in order as in the mentioned issue --------- Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
viduni94
pushed a commit
to viduni94/kibana
that referenced
this pull request
Jan 23, 2025
## Summary This PR updates the style of Lens to align it with the new Borealis theme. It covers the set of tasks in elastic#203050 within the `Lens editor panels` list. Comments are applied in order as in the mentioned issue --------- Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR updates the style of Lens to align it with the new Borealis theme.
It covers the set of tasks in #203050 within the
Lens editor panelslist.Comments are applied in order as in the mentioned issue