Docs(EuiDataGrid): fix disabled draggable columns examples #8229
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mgadewoll
added
the
skip-changelog
mgadewoll
force-pushed
the
datagrid/update-draggable-columns-docs
branch
from
72bff84 to
cff1f95
Compare
Comment on lines
369
to
371
| To reorder columns directly instead of via the actions menu popover, you can enable draggable EuiDataGrid header columns via the `columnVisibility.canDragAndDropColumns` prop. | ||
|
|
||
| This will allow you to reorder the column by dragging them. |
Contributor
There was a problem hiding this comment.
Nit-pick:
Suggested change
| To reorder columns directly instead of via the actions menu popover, you can enable draggable EuiDataGrid header columns via the `columnVisibility.canDragAndDropColumns` prop. | |
| This will allow you to reorder the column by dragging them. | |
| You can enable draggable `EuiDataGrid` header columns with the `columnVisibility.canDragAndDropColumns` prop to reorder columns by dragging, instead of using the actions menu. |
Contributor
Author
There was a problem hiding this comment.
Yeah, I just copied there from EUI docs 😄
Updated for both EUI and EUI+ docs (commit).
Contributor
|
Just a lil nit-pick, I think we could improve the phrasing. Tested both in the old and new docs ✅ |
Contributor
|
I also fixed this in #8183, not sure if we'd want to wait for that PR to land. Planning on addressing feedback on it today 🙏 |
Contributor
Author
@cee-chen Ah, I did not realize it was already addressed. I merely noticed it on the EuiDataGrid high contrast mode PR today 😄 I'm fine to close this PR if it's already handled 👍 |
|
Preview staging links for this PR:
|
Collaborator
💚 Build Succeeded
History
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes the docs examples for draggable EuiDatagrid columns as they were missing the prop
columnVisibility.canDragAndDropColumnsto be enabled 🤷♀️This additionally adds the missing draggable columns example to the EUI+ docs.
QA