Skip to content

Conversation

@cee-chen
Copy link
Contributor

@cee-chen cee-chen commented Nov 23, 2024

Summary

#8163

I apologize in advance for how large this PR/diff is - this PR really got away from me, for which I wholly blame datagrid 🥲

Honestly, I would probably suggest skipping code review for this one and just reviewing the end-user docs directly compared to previous iterations.

Before After

I'm definitely looking for feedback on anything that's obviously broken in terms of functionality, or any copy/organization that feels straight up not-understandable, but as a heads up I'm likely not going to want a whole ton of large refactoring on this PR since I don't have much more time at Elastic - I'd like to get this in as before too long (given that it doesn't flagrantly break anything in prod) and continue to iterate in the future as needed.

QA

General checklist

N/A, docs only

@cee-chen cee-chen added documentation Issues or PRs that only affect documentation - will not need changelog entries skip-changelog Use on PRs to skip changelog requirement (Don't delete - used for automation) labels Nov 23, 2024
@cee-chen cee-chen force-pushed the website/reorg-3 branch 2 times, most recently from 489e468 to 1372f28 Compare November 25, 2024 16:39
@cee-chen cee-chen force-pushed the website/reorg-3 branch 3 times, most recently from 0d2a303 to bbbc124 Compare December 6, 2024 08:04
@cee-chen cee-chen marked this pull request as ready for review December 6, 2024 08:04
@cee-chen cee-chen requested a review from a team as a code owner December 6, 2024 08:04
@weronikaolejniczak
Copy link
Contributor

Incredible changes, Cee! 🥳 🎉 Both of these categories felt messy and unintuitive, now it's easy to navigate around and the information is more granular.

I still went over the code changes cause they're quite significant. I didn't find anything that would be a blocker for this PR though. I agree that we can improve later and it'd feel wasteful for you to refactor this right now.

I tested the staging:

✅ no pages are missing
✅ no content is missing from the original pages
✅ pages follow logical order
✅ all the pages have correct slugs and <title>s
❌ some links don't work correctly (I don't mind fixing it later)

If you're busy with other things, I can push the changes to the PR and we'll have the suggestions sorted out already instead of leaving them for later. Let me know what you prefer 😄

@weronikaolejniczak
Copy link
Contributor

@tkajtoch @mgadewoll @acstll I would love it if all of you went over the changes and gave your thoughts 🙏🏻

@acstll I had to resolve conflicts, and so I accepted all current changes in /basic-tables but then applied your changes from this PR, could you check if everything's as it should be?

@acstll
Copy link
Contributor

acstll commented Feb 11, 2025

@acstll I had to resolve conflicts, and so I accepted all current changes in /basic-tables but then applied your changes from this PR, could you check if everything's as it should be?

@weronikaolejniczak according to 1be312e the changes look correct 👍

(I'm actually unsure about adding responsiveBreakpoint={false} everywhere as I did, I think it's needed, but maybe there's a better (or more detailed) solution. We can look at this in the upcoming EUI+ work)

Copy link
Contributor

@acstll acstll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@weronikaolejniczak I only found one small thing! — I actually followed Cee's suggestion and went over the code rather quickly and paid more attention to the actual site 🤓

other than that this LGTM

@weronikaolejniczak
Copy link
Contributor

buildkite test this

@weronikaolejniczak
Copy link
Contributor

buildkite test this

@kibanamachine
Copy link

Preview staging links for this PR:

@elasticmachine
Copy link
Collaborator

💚 Build Succeeded

History

cc @weronikaolejniczak

@weronikaolejniczak weronikaolejniczak merged commit ab68130 into elastic:main Feb 17, 2025
5 checks passed
@cee-chen cee-chen deleted the website/reorg-3 branch February 18, 2025 00:04
@cee-chen
Copy link
Contributor Author

Thanks for getting this merged y'all!! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Issues or PRs that only affect documentation - will not need changelog entries skip-changelog Use on PRs to skip changelog requirement (Don't delete - used for automation)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[EUI+] Reorganise the document pages

6 participants