-
Notifications
You must be signed in to change notification settings - Fork 861
[EUI+] Reorganize+improve markdown, tables, and data grid docs #8183
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
489e468 to
1372f28
Compare
0d2a303 to
bbbc124
Compare
bbbc124 to
0c35e41
Compare
packages/website/docs/components/editors_and_syntax/markdown/markdown_plugins.mdx
Outdated
Show resolved
Hide resolved
packages/website/docs/components/tabular_content/tables/overview.mdx
Outdated
Show resolved
Hide resolved
packages/website/docs/components/tabular_content/tables/in_memory_tables.mdx
Show resolved
Hide resolved
packages/website/docs/components/tabular_content/data_grid/data_grid_schema_and_columns.mdx
Show resolved
Hide resolved
packages/website/docs/components/tabular_content/data_grid/data_grid.mdx
Outdated
Show resolved
Hide resolved
packages/website/docs/components/tabular_content/data_grid/data_grid_cells_and_popovers.mdx
Show resolved
Hide resolved
packages/website/docs/components/tabular_content/data_grid/data_grid_toolbar.mdx
Show resolved
Hide resolved
packages/website/docs/components/tabular_content/data_grid/data_grid_style_and_display.mdx
Outdated
Show resolved
Hide resolved
packages/website/docs/components/tabular_content/data_grid/advanced/custom_grid_body.mdx
Show resolved
Hide resolved
packages/website/docs/components/tabular_content/data_grid/advanced/custom_grid_body.mdx
Show resolved
Hide resolved
packages/website/docs/components/tabular_content/data_grid/_category_.yml
Show resolved
Hide resolved
packages/website/docs/components/tabular_content/tables/basic_tables.mdx
Outdated
Show resolved
Hide resolved
packages/website/docs/components/tabular_content/tables/in_memory_tables.mdx
Outdated
Show resolved
Hide resolved
packages/website/docs/components/editors_and_syntax/markdown/markdown_editor.mdx
Show resolved
Hide resolved
packages/website/docs/components/editors_and_syntax/markdown/markdown_editor.mdx
Outdated
Show resolved
Hide resolved
packages/website/docs/components/editors_and_syntax/markdown/markdown_format.mdx
Outdated
Show resolved
Hide resolved
|
Incredible changes, Cee! 🥳 🎉 Both of these categories felt messy and unintuitive, now it's easy to navigate around and the information is more granular. I still went over the code changes cause they're quite significant. I didn't find anything that would be a blocker for this PR though. I agree that we can improve later and it'd feel wasteful for you to refactor this right now. I tested the staging: ✅ no pages are missing If you're busy with other things, I can push the changes to the PR and we'll have the suggestions sorted out already instead of leaving them for later. Let me know what you prefer 😄 |
|
@tkajtoch @mgadewoll @acstll I would love it if all of you went over the changes and gave your thoughts 🙏🏻 @acstll I had to resolve conflicts, and so I accepted all current changes in |
@weronikaolejniczak according to 1be312e the changes look correct 👍 (I'm actually unsure about adding |
acstll
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@weronikaolejniczak I only found one small thing! — I actually followed Cee's suggestion and went over the code rather quickly and paid more attention to the actual site 🤓
other than that this LGTM
...ocs/components/tabular_content/data_grid/advanced/custom_grid_body/custom_body_rendering.mdx
Show resolved
Hide resolved
|
buildkite test this |
|
buildkite test this |
|
Preview staging links for this PR:
|
💚 Build Succeeded
History
|
|
Thanks for getting this merged y'all!! 🎉 |
Summary
#8163
I apologize in advance for how large this PR/diff is - this PR really got away from me, for which I wholly blame datagrid 🥲
Honestly, I would probably suggest skipping code review for this one and just reviewing the end-user docs directly compared to previous iterations.
I'm definitely looking for feedback on anything that's obviously broken in terms of functionality, or any copy/organization that feels straight up not-understandable, but as a heads up I'm likely not going to want a whole ton of large refactoring on this PR since I don't have much more time at Elastic - I'd like to get this in as before too long (given that it doesn't flagrantly break anything in prod) and continue to iterate in the future as needed.
QA
General checklist
N/A, docs only