Skip to content

[EuiBreadcrumb] Fix styling on application types with popovers + perf improvements #7580

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cee-chen merged 5 commits into from
Mar 18, 2024
Merged

[EuiBreadcrumb] Fix styling on application types with popovers + perf improvements #7580

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
7b98e45
[perf] Memoize breadcrumb styles
cee-chen Mar 13, 2024
9ccbf1d
Fix broken `application` breadcrumb popover styles
cee-chen Mar 13, 2024
4df60c5
changelog
cee-chen Mar 13, 2024
501198a
changelog typo
cee-chen Mar 14, 2024
94d528b
[PR feedback] Split out new `_breadcrumb_content` file + move shared …
cee-chen Mar 14, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions changelogs/upcoming/7580.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
**Bug fixes**

- Fixed a visual bug with `EuiHeadersBreadcrumbs` with popovers
Comment thread
cee-chen marked this conversation as resolved.
Outdated
6 changes: 3 additions & 3 deletions src/components/breadcrumbs/__snapshots__/breadcrumb.test.tsx.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,17 +4,17 @@ exports[`EuiBreadcrumbContent breadcrumbs with popovers renders with \`popoverCo
<body>
<div>
<div
class="euiPopover euiPopover-isOpen emotion-euiPopover-inline-block-euiBreadcrumb__popoverWrapper"
class="euiPopover euiPopover-isOpen emotion-euiPopover-inline-block-euiBreadcrumb__popoverWrapper-page"
data-test-subj="popover"
>
<button
class="euiLink emotion-euiLink-subdued-euiBreadcrumb__popoverButton"
class="euiLink euiBreadcrumb__content emotion-euiLink-subdued-euiBreadcrumb__popoverButton-euiBreadcrumb__content-page"
data-test-subj="popoverToggle"
title="Toggles a popover - Clicking this button will toggle a popover dialog."
type="button"
>
<span
class="euiBreadcrumb__content emotion-euiBreadcrumb__content-page"
class="emotion-euiBreadcrumb__popoverTruncation"
>
Toggles a popover
</span>
Expand Down
36 changes: 18 additions & 18 deletions src/components/breadcrumbs/__snapshots__/breadcrumbs.test.tsx.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,15 +39,15 @@ exports[`EuiBreadcrumbs is rendered 1`] = `
data-test-subj="euiBreadcrumb"
>
<div
class="euiPopover emotion-euiPopover-inline-block-euiBreadcrumb__popoverWrapper"
class="euiPopover emotion-euiPopover-inline-block-euiBreadcrumb__popoverWrapper-page"
>
<button
class="euiLink emotion-euiLink-subdued-euiBreadcrumb__popoverButton"
class="euiLink euiBreadcrumb__content emotion-euiLink-subdued-euiBreadcrumb__popoverButton-euiBreadcrumb__content-page"
title="See collapsed breadcrumbs"
type="button"
>
<span
class="euiBreadcrumb__content emotion-euiBreadcrumb__content-page"
class="emotion-euiBreadcrumb__popoverTruncation"
>
<span
aria-label="See collapsed breadcrumbs"
Expand Down Expand Up @@ -143,15 +143,15 @@ exports[`EuiBreadcrumbs is rendered with final item as link 1`] = `
data-test-subj="euiBreadcrumb"
>
<div
class="euiPopover emotion-euiPopover-inline-block-euiBreadcrumb__popoverWrapper"
class="euiPopover emotion-euiPopover-inline-block-euiBreadcrumb__popoverWrapper-page"
>
<button
class="euiLink emotion-euiLink-subdued-euiBreadcrumb__popoverButton"
class="euiLink euiBreadcrumb__content emotion-euiLink-subdued-euiBreadcrumb__popoverButton-euiBreadcrumb__content-page"
title="See collapsed breadcrumbs"
type="button"
>
<span
class="euiBreadcrumb__content emotion-euiBreadcrumb__content-page"
class="emotion-euiBreadcrumb__popoverTruncation"
>
<span
aria-label="See collapsed breadcrumbs"
Expand Down Expand Up @@ -329,15 +329,15 @@ exports[`EuiBreadcrumbs props max renders 1 item 1`] = `
data-test-subj="euiBreadcrumb"
>
<div
class="euiPopover emotion-euiPopover-inline-block-euiBreadcrumb__popoverWrapper"
class="euiPopover emotion-euiPopover-inline-block-euiBreadcrumb__popoverWrapper-page"
>
<button
class="euiLink emotion-euiLink-subdued-euiBreadcrumb__popoverButton"
class="euiLink euiBreadcrumb__content emotion-euiLink-subdued-euiBreadcrumb__popoverButton-euiBreadcrumb__content-page"
title="See collapsed breadcrumbs"
type="button"
>
<span
class="euiBreadcrumb__content emotion-euiBreadcrumb__content-page"
class="emotion-euiBreadcrumb__popoverTruncation"
>
<span
aria-label="See collapsed breadcrumbs"
Expand Down Expand Up @@ -514,15 +514,15 @@ exports[`EuiBreadcrumbs props responsive is rendered 1`] = `
data-test-subj="euiBreadcrumb"
>
<div
class="euiPopover emotion-euiPopover-inline-block-euiBreadcrumb__popoverWrapper"
class="euiPopover emotion-euiPopover-inline-block-euiBreadcrumb__popoverWrapper-page"
>
<button
class="euiLink emotion-euiLink-subdued-euiBreadcrumb__popoverButton"
class="euiLink euiBreadcrumb__content emotion-euiLink-subdued-euiBreadcrumb__popoverButton-euiBreadcrumb__content-page"
title="See collapsed breadcrumbs"
type="button"
>
<span
class="euiBreadcrumb__content emotion-euiBreadcrumb__content-page"
class="emotion-euiBreadcrumb__popoverTruncation"
>
<span
aria-label="See collapsed breadcrumbs"
Expand Down Expand Up @@ -617,15 +617,15 @@ exports[`EuiBreadcrumbs props responsive is rendered as false 1`] = `
data-test-subj="euiBreadcrumb"
>
<div
class="euiPopover emotion-euiPopover-inline-block-euiBreadcrumb__popoverWrapper"
class="euiPopover emotion-euiPopover-inline-block-euiBreadcrumb__popoverWrapper-page"
>
<button
class="euiLink emotion-euiLink-subdued-euiBreadcrumb__popoverButton"
class="euiLink euiBreadcrumb__content emotion-euiLink-subdued-euiBreadcrumb__popoverButton-euiBreadcrumb__content-page"
title="See collapsed breadcrumbs"
type="button"
>
<span
class="euiBreadcrumb__content emotion-euiBreadcrumb__content-page"
class="emotion-euiBreadcrumb__popoverTruncation"
>
<span
aria-label="See collapsed breadcrumbs"
Expand Down Expand Up @@ -695,15 +695,15 @@ exports[`EuiBreadcrumbs props responsive is rendered with custom breakpoints 1`]
data-test-subj="euiBreadcrumb"
>
<div
class="euiPopover emotion-euiPopover-inline-block-euiBreadcrumb__popoverWrapper"
class="euiPopover emotion-euiPopover-inline-block-euiBreadcrumb__popoverWrapper-page"
>
<button
class="euiLink emotion-euiLink-subdued-euiBreadcrumb__popoverButton"
class="euiLink euiBreadcrumb__content emotion-euiLink-subdued-euiBreadcrumb__popoverButton-euiBreadcrumb__content-page"
title="See collapsed breadcrumbs"
type="button"
>
<span
class="euiBreadcrumb__content emotion-euiBreadcrumb__content-page"
class="emotion-euiBreadcrumb__popoverTruncation"
>
<span
aria-label="See collapsed breadcrumbs"
Expand Down
40 changes: 25 additions & 15 deletions src/components/breadcrumbs/breadcrumb.styles.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,6 +71,8 @@ export const euiBreadcrumbContentStyles = (euiThemeContext: UseEuiTheme) => {
text-align: center;
vertical-align: baseline;
`,

// Truncation styles
isTruncated: css`
${euiTextTruncate(mathWithUnits(euiTheme.size.base, (x) => x * 10))}
`,
Expand All @@ -80,21 +82,6 @@ export const euiBreadcrumbContentStyles = (euiThemeContext: UseEuiTheme) => {
${euiTextTruncate('none')}
`,

// Popover styles
euiBreadcrumb__popoverButton: css`
max-inline-size: 100%;
display: inline-flex;
align-items: center;
gap: ${euiTheme.size.xs};
`,
euiBreadcrumb__popoverWrapper: css`
/* At small container widths, the popover anchor needs to leave room for the breadcrumb separator,
which is weird to get an exact width for because it's transformed at an angle */
max-inline-size: calc(
100% - ${mathWithUnits(euiTheme.size.base, (x) => x + 1)}
);
`,

// Types
page: css`
&:is(a):focus {
Expand Down Expand Up @@ -173,3 +160,26 @@ export const euiBreadcrumbContentStyles = (euiThemeContext: UseEuiTheme) => {
},
};
};

export const euiBreadcrumbPopoverStyles = ({ euiTheme }: UseEuiTheme) => {
return {
euiBreadcrumb__popoverButton: css`
max-inline-size: 100%;
display: inline-flex;
align-items: center;
gap: ${euiTheme.size.xs};
`,
euiBreadcrumb__popoverTruncation: css``,
Comment thread
mgadewoll marked this conversation as resolved.
Outdated
popoverWrapper: {
euiBreadcrumb__popoverWrapper: css``,
page: css`
/* At small container widths, the popover anchor needs to leave room for the breadcrumb separator,
which is weird to get an exact width for because it's transformed at an angle */
max-inline-size: calc(
100% - ${mathWithUnits(euiTheme.size.base, (x) => x + 1)}
);
`,
application: null,
},
};
};
Loading