Skip to content

[EuiCollapsibleNavBeta] Fix accordion open animation bug #7317

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cee-chen merged 2 commits into from
Oct 27, 2023
Merged

[EuiCollapsibleNavBeta] Fix accordion open animation bug #7317

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ce8d040
Remove nav item to get reproduction case working
cee-chen Oct 25, 2023
a151815
Use CSS workaround to fix animation bug on open
cee-chen Oct 25, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion src/components/collapsible_nav_beta/collapsible_nav_beta.stories.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -177,7 +177,6 @@ export const KibanaExample: Story = {
{ title: 'Notifications', href: '#' },
],
},
{ title: 'Add data', href: '#' },
]),
]}
/>
Expand Down
13 changes: 11 additions & 2 deletions src/components/collapsible_nav_beta/collapsible_nav_item/collapsible_nav_accordion.styles.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,8 +73,17 @@ export const euiCollapsibleNavAccordionStyles = (
}
`,
isSubItem: css`
&.euiAccordion-isOpen {
${logicalCSS('margin-bottom', euiTheme.size.m)}
/* Adds extra spacing to the bottom of the accordion while open. Notes:
1. This uses a pseudo element instead of margin-bottom on the accordion,
because otherwise the height calculations the accordion uses will be off
and cause buggy animation behavior
2. Setting a margin or padding bottom on .euiAccordion__children does not
seem to work correctly and gets collapsed instead of stacking
*/
&.euiAccordion-isOpen .euiAccordion__children::after {
content: '';
display: block;
${logicalCSS('height', euiTheme.size.m)}
}
`,
// Arrow element
Expand Down