Skip to content

Conversation

@cee-chen
Copy link
Contributor

@cee-chen cee-chen commented Oct 25, 2023

Summary

⚠️ Quick note about this bug: it only occurs when toggling an EuiAccordion that's the last item in the items array.

Before After
Note the "Get started" item jumping on every open "Get started" item does not jump
before after

QA

General checklist

  • Browser QA
    • Checked in mobile
    • Checked in Chrome, Safari, Edge, and Firefox
      - [ ] Checked for accessibility including keyboard-only and screenreader modes
      - [ ] Checked in both light and dark modes
  • Docs site QA - N/A, beta component
  • Code quality checklist - N/A, CSS change
  • Release checklist - N/A, beta component
  • Designer checklist - N/A, beta component

- this bug only seems to happen when EuiAccordion is the last item the group
- the issue is that the `margin` isn't being accounted for when calculating the height, which is throwing off the open logic
@cee-chen cee-chen added the skip-changelog Use on PRs to skip changelog requirement (Don't delete - used for automation) label Oct 25, 2023
@cee-chen cee-chen marked this pull request as ready for review October 25, 2023 22:46
@cee-chen cee-chen requested a review from a team as a code owner October 25, 2023 22:46
@kibanamachine
Copy link

Preview staging links for this PR:

@elasticmachine
Copy link
Collaborator

💚 Build Succeeded

@cee-chen cee-chen merged commit 23d136c into elastic:main Oct 27, 2023
@cee-chen cee-chen deleted the collapsible-nav-beta/fix-open-bug branch October 27, 2023 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

skip-changelog Use on PRs to skip changelog requirement (Don't delete - used for automation)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants