[EuiAccordion] Remove will-change CSS
#6235
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_6235/ |
CoenWarmer
reviewed
Sep 14, 2022
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_6235/ |
chandlerprall
approved these changes
Sep 19, 2022
Contributor
chandlerprall
left a comment
chandlerprall
left a comment
There was a problem hiding this comment.
Change LGTM, tested the accordion examples across browsers and don't see any difference
…accordion" This reverts commit 052e679.
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_6235/ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
EuiAccordion's
will-changeCSS creates a stacking context which causes nested positioned components to behave unexpectedly, e.g. fullscreen mode in EuiDataGrid:We're opting removing this CSS for several reasons:
translateZwithwill-change#5806:transform: translatez(0);was a preoptimization. In that case, we can removewill-change, too"translateZwas first added by 5 years ago in a relatively unrelated component PR, so we're guessing the addition this was an unnecessary pre-optimization that was popular in the frontend world at the timewill-changeis intended to be used as a last resort, in order to try to deal with existing performance problems. It should not be used to anticipate performance problems"QA
Checklist