Skip to content

[EuiOverlayMask] Convert to Emotion; remove onClick prop #6090

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 15 commits into from
Aug 31, 2022
Merged

[EuiOverlayMask] Convert to Emotion; remove onClick prop #6090

merged 15 commits into from
Aug 31, 2022

Conversation

@thompsongl
Copy link
Contributor

@thompsongl thompsongl commented Jul 28, 2022 •
edited
Loading

Summary

Like it says on the tin.

Also,

Checklist

  • Checked in both light and dark modes
  • Checked in mobile
  • Checked in Chrome, Safari, Edge, and Firefox
  • Props have proper autodocs and playground toggles
  • Checked Code Sandbox works for any docs examples
  • Added or updated jest and cypress tests
  • Checked for breaking changes and labeled appropriately
  • Checked for accessibility including keyboard-only and screenreader modes
  • A changelog entry exists and is marked appropriately

@thompsongl thompsongl added breaking change PRs with breaking changes. (Don't delete - used for automation) emotion labels Jul 28, 2022
@kibanamachine
Copy link

kibanamachine commented Jul 28, 2022

Preview documentation changes for this PR: https://eui.elastic.co/pr_6090/

@thompsongl thompsongl mentioned this pull request Jul 28, 2022
Closed
49 tasks
@kibanamachine
Copy link

kibanamachine commented Aug 1, 2022

Preview documentation changes for this PR: https://eui.elastic.co/pr_6090/

@thompsongl thompsongl marked this pull request as ready for review August 1, 2022 17:49
@kibanamachine
Copy link

kibanamachine commented Aug 1, 2022

Preview documentation changes for this PR: https://eui.elastic.co/pr_6090/

@thompsongl
Copy link
Contributor Author

thompsongl commented Aug 4, 2022

Setting back to draft until EuiPortal changes are settled

@thompsongl thompsongl marked this pull request as draft August 4, 2022 14:23
@thompsongl thompsongl mentioned this pull request Aug 11, 2022
Merged
2 tasks
@thompsongl thompsongl marked this pull request as ready for review August 22, 2022 20:20
@kibanamachine
Copy link

kibanamachine commented Aug 22, 2022

Preview documentation changes for this PR: https://eui.elastic.co/pr_6090/

chandlerprall
chandlerprall reviewed Aug 29, 2022
View reviewed changes
chandlerprall
chandlerprall suggested changes Aug 29, 2022
View reviewed changes
@thompsongl thompsongl mentioned this pull request Aug 29, 2022
Closed
@thompsongl
Copy link
Contributor Author

thompsongl commented Aug 29, 2022

Hmm now belowHeader isn't working

@kibanamachine
Copy link

kibanamachine commented Aug 29, 2022

Preview documentation changes for this PR: https://eui.elastic.co/pr_6090/

@thompsongl
Copy link
Contributor Author

thompsongl commented Aug 30, 2022

Ready again, @chandlerprall

@kibanamachine
Copy link

kibanamachine commented Aug 30, 2022

Preview documentation changes for this PR: https://eui.elastic.co/pr_6090/

@kibanamachine
Copy link

kibanamachine commented Aug 30, 2022

Preview documentation changes for this PR: https://eui.elastic.co/pr_6090/

chandlerprall
chandlerprall approved these changes Aug 30, 2022
View reviewed changes
Copy link
Contributor

@chandlerprall chandlerprall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes LGTM! Tested in the preview docs

@kibanamachine
Copy link

kibanamachine commented Aug 30, 2022

Preview documentation changes for this PR: https://eui.elastic.co/pr_6090/

@thompsongl thompsongl merged commit 596a65e into elastic:main Aug 31, 2022
@breehall breehall mentioned this pull request Sep 21, 2022
Merged
@cee-chen cee-chen mentioned this pull request Oct 5, 2022
Merged
1 task
@elizabetdev elizabetdev mentioned this pull request Oct 11, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@chandlerprall chandlerprall chandlerprall approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

breaking change PRs with breaking changes. (Don't delete - used for automation) emotion

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[EuiOverlayMask] Remove onClick in favor of EuiFocusTrap combo

3 participants

@thompsongl @kibanamachine @chandlerprall