Skip to content

[EuiDataGrid] Fix buggy header cell display for sorted columns with no actions #6014

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cee-chen merged 3 commits into from
Jun 30, 2022
Merged

[EuiDataGrid] Fix buggy header cell display for sorted columns with no actions #6014

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
5e23791
Fix sort icon visual bug on columns with actions: false
cee-chen Jun 30, 2022
1d5cb62
Changelog
cee-chen Jun 30, 2022
b2c2101
[PR feedback] Remove more CSS
cee-chen Jun 30, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
32 changes: 16 additions & 16 deletions src/components/datagrid/__snapshots__/data_grid.test.tsx.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1064,11 +1064,11 @@ Array [
style="margin-right:0px"
/>
<div
class="euiPopover euiPopover--anchorDownCenter"
class="euiPopover euiPopover--anchorDownCenter eui-fullWidth"
offset="7"
>
<div
class="euiPopover__anchor euiDataGridHeaderCell__anchor"
class="euiPopover__anchor eui-fullWidth"
>
<button
class="euiDataGridHeaderCell__button"
Expand Down Expand Up @@ -1108,11 +1108,11 @@ Array [
style="margin-right:0px"
/>
<div
class="euiPopover euiPopover--anchorDownCenter"
class="euiPopover euiPopover--anchorDownCenter eui-fullWidth"
offset="7"
>
<div
class="euiPopover__anchor euiDataGridHeaderCell__anchor"
class="euiPopover__anchor eui-fullWidth"
>
<button
class="euiDataGridHeaderCell__button"
Expand Down Expand Up @@ -1505,11 +1505,11 @@ Array [
style="margin-right:0px"
/>
<div
class="euiPopover euiPopover--anchorDownCenter"
class="euiPopover euiPopover--anchorDownCenter eui-fullWidth"
offset="7"
>
<div
class="euiPopover__anchor euiDataGridHeaderCell__anchor"
class="euiPopover__anchor eui-fullWidth"
>
<button
class="euiDataGridHeaderCell__button"
Expand Down Expand Up @@ -1549,11 +1549,11 @@ Array [
style="margin-right:0px"
/>
<div
class="euiPopover euiPopover--anchorDownCenter"
class="euiPopover euiPopover--anchorDownCenter eui-fullWidth"
offset="7"
>
<div
class="euiPopover__anchor euiDataGridHeaderCell__anchor"
class="euiPopover__anchor eui-fullWidth"
>
<button
class="euiDataGridHeaderCell__button"
Expand Down Expand Up @@ -2243,11 +2243,11 @@ Array [
style="margin-right:0px"
/>
<div
class="euiPopover euiPopover--anchorDownCenter"
class="euiPopover euiPopover--anchorDownCenter eui-fullWidth"
offset="7"
>
<div
class="euiPopover__anchor euiDataGridHeaderCell__anchor"
class="euiPopover__anchor eui-fullWidth"
>
<button
class="euiDataGridHeaderCell__button"
Expand Down Expand Up @@ -2287,11 +2287,11 @@ Array [
style="margin-right:0px"
/>
<div
class="euiPopover euiPopover--anchorDownCenter"
class="euiPopover euiPopover--anchorDownCenter eui-fullWidth"
offset="7"
>
<div
class="euiPopover__anchor euiDataGridHeaderCell__anchor"
class="euiPopover__anchor eui-fullWidth"
>
<button
class="euiDataGridHeaderCell__button"
Expand Down Expand Up @@ -2664,11 +2664,11 @@ Array [
style="margin-right:0px"
/>
<div
class="euiPopover euiPopover--anchorDownCenter"
class="euiPopover euiPopover--anchorDownCenter eui-fullWidth"
offset="7"
>
<div
class="euiPopover__anchor euiDataGridHeaderCell__anchor"
class="euiPopover__anchor eui-fullWidth"
>
<button
class="euiDataGridHeaderCell__button"
Expand Down Expand Up @@ -2708,11 +2708,11 @@ Array [
style="margin-right:0px"
/>
<div
class="euiPopover euiPopover--anchorDownCenter"
class="euiPopover euiPopover--anchorDownCenter eui-fullWidth"
offset="7"
>
<div
class="euiPopover__anchor euiDataGridHeaderCell__anchor"
class="euiPopover__anchor eui-fullWidth"
>
<button
class="euiDataGridHeaderCell__button"
Expand Down
8 changes: 4 additions & 4 deletions src/components/datagrid/body/__snapshots__/data_grid_body.test.tsx.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,11 +30,11 @@ exports[`EuiDataGridBody renders 1`] = `
style="margin-right:0px"
/>
<div
class="euiPopover euiPopover--anchorDownCenter"
class="euiPopover euiPopover--anchorDownCenter eui-fullWidth"
offset="7"
>
<div
class="euiPopover__anchor euiDataGridHeaderCell__anchor"
class="euiPopover__anchor eui-fullWidth"
>
<button
class="euiDataGridHeaderCell__button"
Expand Down Expand Up @@ -74,11 +74,11 @@ exports[`EuiDataGridBody renders 1`] = `
style="margin-right:0px"
/>
<div
class="euiPopover euiPopover--anchorDownCenter"
class="euiPopover euiPopover--anchorDownCenter eui-fullWidth"
offset="7"
>
<div
class="euiPopover__anchor euiDataGridHeaderCell__anchor"
class="euiPopover__anchor eui-fullWidth"
>
<button
class="euiDataGridHeaderCell__button"
Expand Down
3 changes: 2 additions & 1 deletion src/components/datagrid/body/header/__snapshots__/data_grid_header_cell.test.tsx.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ exports[`EuiDataGridHeaderCell renders 1`] = `
setColumnWidth={[MockFunction]}
/>
<EuiPopover
anchorClassName="euiDataGridHeaderCell__anchor"
anchorClassName="eui-fullWidth"
anchorPosition="downCenter"
button={
<button
Expand All @@ -37,6 +37,7 @@ exports[`EuiDataGridHeaderCell renders 1`] = `
/>
</button>
}
className="eui-fullWidth"
closePopover={[Function]}
display="inlineBlock"
hasArrow={true}
Expand Down
9 changes: 0 additions & 9 deletions src/components/datagrid/body/header/_data_grid_header_row.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,11 +16,6 @@
align-items: center;
display: flex;

> * {
max-width: 100%;
width: 100%;
}

&.euiDataGridHeaderCell--numeric {
text-align: right;
}
Expand All @@ -45,10 +40,6 @@
margin-right: $euiSizeXS;
}

.euiDataGridHeaderCell__anchor {
width: 100%;
}

.euiDataGridHeaderCell__button {
flex: 0 0 auto;
position: relative;
Expand Down
3 changes: 2 additions & 1 deletion src/components/datagrid/body/header/data_grid_header_cell.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -149,7 +149,8 @@ export const EuiDataGridHeaderCell: FunctionComponent<EuiDataGridHeaderCellProps
</>
) : (
<EuiPopover
anchorClassName="euiDataGridHeaderCell__anchor"
className="eui-fullWidth"
anchorClassName="eui-fullWidth"
panelPaddingSize="none"
offset={7}
button={
Expand Down
3 changes: 3 additions & 0 deletions upcoming_changelogs/6014.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
**Bug fixes**

- Fixed buggy `EuiDataGrid` column header display on sorted columns with no actions