[EuiSelectableListItem] Revert layout changes and add textWrap option
#5679
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
March 2, 2022 13:47
…ncate’` And inherited this in [EuiSelectableList] and [EuiSelectable.listProps]
added 2 commits
March 2, 2022 14:06
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_5679/ |
thompsongl
approved these changes
Mar 2, 2022
Contributor
thompsongl
left a comment
thompsongl
left a comment
There was a problem hiding this comment.
All examples mentioned in the summary LGTM.
Code changes 👍
Co-authored-by: Greg Thompson <thompson.glowe@gmail.com>
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_5679/ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
EuiSelectable
I noticed that the changes to the inner content of EuiSelectableListItem made in #5581 really messed with some custom renders like in the sitewide search template:
Before
Originally, the fix was to make it easier to override the truncate/flex nature of the inner list option elements but just removing the extra elements. This wasn't a good fix.
Instead, I've reverted back to the original contents and added an explicit
textWrap = 'truncate' | 'wrap'option to EuiSelectableListItem and inherited this in EuiSelectableList and EuiSelectable.listProps. This immediately fixed the sitewide template:After
EuiSuggest
But it then broke the suggest list item (of course). So in EuiSuggest, I force EuiSuggestItem's own
truncateproperty to betruewhenisVirtualize = trueand set thelistProps.textWrap: isVirtualized ? 'truncate' : 'wrap',.This even fixes the display better for virtualized items by forcing the truncation instead of just cutting off the item:
Before
After
Checklist
[ ] Checked Code Sandbox works for any docs examples[ ] Checked for breaking changes and labeled appropriately[ ] Checked for accessibility including keyboard-only and screenreader modes