-
Notifications
You must be signed in to change notification settings - Fork 886
[EuiDataGrid] Toolbar UI layout reorganization #5334
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
cee-chen
merged 30 commits into
elastic:feat/datagrid/toolbar-reorg-and-row-height-switcher
from
cee-chen:datagrid-toolbar
Nov 10, 2021
Merged
Changes from 2 commits
Commits
Show all changes
30 commits
Select commit
Hold shift + click to select a range
130c722
[Setup] Move toolbar CSS to own file
cee-chen 52398d9
[Cleanup] DRY out repeated specific CSS class
cee-chen fc2203f
Reorder toolbar per Caroline's mocks
cee-chen 8ddb5e2
Convert display buttons to icons only
cee-chen e5871eb
Convert density UI to a compressed EuiFormRow w/ new text/order per m…
cee-chen 2782596
Update test snapshots
cee-chen 84009b0
Add changelog entry
cee-chen 6d71251
Merge branch 'master' into datagrid-toolbar
cee-chen 7b1158a
[PR feedback] Revert location of additionalControls + fix props descr…
cee-chen 05a696d
[PR feedback] CSS feedback
cee-chen 6e3ecce
[PR feature request] Change toolbar icon based on grid density
cee-chen 07ea746
[PR feedback][extra] Fix missing sort control on styling example
cee-chen e4e5d95
updoot snaps
cee-chen 6611bf5
Merge branch 'master' into datagrid-toolbar
constancecchen 2f38124
Merge branch 'master' into datagrid-toolbar
cee-chen 87dfa97
Merge branch 'main' into datagrid-toolbar
cee-chen a9286d2
Fix changelog
cee-chen ba33c75
[misc] Reorganize EuiDataGridToolbar utils to bottom of file
cee-chen d740d08
Rename CSS toolbar class to left/right to match API
cee-chen 5ee90d7
Add API support for left/right positioning of `additionalControls`
cee-chen 440e5ef
Update additionalControls documentation + example
cee-chen 5ba6a95
PR feedback & cleanup from Caroline (#4)
cchaos 4747d09
Update CSS class to be more specific
cee-chen 99de8bc
closes #5092 - add changelog for fullscreen bugfix in Caroline's work
cee-chen 8ec3bd1
Merge branch 'feat/datagrid/toolbar-reorg-and-row-height-switcher' in…
constancecchen a8c12ed
Merge branch 'main' into datagrid-toolbar
cee-chen 9a4a5c7
[PR feedback] Changelog
cee-chen 2c18e4d
Update snapshots
cee-chen 7abae68
PR feedback
cee-chen 921d9c2
Remove unused CSS class
cee-chen File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,52 @@ | ||
| .euiDataGrid__controls { | ||
| background: $euiPageBackgroundColor; | ||
| position: relative; | ||
| z-index: 3; // Needs to sit above the content blow that sits below it | ||
| border: $euiBorderThin; | ||
| padding: $euiSizeXS; | ||
| flex-grow: 0; | ||
|
|
||
| > * { | ||
| margin-left: $euiSizeXS / 2; | ||
| } | ||
| } | ||
|
|
||
| .euiDataGrid__controlBtn { | ||
| border-radius: $euiBorderRadius; | ||
|
|
||
| &:focus { | ||
| background: shadeOrTint($euiColorLightestShade, 10%, 10%); | ||
| } | ||
| } | ||
|
|
||
| .euiDataGrid__controlBtn--active, | ||
| .euiDataGrid__controlBtn--active:focus { | ||
| font-weight: $euiFontWeightSemiBold; | ||
| color: $euiColorFullShade; | ||
| } | ||
|
|
||
| @include euiDataGridStyles(bordersNone) { | ||
| .euiDataGrid__controls { | ||
| border: none; | ||
| background: $euiColorEmptyShade; | ||
| } | ||
| } | ||
|
|
||
| @include euiDataGridStyles(bordersHorizontal) { | ||
| .euiDataGrid__controls { | ||
| border-right: none; | ||
| border-left: none; | ||
| border-top: none; | ||
| background: $euiColorEmptyShade; | ||
| } | ||
| } | ||
|
|
||
| .euiDataGrid__controlPopover { | ||
| // Hack because the fixed positions of drag and drop don't work inside of transformed elements | ||
| // sass-lint:disable-block no-important | ||
| transform: none !important; | ||
| transition: none !important; | ||
| margin-top: -$euiSizeS; | ||
| // IE11 needs a min-width | ||
| min-width: $euiSize * 12; | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.