Skip to content
Merged
Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
30 commits
Select commit Hold shift + click to select a range
130c722
[Setup] Move toolbar CSS to own file
cee-chen Oct 27, 2021
52398d9
[Cleanup] DRY out repeated specific CSS class
cee-chen Oct 27, 2021
fc2203f
Reorder toolbar per Caroline's mocks
cee-chen Oct 27, 2021
8ddb5e2
Convert display buttons to icons only
cee-chen Oct 27, 2021
e5871eb
Convert density UI to a compressed EuiFormRow w/ new text/order per m…
cee-chen Oct 27, 2021
2782596
Update test snapshots
cee-chen Oct 27, 2021
84009b0
Add changelog entry
cee-chen Oct 27, 2021
6d71251
Merge branch 'master' into datagrid-toolbar
cee-chen Oct 29, 2021
7b1158a
[PR feedback] Revert location of additionalControls + fix props descr…
cee-chen Oct 29, 2021
05a696d
[PR feedback] CSS feedback
cee-chen Oct 29, 2021
6e3ecce
[PR feature request] Change toolbar icon based on grid density
cee-chen Oct 29, 2021
07ea746
[PR feedback][extra] Fix missing sort control on styling example
cee-chen Oct 29, 2021
e4e5d95
updoot snaps
cee-chen Oct 29, 2021
6611bf5
Merge branch 'master' into datagrid-toolbar
constancecchen Nov 1, 2021
2f38124
Merge branch 'master' into datagrid-toolbar
cee-chen Nov 2, 2021
87dfa97
Merge branch 'main' into datagrid-toolbar
cee-chen Nov 4, 2021
a9286d2
Fix changelog
cee-chen Nov 4, 2021
ba33c75
[misc] Reorganize EuiDataGridToolbar utils to bottom of file
cee-chen Nov 4, 2021
d740d08
Rename CSS toolbar class to left/right to match API
cee-chen Nov 4, 2021
5ee90d7
Add API support for left/right positioning of `additionalControls`
cee-chen Nov 4, 2021
440e5ef
Update additionalControls documentation + example
cee-chen Nov 4, 2021
5ba6a95
PR feedback & cleanup from Caroline (#4)
cchaos Nov 8, 2021
4747d09
Update CSS class to be more specific
cee-chen Nov 8, 2021
99de8bc
closes #5092 - add changelog for fullscreen bugfix in Caroline's work
cee-chen Nov 8, 2021
8ec3bd1
Merge branch 'feat/datagrid/toolbar-reorg-and-row-height-switcher' in…
constancecchen Nov 8, 2021
a8c12ed
Merge branch 'main' into datagrid-toolbar
cee-chen Nov 9, 2021
9a4a5c7
[PR feedback] Changelog
cee-chen Nov 9, 2021
2c18e4d
Update snapshots
cee-chen Nov 9, 2021
7abae68
PR feedback
cee-chen Nov 9, 2021
921d9c2
Remove unused CSS class
cee-chen Nov 10, 2021
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
43 changes: 0 additions & 43 deletions src/components/datagrid/_data_grid.scss
Original file line number Diff line number Diff line change
Expand Up @@ -36,49 +36,6 @@
background: $euiColorEmptyShade;
}

.euiDataGrid__controls {
background: $euiPageBackgroundColor;
position: relative;
z-index: 3; // Needs to sit above the content blow that sits below it
border: $euiBorderThin;
padding: $euiSizeXS;
flex-grow: 0;

> * {
margin-left: $euiSizeXS / 2;
}
}

.euiDataGrid__controlBtn {
border-radius: $euiBorderRadius;

&:focus {
background: shadeOrTint($euiColorLightestShade, 10%, 10%);
}
}

.euiDataGrid__controlBtn--active,
.euiDataGrid__controlBtn--active:focus {
font-weight: $euiFontWeightSemiBold;
color: $euiColorFullShade;
}

@include euiDataGridStyles(bordersNone) {
.euiDataGrid__controls {
border: none;
background: $euiColorEmptyShade;
}
}

@include euiDataGridStyles(bordersHorizontal) {
.euiDataGrid__controls {
border-right: none;
border-left: none;
border-top: none;
background: $euiColorEmptyShade;
}
}

.euiDataGrid__pagination {

padding-top: $euiSizeXS;
Expand Down
1 change: 1 addition & 0 deletions src/components/datagrid/_index.scss
Original file line number Diff line number Diff line change
Expand Up @@ -5,5 +5,6 @@
@import 'body/data_grid_footer_row';
@import 'body/header/data_grid_column_resizer';
@import 'data_grid_data_row';
@import 'controls/data_grid_toolbar';
@import 'controls/data_grid_column_selector';
@import 'controls/data_grid_column_sorting';
10 changes: 0 additions & 10 deletions src/components/datagrid/controls/_data_grid_column_selector.scss
Original file line number Diff line number Diff line change
Expand Up @@ -17,13 +17,3 @@
.euiDataGridColumnSelector__itemLabel {
@include euiFontSizeXS;
}

.euiDataGridColumnSelectorPopover {
// Hack because the fixed positions of drag and drop don't work inside of transformed elements
// sass-lint:disable-block no-important
transform: none !important;
transition: none !important;
margin-top: -$euiSizeS;
// IE11 needs a min-width
min-width: $euiSize * 12;
}
10 changes: 0 additions & 10 deletions src/components/datagrid/controls/_data_grid_column_sorting.scss
Original file line number Diff line number Diff line change
Expand Up @@ -6,16 +6,6 @@
}
}

.euiDataGridColumnSortingPopover {
// Hack because the fixed positions of drag and drop don't work inside of transformed elements
// sass-lint:disable-block no-important
transform: none !important;
transition: none !important;
margin-top: -$euiSizeS;
// IE11 needs a min-width
min-width: $euiSize * 12;
}

.euiDataGridColumnSorting__fieldList {
@include euiYScrollWithShadows;
padding-top: $euiSizeXS;
Expand Down
52 changes: 52 additions & 0 deletions src/components/datagrid/controls/_data_grid_toolbar.scss
Original file line number Diff line number Diff line change
@@ -0,0 +1,52 @@
.euiDataGrid__controls {
background: $euiPageBackgroundColor;
position: relative;
z-index: 3; // Needs to sit above the content blow that sits below it
border: $euiBorderThin;
padding: $euiSizeXS;
flex-grow: 0;

> * {
margin-left: $euiSizeXS / 2;
}
}

.euiDataGrid__controlBtn {
border-radius: $euiBorderRadius;

&:focus {
background: shadeOrTint($euiColorLightestShade, 10%, 10%);
}
}

.euiDataGrid__controlBtn--active,
.euiDataGrid__controlBtn--active:focus {
font-weight: $euiFontWeightSemiBold;
color: $euiColorFullShade;
}

@include euiDataGridStyles(bordersNone) {
.euiDataGrid__controls {
border: none;
background: $euiColorEmptyShade;
}
}

@include euiDataGridStyles(bordersHorizontal) {
.euiDataGrid__controls {
border-right: none;
border-left: none;
border-top: none;
background: $euiColorEmptyShade;
}
}

.euiDataGrid__controlPopover {
// Hack because the fixed positions of drag and drop don't work inside of transformed elements
// sass-lint:disable-block no-important
transform: none !important;
transition: none !important;
margin-top: -$euiSizeS;
// IE11 needs a min-width
min-width: $euiSize * 12;
Comment thread
cee-chen marked this conversation as resolved.
Outdated
}
2 changes: 1 addition & 1 deletion src/components/datagrid/controls/column_selector.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -155,7 +155,7 @@ export const useDataGridColumnSelector = (
closePopover={() => setIsOpen(false)}
anchorPosition="downLeft"
panelPaddingSize="s"
panelClassName="euiDataGridColumnSelectorPopover"
panelClassName="euiDataGrid__controlPopover"
button={
<EuiButtonEmpty
size="xs"
Expand Down
2 changes: 1 addition & 1 deletion src/components/datagrid/controls/column_sorting.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -141,7 +141,7 @@ export const useDataGridColumnSorting = (
closePopover={() => setIsOpen(false)}
anchorPosition="downLeft"
panelPaddingSize="s"
panelClassName="euiDataGridColumnSortingPopover"
panelClassName="euiDataGrid__controlPopover"
button={
<EuiButtonEmpty
size="xs"
Expand Down
2 changes: 1 addition & 1 deletion src/components/datagrid/controls/style_selector.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,7 @@ export const useDataGridStyleSelector = (
closePopover={() => setIsOpen(false)}
anchorPosition="downCenter"
panelPaddingSize="s"
panelClassName="euiDataGridColumnSelectorPopover"
panelClassName="euiDataGrid__controlPopover"
button={
<EuiButtonEmpty
size="xs"
Expand Down