Skip to content

[EuiDataGrid] Allow the grid to expand & contract with changing rowCount values #5313

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
chandlerprall merged 5 commits into from
Oct 27, 2021
Merged

[EuiDataGrid] Allow the grid to expand & contract with changing rowCount values #5313

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
4eb6746
Allow the datagrid to expand&contract in response to different row co…
chandlerprall Oct 21, 2021
6427142
[revert me]
chandlerprall Oct 21, 2021
c3a9e23
Revert "[revert me]"
chandlerprall Oct 27, 2021
344862f
Merge branch 'master' into bug/5030-datagrid-resize-with-rowcount
chandlerprall Oct 27, 2021
e74a97f
changelog
chandlerprall Oct 27, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@

- Fixed default text alignment in `EuiTableRowCell` on Safari ([#5283](https://github.com/elastic/eui/pull/5283))
- Fixed `mobileOptions.truncateText` from getting overridden by `truncateText` in `EuiTableRowCell` ([#5283](https://github.com/elastic/eui/pull/5283))
- Fixed issue with dynamic row counts in `EuiDataGrid` ([#5313](https://github.com/elastic/eui/pull/5313))

**Theme: Amsterdam**

Expand Down
2 changes: 1 addition & 1 deletion src/components/datagrid/body/data_grid_body.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -618,7 +618,7 @@ export const EuiDataGridBody: FunctionComponent<EuiDataGridBodyProps> = (

// reset height constraint when rowCount changes
useEffect(() => {
setHeight(wrapperRef.current!.getBoundingClientRect().height);
setHeight(undefined);
}, [rowCount]);

useEffect(() => {
Expand Down