Skip to content

[EuiAvatar] Added isDisabled Property to the EuiAvatar tag#4549

Merged
cchaos merged 16 commits intoelastic:masterfrom
anuragxxd:master
Feb 23, 2021
Merged

[EuiAvatar] Added isDisabled Property to the EuiAvatar tag#4549
cchaos merged 16 commits intoelastic:masterfrom
anuragxxd:master

Conversation

@anuragxxd
Copy link
Contributor

@anuragxxd anuragxxd commented Feb 18, 2021

Summary

Added isDisabled Property to the EuiAvatar tag.
This resolves the issue #4500

Checklist

  • Check against all themes for compatibility in both light and dark modes
  • Checked in mobile
  • Checked in Chrome, Safari, Edge, and Firefox
  • Props have proper autodocs and playground toggles
  • Added documentation
  • Checked Code Sandbox works for the any docs examples
  • Added or updated jest tests
  • [] Checked for breaking changes and labeled appropriately
  • [] Checked for accessibility including keyboard-only and screenreader modes
  • A changelog entry exists and is marked appropriately

@kibanamachine
Copy link

Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually?

Copy link
Contributor

@snide snide left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't forget about how this handles when the avatar is an image.

@anuragxxd
Copy link
Contributor Author

@cchaos @snide can you please review this. :)

Copy link
Contributor

@cchaos cchaos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Something went funky with the docs/bundle file. Please delete the .icloud file and undelete the normal one.

@cchaos
Copy link
Contributor

cchaos commented Feb 21, 2021

Also, this prop will need a test and the PR needs a Changelog. Thanks!

@anuragxxd
Copy link
Contributor Author

Will do the changes 👍🏼

@anuragxxd
Copy link
Contributor Author

@cchaos done with all the changes you asked for.

@cchaos
Copy link
Contributor

cchaos commented Feb 22, 2021

Jenkins, test this

@kibanamachine
Copy link

Preview documentation changes for this PR: https://eui.elastic.co/pr_4549/

Copy link
Contributor

@cchaos cchaos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! Thanks so much!

@cchaos
Copy link
Contributor

cchaos commented Feb 22, 2021

Jenkins, test this

@snide
Copy link
Contributor

snide commented Feb 23, 2021

jenkins, test this

@snide
Copy link
Contributor

snide commented Feb 23, 2021

Just a note on this one. This visually fixes the problems, but we'll likely want to do a follow up PR to address avatars always being a div. More than likely we need to add something to similar to EuiButton where it can be configured to use a button when an href or onClick is present.

@snide snide mentioned this pull request Feb 23, 2021
@kibanamachine
Copy link

Preview documentation changes for this PR: https://eui.elastic.co/pr_4549/

@cchaos
Copy link
Contributor

cchaos commented Feb 23, 2021

Jenkins, test this

@kibanamachine
Copy link

Preview documentation changes for this PR: https://eui.elastic.co/pr_4549/

@cchaos
Copy link
Contributor

cchaos commented Feb 23, 2021

Blerg, CI is being temperamental.

Jenkins, test this

@kibanamachine
Copy link

Preview documentation changes for this PR: https://eui.elastic.co/pr_4549/

@cchaos cchaos merged commit 15e8558 into elastic:master Feb 23, 2021
@GerardoPM GerardoPM mentioned this pull request Mar 1, 2022
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants