Skip to content

[Amsterdam] Small styling adjustments in tooltips #4353

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cchaos merged 4 commits into from
Dec 7, 2020
Merged

[Amsterdam] Small styling adjustments in tooltips #4353

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
007b519
adjust padding in tooltip
andreadelrio Dec 4, 2020
cd5472d
cl
andreadelrio Dec 4, 2020
cd7af7e
reduce border-radius in EuiRange's tooltip
andreadelrio Dec 6, 2020
dfa4eca
change variable for border radius
andreadelrio Dec 7, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,8 @@
- Removed the shadow in `EuiComment` ([#4321](https://github.com/elastic/eui/pull/4321))
- Reduced font size for `xs` size in `EuiButtonEmpty` ([#4325](https://github.com/elastic/eui/pull/4325))
- Increased font size for `m` size of `EuiListGroupItem` ([#4340](https://github.com/elastic/eui/pull/4340))
- Reduced padding in `EuiToolTip` ([#4353](https://github.com/elastic/eui/pull/4353))
- Reduced border-radius in `EuiRange`'s tooltip ([#4353](https://github.com/elastic/eui/pull/4353))

## [`30.5.1`](https://github.com/elastic/eui/tree/v30.5.1)

Expand Down
2 changes: 2 additions & 0 deletions src/themes/eui-amsterdam/overrides/_index.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,5 +20,7 @@
@import 'overlay_mask';
@import 'popover';
@import 'progress';
@import 'range';
@import 'text';
@import 'toast';
@import 'tooltip';
3 changes: 3 additions & 0 deletions src/themes/eui-amsterdam/overrides/_range.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
.euiRangeTooltip__value {
border-radius: $euiSizeXS;

@elizabetdev elizabetdev Dec 7, 2020

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just noticed this now. We have a border-radius variable that is 4px like the $euiSizeXS;

Suggested change
border-radius: $euiSizeXS;
border-radius: $euiBorderRadius;

@andreadelrio andreadelrio Dec 7, 2020

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@miukimiu thing is, $euiBorderRadius evaluates to 6px in Amsterdam

https://github.com/elastic/eui/blob/master/src/themes/eui-amsterdam/global_styling/variables/_borders.scss

@cchaos cchaos Dec 7, 2020

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about $euiBorderRadiusSmall? 😉

@andreadelrio andreadelrio Dec 7, 2020

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

}
3 changes: 3 additions & 0 deletions src/themes/eui-amsterdam/overrides/_tooltip.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
.euiToolTip {
padding: $euiSizeS;
}