[Amsterdam] Small styling adjustments in tooltips #4353
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_4353/ |
1 similar comment
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_4353/ |
andreadelrio
changed the title
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_4353/ |
elizabetdev
approved these changes
Dec 7, 2020
Contributor
elizabetdev
left a comment
elizabetdev
left a comment
There was a problem hiding this comment.
Tested in Chrome, Safari, Edge, and Firefox. LGTM! 🎉
elizabetdev
reviewed
Dec 7, 2020
| @@ -0,0 +1,3 @@ | |||
| .euiRangeTooltip__value { | |||
| border-radius: $euiSizeXS; | |||
Contributor
There was a problem hiding this comment.
Just noticed this now. We have a border-radius variable that is 4px like the $euiSizeXS;
Suggested change
| border-radius: $euiSizeXS; | |
| border-radius: $euiBorderRadius; |
Contributor
Author
There was a problem hiding this comment.
@miukimiu thing is, $euiBorderRadius evaluates to 6px in Amsterdam
Contributor
There was a problem hiding this comment.
How about $euiBorderRadiusSmall? 😉
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_4353/ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
EuiToolTipand therefore overall size to better align with smaller font size.EuiRange's tooltip border-radiusChecklist
- [ ] Check against all themes for compatibility in both light and dark modes- [ ] Checked in mobile- [ ] Props have proper autodocs- [ ] Added documentation- [ ] Checked Code Sandbox works for the any docs examples- [ ] Added or updated jest tests- [ ] Checked for breaking changes and labeled appropriately- [ ] Checked for accessibility including keyboard-only and screenreader modes