-
Notifications
You must be signed in to change notification settings - Fork 857
Converts NavDrawer, NavDrawerGroup, and NavDrawerFlyout to TypeScript #3268
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
thompsongl
merged 7 commits into
elastic:master
from
dimitropoulos:navdrawer-typescript
Apr 13, 2020
Merged
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
6d5ad6b
converts NavDrawer, NavDrawerGroup, and NavDrawerFlyout to TypeScript
dimitropoulos d642d97
uses useRef instead of useState for simple ref usage
dimitropoulos 640b989
adds HTMLAttributes to EuiNavDrawerProps interface
dimitropoulos 2abc9e1
updates EuiNavDrawerGroupProps types per review feedback
dimitropoulos d04bc4d
Update src/components/nav_drawer/nav_drawer.tsx
dimitropoulos 419cc40
Update src/components/nav_drawer/nav_drawer.tsx
dimitropoulos f0d9c92
Merge branch 'master' into navdrawer-typescript
thompsongl File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
File renamed without changes.
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,6 @@ | ||
| export { EuiNavDrawer, EuiNavDrawerProps } from './nav_drawer'; | ||
| export { EuiNavDrawerGroup, EuiNavDrawerGroupProps } from './nav_drawer_group'; | ||
| export { | ||
| EuiNavDrawerFlyout, | ||
| EuiNavDrawerFlyoutProps, | ||
| } from './nav_drawer_flyout'; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.